From: Matthias Kaehlcke <mka@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
gregkh@linuxfoundation.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, akashast@codeaurora.org,
rojay@codeaurora.org, msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V2 3/3] tty: serial: qcom_geni_serial: Fix the UART wakeup issue
Date: Mon, 17 Aug 2020 10:42:22 -0700 [thread overview]
Message-ID: <20200817174222.GC2995789@google.com> (raw)
In-Reply-To: <1595563082-2353-4-git-send-email-skakit@codeaurora.org>
On Fri, Jul 24, 2020 at 09:28:02AM +0530, satya priya wrote:
> As a part of system suspend we call uart_port_suspend from the
> Serial driver, which calls set_mctrl passing mctrl as NULL. This
> makes RFR high(NOT_READY) during suspend.
>
> Due to this BT SoC is not able to send wakeup bytes to UART during
> suspend. Included if check for non-suspend case to keep RFR low
> during suspend.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V2:
> - This patch fixes the UART flow control issue during suspend.
> Newly added in V2.
>
> drivers/tty/serial/qcom_geni_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 07b7b6b..7108dfc 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -242,7 +242,7 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport,
> if (mctrl & TIOCM_LOOP)
> port->loopback = RX_TX_CTS_RTS_SORTED;
>
> - if (!(mctrl & TIOCM_RTS))
> + if ((!(mctrl & TIOCM_RTS)) && (!(uport->suspended)))
Why all these parentheses, instead of:
if (!(mctrl & TIOCM_RTS) && !uport->suspended)
?
next prev parent reply other threads:[~2020-08-17 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 3:57 [PATCH V2 0/3] Add wakeup support over UART RX satya priya
2020-07-24 3:58 ` [PATCH V2 1/3] arm64: dts: sc7180: " satya priya
2020-07-28 5:36 ` Akash Asthana
2020-07-24 3:58 ` [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart satya priya
2020-07-28 5:38 ` Akash Asthana
2020-08-17 18:01 ` Matthias Kaehlcke
2020-08-17 23:33 ` Matthias Kaehlcke
2020-08-19 13:48 ` skakit
2020-08-19 13:49 ` skakit
2020-08-19 16:13 ` Matthias Kaehlcke
2020-08-20 12:19 ` skakit
2020-08-21 15:59 ` Matthias Kaehlcke
2020-07-24 3:58 ` [PATCH V2 3/3] tty: serial: qcom_geni_serial: Fix the UART wakeup issue satya priya
2020-07-24 8:42 ` Greg KH
2020-07-28 5:40 ` Akash Asthana
2020-08-17 17:42 ` Matthias Kaehlcke [this message]
2020-08-19 13:49 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817174222.GC2995789@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).