From: Matthias Kaehlcke <mka@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
gregkh@linuxfoundation.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, akashast@codeaurora.org,
rojay@codeaurora.org, msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart
Date: Mon, 17 Aug 2020 11:01:58 -0700 [thread overview]
Message-ID: <20200817180158.GD2995789@google.com> (raw)
In-Reply-To: <1595563082-2353-3-git-send-email-skakit@codeaurora.org>
On Fri, Jul 24, 2020 at 09:28:01AM +0530, satya priya wrote:
> Add sleep pin ctrl for BT uart, and also change the bias
> configuration to match Bluetooth module.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V2:
> - This patch adds sleep state for BT UART. Newly added in V2.
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 42 ++++++++++++++++++++++++++++-----
> 1 file changed, 36 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 26cc491..bc919f2 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -469,20 +469,50 @@
>
> &qup_uart3_default {
> pinconf-cts {
> - /*
> - * Configure a pull-down on 38 (CTS) to match the pull of
> - * the Bluetooth module.
> - */
> + /* Configure no pull on 38 (CTS) to match Bluetooth module */
Has the pull from the Bluetooth module been removed or did the previous config
incorrectly claim that the Bluetooth module has a pull-down?
> pins = "gpio38";
> + bias-disable;
> + };
> +
> + pinconf-rts {
> + /* We'll drive 39 (RTS), so configure pull-down */
> + pins = "gpio39";
> + drive-strength = <2>;
> bias-pull-down;
> + };
> +
> + pinconf-tx {
> + /* We'll drive 40 (TX), so no pull */
The rationales for RTS and TX contradict each other. According to the comment
the reason to configure a pull-down on RTS is that it is driven by the host.
Then for TX the reason to configure no pull is that it is driven by the host.
Please make sure the comments *really* describe the rationale, otherwise they
are just confusing.
next prev parent reply other threads:[~2020-08-17 18:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 3:57 [PATCH V2 0/3] Add wakeup support over UART RX satya priya
2020-07-24 3:58 ` [PATCH V2 1/3] arm64: dts: sc7180: " satya priya
2020-07-28 5:36 ` Akash Asthana
2020-07-24 3:58 ` [PATCH V2 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart satya priya
2020-07-28 5:38 ` Akash Asthana
2020-08-17 18:01 ` Matthias Kaehlcke [this message]
2020-08-17 23:33 ` Matthias Kaehlcke
2020-08-19 13:48 ` skakit
2020-08-19 13:49 ` skakit
2020-08-19 16:13 ` Matthias Kaehlcke
2020-08-20 12:19 ` skakit
2020-08-21 15:59 ` Matthias Kaehlcke
2020-07-24 3:58 ` [PATCH V2 3/3] tty: serial: qcom_geni_serial: Fix the UART wakeup issue satya priya
2020-07-24 8:42 ` Greg KH
2020-07-28 5:40 ` Akash Asthana
2020-08-17 17:42 ` Matthias Kaehlcke
2020-08-19 13:49 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817180158.GD2995789@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).