[PATCH 0/8] drivers: phy: Constify static phy_ops structs

[PATCH 0/8] drivers: phy: Constify static phy_ops structs

[Rikard Falkeborn]

This series constifies all static phy_ops structs in drivers/phy.
Typically the only usage is to pass the address of it to devm_phy_create()
which takes a const pointer. The lone exception is in
drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c where the address of the
structs is assigned to the data-field in of_device_id, which is a const
void pointer.

Making the structs const allows the compiler to put them in read-only
memory.

The patches are all independent of each other, and have been
compile-tested only.

Rikard Falkeborn (8):
  phy: cadence: salvo: Constify cdns_salvo_phy_ops
  phy: fsl-imx8mq-usb: Constify imx8mq_usb_phy_ops
  phy: hisilicon; Constify hi3660_phy_ops
  phy: lantiq: rcu-usb2: Constify ltq_rcu_usb2_phy_ops
  phy: lantiq: vrx200-pcie: Constify ltq_vrx200_pcie_phy_ops
  phy: ralink-usb: Constify ralink_usb_phy_ops
  phy: samsung-ufs: Constify samsung_ufs_phy_ops
  phy: qcom-ipq4019-usb: Constify static phy_ops structs

 drivers/phy/cadence/phy-cadence-salvo.c     | 2 +-
 drivers/phy/freescale/phy-fsl-imx8mq-usb.c  | 2 +-
 drivers/phy/hisilicon/phy-hi3660-usb3.c     | 2 +-
 drivers/phy/lantiq/phy-lantiq-rcu-usb2.c    | 2 +-
 drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c | 2 +-
 drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c | 4 ++--
 drivers/phy/ralink/phy-ralink-usb.c         | 2 +-
 drivers/phy/samsung/phy-samsung-ufs.c       | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.28.0

[PATCH 8/8] phy: qcom-ipq4019-usb: Constify static phy_ops structs

[Rikard Falkeborn]

Their only usages is to assign the address to the data field in the
of_device_id struct, which is a const void pointer. Make them const to
allow the compiler to put them in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c
index b8ef331e1545..fc7f9df80a7b 100644
--- a/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c
@@ -48,7 +48,7 @@ static int ipq4019_ss_phy_power_on(struct phy *_phy)
 	return 0;
 }
 
-static struct phy_ops ipq4019_usb_ss_phy_ops = {
+static const struct phy_ops ipq4019_usb_ss_phy_ops = {
 	.power_on	= ipq4019_ss_phy_power_on,
 	.power_off	= ipq4019_ss_phy_power_off,
 };
@@ -80,7 +80,7 @@ static int ipq4019_hs_phy_power_on(struct phy *_phy)
 	return 0;
 }
 
-static struct phy_ops ipq4019_usb_hs_phy_ops = {
+static const struct phy_ops ipq4019_usb_hs_phy_ops = {
 	.power_on	= ipq4019_hs_phy_power_on,
 	.power_off	= ipq4019_hs_phy_power_off,
 };
-- 
2.28.0

Re: [PATCH 0/8] drivers: phy: Constify static phy_ops structs

[Joe Perches]

On Mon, 2020-08-24 at 00:00 +0200, Rikard Falkeborn wrote:
> This series constifies all static phy_ops structs in drivers/phy.
> Typically the only usage is to pass the address of it to devm_phy_create()
> which takes a const pointer. The lone exception is in
> drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c where the address of the
> structs is assigned to the data-field in of_device_id, which is a const
> void pointer.
> 
> Making the structs const allows the compiler to put them in read-only
> memory.
> 
> The patches are all independent of each other, and have been
> compile-tested only.

Perhaps add phy_ops to scripts/const_structs.checkpatch too
---
 scripts/const_structs.checkpatch | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
index e9df9cc28a85..cd45cb3c2b04 100644
--- a/scripts/const_structs.checkpatch
+++ b/scripts/const_structs.checkpatch
@@ -39,6 +39,7 @@ nlmsvc_binding
 nvkm_device_chip
 of_device_id
 pci_raw_ops
+phy_ops
 pipe_buf_operations
 platform_hibernation_ops
 platform_suspend_ops

Re: [PATCH 0/8] drivers: phy: Constify static phy_ops structs

[Vinod Koul]

On 24-08-20, 00:00, Rikard Falkeborn wrote:
> This series constifies all static phy_ops structs in drivers/phy.
> Typically the only usage is to pass the address of it to devm_phy_create()
> which takes a const pointer. The lone exception is in
> drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c where the address of the
> structs is assigned to the data-field in of_device_id, which is a const
> void pointer.
> 
> Making the structs const allows the compiler to put them in read-only
> memory.
> 
> The patches are all independent of each other, and have been
> compile-tested only.

Applied all, thanks

-- 
~Vinod