From: Greg KH <gregkh@linuxfoundation.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: hemantk@codeaurora.org, jhugo@codeaurora.org,
bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/18] bus: mhi: core: Introduce sysfs entries for MHI
Date: Sun, 27 Sep 2020 12:26:59 +0200 [thread overview]
Message-ID: <20200927102659.GC87283@kroah.com> (raw)
In-Reply-To: <20200921160815.28071-17-manivannan.sadhasivam@linaro.org>
On Mon, Sep 21, 2020 at 09:38:12PM +0530, Manivannan Sadhasivam wrote:
> From: Bhaumik Bhatt <bbhatt@codeaurora.org>
>
> Introduce sysfs entries to enable userspace clients the ability to read
> the serial number and the OEM PK Hash values obtained from BHI. OEMs
> need to read these device-specific hardware information values through
> userspace for factory testing purposes and cannot be exposed via degbufs
> as it may remain disabled for performance reasons. Also, update the
> documentation for ABI to include these entries.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/ABI/stable/sysfs-bus-mhi | 21 ++++++++++
> MAINTAINERS | 1 +
> drivers/bus/mhi/core/init.c | 53 ++++++++++++++++++++++++++
> 3 files changed, 75 insertions(+)
> create mode 100644 Documentation/ABI/stable/sysfs-bus-mhi
>
> diff --git a/Documentation/ABI/stable/sysfs-bus-mhi b/Documentation/ABI/stable/sysfs-bus-mhi
> new file mode 100644
> index 000000000000..ecfe7662f8d0
> --- /dev/null
> +++ b/Documentation/ABI/stable/sysfs-bus-mhi
> @@ -0,0 +1,21 @@
> +What: /sys/bus/mhi/devices/.../serialnumber
> +Date: Sept 2020
> +KernelVersion: 5.10
> +Contact: Bhaumik Bhatt <bbhatt@codeaurora.org>
> +Description: The file holds the serial number of the client device obtained
> + using a BHI (Boot Host Interface) register read after at least
> + one attempt to power up the device has been done. If read
> + without having the device power on at least once, the file will
> + read all 0's.
> +Users: Any userspace application or clients interested in device info.
> +
> +What: /sys/bus/mhi/devices/.../oem_pk_hash
> +Date: Sept 2020
> +KernelVersion: 5.10
> +Contact: Bhaumik Bhatt <bbhatt@codeaurora.org>
> +Description: The file holds the OEM PK Hash value of the endpoint device
> + obtained using a BHI (Boot Host Interface) register read after
> + at least one attempt to power up the device has been done. If
> + read without having the device power on at least once, the file
> + will read all 0's.
> +Users: Any userspace application or clients interested in device info.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index deaafb617361..11e7be9b9163 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11323,6 +11323,7 @@ M: Hemant Kumar <hemantk@codeaurora.org>
> L: linux-arm-msm@vger.kernel.org
> S: Maintained
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git
> +F: Documentation/ABI/stable/sysfs-bus-mhi
> F: Documentation/mhi/
> F: drivers/bus/mhi/
> F: include/linux/mhi.h
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 61e5885a331a..1b4161eaf0d8 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -76,6 +76,56 @@ const char *to_mhi_pm_state_str(enum mhi_pm_state state)
> return mhi_pm_state_str[index];
> }
>
> +static ssize_t serial_number_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct mhi_device *mhi_dev = to_mhi_device(dev);
> + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> +
> + return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n",
> + mhi_cntrl->serial_number);
> +}
> +static DEVICE_ATTR_RO(serial_number);
> +
> +static ssize_t oem_pk_hash_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct mhi_device *mhi_dev = to_mhi_device(dev);
> + struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> + int i, cnt = 0;
> +
> + for (i = 0; i < ARRAY_SIZE(mhi_cntrl->oem_pk_hash); i++)
> + cnt += snprintf(buf + cnt, PAGE_SIZE - cnt,
> + "OEMPKHASH[%d]: 0x%x\n", i,
> + mhi_cntrl->oem_pk_hash[i]);
> +
> + return cnt;
> +}
> +static DEVICE_ATTR_RO(oem_pk_hash);
> +
> +static struct attribute *mhi_sysfs_attrs[] = {
> + &dev_attr_serial_number.attr,
> + &dev_attr_oem_pk_hash.attr,
> + NULL,
> +};
> +
> +static const struct attribute_group mhi_sysfs_group = {
> + .attrs = mhi_sysfs_attrs,
> +};
> +
> +static int mhi_create_sysfs(struct mhi_controller *mhi_cntrl)
> +{
> + return sysfs_create_group(&mhi_cntrl->mhi_dev->dev.kobj,
> + &mhi_sysfs_group);
You should never have to call a sysfs_* function from a driver or bus
code, that implies something is wrong :)
Just set the sysfs attributes to be the default groups for your
bus/device/whatever-you-have-here and then the driver core will properly
manage the creation and removal of these files, in a race-free manner.
As it is, I think this is racy and will cause userspace confusion, but I
haven't looked for sure, as you should use the api that guarantees it is
safe...
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-27 10:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:07 [PATCH 00/18] MHI changes for v5.10 Manivannan Sadhasivam
2020-09-21 16:07 ` [PATCH] bus: mhi: core: Fix the building of MHI module Manivannan Sadhasivam
2020-09-21 16:13 ` Manivannan Sadhasivam
2020-09-21 16:07 ` [PATCH 01/18] bus: mhi: fix doubled words and struct image_info kernel-doc Manivannan Sadhasivam
2020-09-21 16:07 ` [PATCH 02/18] bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declaration Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 03/18] bus: mhi: core: Abort suspends due to outgoing pending packets Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 04/18] bus: mhi: core: Use helper API to trigger a non-blocking host resume Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 05/18] bus: mhi: core: Trigger host resume if suspended during mhi_device_get() Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 06/18] bus: mhi: core: Use generic name field for an MHI device Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 07/18] bus: mhi: core: Introduce helper function to check device state Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 08/18] bus: mhi: core: Introduce counters to track MHI device state transitions Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 09/18] bus: mhi: core: Read and save device hardware information from BHI Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 10/18] bus: mhi: core: Introduce APIs to allocate and free the MHI controller Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 11/18] bus: mhi: core: Add const qualifier to MHI config information Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 12/18] bus: mhi: Remove include of rwlock_types.h Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 13/18] bus: mhi: Fix entries based on Kconfig coding style Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 14/18] bus: mhi: core: Introduce debugfs entries for MHI Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 15/18] bus: mhi: core: Introduce sysfs " Manivannan Sadhasivam
2020-09-27 10:26 ` Greg KH [this message]
2020-09-28 3:44 ` Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 16/18] bus: mhi: core: Allow shared IRQ for event rings Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 17/18] bus: mhi: Remove unused nr_irqs_req variable Manivannan Sadhasivam
2020-09-21 16:08 ` [PATCH 18/18] bus: mhi: core: Fix the building of MHI module Manivannan Sadhasivam
2020-09-27 10:22 ` Greg KH
2020-09-28 3:45 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927102659.GC87283@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).