* [PATCH v3] soc: qcom: cmd-db: allow loading as a module
@ 2020-10-01 15:41 Lina Iyer
2020-10-01 15:57 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Lina Iyer @ 2020-10-01 15:41 UTC (permalink / raw)
To: bjorn.andersson, agross
Cc: gregkh, linux-arm-msm, mkshah, Lina Iyer, John Stultz
This patch enables Command DB driver to be loaded as a module. Command
DB is inherent to RPMH interaction and as such would never be unloaded.
Add supress_bind_attrs to make it a permanently loaded module.
Reviewed-by: John Stultz <john.stultz@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
---
Changes in v3:
- Update copyright, suggested by Greg K-H
Changes in v2:
- Add reviewed and tested tags provided in IRC chat
---
drivers/soc/qcom/Kconfig | 2 +-
drivers/soc/qcom/cmd-db.c | 8 +++++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 3dc3e3d61ea3..e2b8427af84c 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -17,7 +17,7 @@ config QCOM_AOSS_QMP
Subsystem (AOSS) using Qualcomm Messaging Protocol (QMP).
config QCOM_COMMAND_DB
- bool "Qualcomm Command DB"
+ tristate "Qualcomm Command DB"
depends on ARCH_QCOM || COMPILE_TEST
depends on OF_RESERVED_MEM
help
diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index fc5610603b17..dd872017f345 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -1,8 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/* Copyright (c) 2016-2018, The Linux Foundation. All rights reserved. */
+/* Copyright (c) 2016-2018, 2020, The Linux Foundation. All rights reserved. */
#include <linux/debugfs.h>
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_reserved_mem.h>
@@ -340,12 +341,14 @@ static const struct of_device_id cmd_db_match_table[] = {
{ .compatible = "qcom,cmd-db" },
{ }
};
+MODULE_DEVICE_TABLE(of, cmd_db_match_table);
static struct platform_driver cmd_db_dev_driver = {
.probe = cmd_db_dev_probe,
.driver = {
.name = "cmd-db",
.of_match_table = cmd_db_match_table,
+ .suppress_bind_attrs = true,
},
};
@@ -354,3 +357,6 @@ static int __init cmd_db_device_init(void)
return platform_driver_register(&cmd_db_dev_driver);
}
arch_initcall(cmd_db_device_init);
+
+MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Command DB Driver");
+MODULE_LICENSE("GPL v2");
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] soc: qcom: cmd-db: allow loading as a module
2020-10-01 15:41 [PATCH v3] soc: qcom: cmd-db: allow loading as a module Lina Iyer
@ 2020-10-01 15:57 ` Greg KH
2020-10-01 16:01 ` Lina Iyer
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-10-01 15:57 UTC (permalink / raw)
To: Lina Iyer; +Cc: bjorn.andersson, agross, linux-arm-msm, mkshah, John Stultz
On Thu, Oct 01, 2020 at 09:41:44AM -0600, Lina Iyer wrote:
> This patch enables Command DB driver to be loaded as a module. Command
> DB is inherent to RPMH interaction and as such would never be unloaded.
> Add supress_bind_attrs to make it a permanently loaded module.
>
> Reviewed-by: John Stultz <john.stultz@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
> Changes in v3:
> - Update copyright, suggested by Greg K-H
I did not say to update the copyright, I said if you were going to
update it, to do so properly :)
Anyway, tiny issue.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] soc: qcom: cmd-db: allow loading as a module
2020-10-01 15:57 ` Greg KH
@ 2020-10-01 16:01 ` Lina Iyer
0 siblings, 0 replies; 3+ messages in thread
From: Lina Iyer @ 2020-10-01 16:01 UTC (permalink / raw)
To: Greg KH; +Cc: bjorn.andersson, agross, linux-arm-msm, mkshah, John Stultz
On Thu, Oct 01 2020 at 09:57 -0600, Greg KH wrote:
>On Thu, Oct 01, 2020 at 09:41:44AM -0600, Lina Iyer wrote:
>> This patch enables Command DB driver to be loaded as a module. Command
>> DB is inherent to RPMH interaction and as such would never be unloaded.
>> Add supress_bind_attrs to make it a permanently loaded module.
>>
>> Reviewed-by: John Stultz <john.stultz@linaro.org>
>> Tested-by: John Stultz <john.stultz@linaro.org>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> ---
>> Changes in v3:
>> - Update copyright, suggested by Greg K-H
>
>I did not say to update the copyright, I said if you were going to
>update it, to do so properly :)
>
No, but you were right. I should not have included 2019.
Thanks for pointing that out.
--Lina
>Anyway, tiny issue.
>
>Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 15:41 [PATCH v3] soc: qcom: cmd-db: allow loading as a module Lina Iyer
2020-10-01 15:57 ` Greg KH
2020-10-01 16:01 ` Lina Iyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).