* [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU
@ 2020-11-23 11:18 Lee Jones
2020-11-23 11:18 ` [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues Lee Jones
` (12 more replies)
0 siblings, 13 replies; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, David Airlie,
Drew Davenport, dri-devel, freedreno, Fritz Koenig,
Hawking Zhang, Huang Rui, Jerome Glisse, Jiansong Chen,
Jonathan Marek, Kalyan Thota, Likun Gao, linaro-mm-sig,
linux-arm-msm, linux-media, Luben Tuikov, nouveau, Qinglang Miao,
Rob Clark, Sean Paul, Sonny Jiang, Sumit Semwal, Tao Zhou
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Only 900 (from 5000) to go!
Lee Jones (40):
drm/radeon/radeon_device: Consume our own header where the prototypes
are located
drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'
drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s
'job' param
drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot
misnaming issue
drm/amd/amdgpu/cik_ih: Supply description for 'ih' in
'cik_ih_{get,set}_wptr()'
drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours
drm/amd/amdgpu/dce_v8_0: Supply description for 'async'
drm/amd/amdgpu/cik_sdma: Supply some missing function param
descriptions
drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues
drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues
drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra
param description
drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header
drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of
'max_linewidth'
drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place
they are used
drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues
drm/amd/amdgpu/gfx_v6_0: Supply description for
'gfx_v6_0_ring_test_ib()'s 'timeout' param
drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting
issues
drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'
drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse
drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues
drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter
description issues
drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as
__maybe_unused
drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as
__maybe_unused
drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as
__maybe_unused
drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as
__maybe_unused
drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as
__maybe_unused
drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as
__maybe_unused
drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as
__maybe_unused
drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as
__maybe_unused
drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply
'global_state' description
drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param
descriptions
drm/amd/amdgpu/cik_sdma: Add one and remove another function param
description
drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param
description
drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function
param descriptions
drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions
drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste
drm/msm/msm_drv: Make '_msm_ioremap()' static
drm/amd/amdgpu/gmc_v9_0: Remove unused table
'ecc_umc_mcumc_status_addrs'
drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 +-
drivers/gpu/drm/amd/amdgpu/cik_ih.c | 2 +
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 18 ++-
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 +
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 +
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++--
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +-
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 +
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 38 +----
drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 +-
drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +-
drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 10 +-
drivers/gpu/drm/amd/include/arct_ip_offset.h | 4 +-
.../amd/include/dimgrey_cavefish_ip_offset.h | 2 +-
.../gpu/drm/amd/include/navi10_ip_offset.h | 2 +-
.../gpu/drm/amd/include/navi12_ip_offset.h | 2 +-
.../gpu/drm/amd/include/navi14_ip_offset.h | 2 +-
.../amd/include/sienna_cichlid_ip_offset.h | 2 +-
.../gpu/drm/amd/include/vangogh_ip_offset.h | 2 +-
.../gpu/drm/amd/include/vega20_ip_offset.h | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 75 +++++++++-
.../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 ------------
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++-
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +-
drivers/gpu/drm/msm/msm_drv.c | 4 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
drivers/gpu/drm/radeon/radeon_device.c | 1 +
37 files changed, 277 insertions(+), 268 deletions(-)
delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: Drew Davenport <ddavenport@chromium.org>
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Cc: Fritz Koenig <frkoenig@google.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: Jiansong Chen <Jiansong.Chen@amd.com>
Cc: Jonathan Marek <jonathan@marek.ca>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: nouveau@lists.freedesktop.org
Cc: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Sonny Jiang <sonny.jiang@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Tao Zhou <tao.zhou1@amd.com>
--
2.25.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:10 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description Lee Jones
` (11 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Kalyan Thota, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:31: warning: Enum value 'DPU_PERF_MODE_MAX' not described in enum 'dpu_perf_mode'
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:34: warning: Cannot understand * @_dpu_core_perf_calc_bw() - to calculate BW per crtc
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:73: warning: Function parameter or member 'kms' not described in '_dpu_core_perf_calc_clk'
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:73: warning: Function parameter or member 'crtc' not described in '_dpu_core_perf_calc_clk'
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:73: warning: Function parameter or member 'state' not described in '_dpu_core_perf_calc_clk'
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:249: warning: Cannot understand * @dpu_core_perf_crtc_release_bw() - request zero bandwidth
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
index 36927fc04a388..b6b3bbab03336 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
@@ -22,6 +22,7 @@
* @DPU_PERF_MODE_NORMAL: performance controlled by user mode client
* @DPU_PERF_MODE_MINIMUM: performance bounded by minimum setting
* @DPU_PERF_MODE_FIXED: performance bounded by fixed setting
+ * @DPU_PERF_MODE_MAX: maximum value, used for error checking
*/
enum dpu_perf_mode {
DPU_PERF_MODE_NORMAL,
@@ -31,9 +32,9 @@ enum dpu_perf_mode {
};
/**
- * @_dpu_core_perf_calc_bw() - to calculate BW per crtc
- * @kms - pointer to the dpu_kms
- * @crtc - pointer to a crtc
+ * _dpu_core_perf_calc_bw() - to calculate BW per crtc
+ * @kms: pointer to the dpu_kms
+ * @crtc: pointer to a crtc
* Return: returns aggregated BW for all planes in crtc.
*/
static u64 _dpu_core_perf_calc_bw(struct dpu_kms *kms,
@@ -63,9 +64,9 @@ static u64 _dpu_core_perf_calc_bw(struct dpu_kms *kms,
/**
* _dpu_core_perf_calc_clk() - to calculate clock per crtc
- * @kms - pointer to the dpu_kms
- * @crtc - pointer to a crtc
- * @state - pointer to a crtc state
+ * @kms: pointer to the dpu_kms
+ * @crtc: pointer to a crtc
+ * @state: pointer to a crtc state
* Return: returns max clk for all planes in crtc.
*/
static u64 _dpu_core_perf_calc_clk(struct dpu_kms *kms,
@@ -246,8 +247,8 @@ static int _dpu_core_perf_crtc_update_bus(struct dpu_kms *kms,
}
/**
- * @dpu_core_perf_crtc_release_bw() - request zero bandwidth
- * @crtc - pointer to a crtc
+ * dpu_core_perf_crtc_release_bw() - request zero bandwidth
+ * @crtc: pointer to a crtc
*
* Function checks a state variable for the crtc, if all pending commit
* requests are done, meaning no more bandwidth is needed, release
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
2020-11-23 11:18 ` [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:06 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header Lee Jones
` (10 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:28: warning: Function parameter or member 'hw_blk' not described in 'dpu_hw_blk_init'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:120: warning: Excess function parameter 'free_blk' description in 'dpu_hw_blk_put'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
index ca26666d2af91..819b26e660b9c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
@@ -19,6 +19,7 @@ static LIST_HEAD(dpu_hw_blk_list);
/**
* dpu_hw_blk_init - initialize hw block object
+ * @hw_blk: pointer to hw block object
* @type: hw block type - enum dpu_hw_blk_type
* @id: instance id of the hw block
* @ops: Pointer to block operations
@@ -114,7 +115,6 @@ struct dpu_hw_blk *dpu_hw_blk_get(struct dpu_hw_blk *hw_blk, u32 type, int id)
/**
* dpu_hw_blk_put - put hw_blk to free pool if decremented refcount is zero
* @hw_blk: hw block to be freed
- * @free_blk: function to be called when reference count goes to zero
*/
void dpu_hw_blk_put(struct dpu_hw_blk *hw_blk)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
2020-11-23 11:18 ` [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues Lee Jones
2020-11-23 11:18 ` [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:08 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 13/40] drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth' Lee Jones
` (9 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Fritz Koenig, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'fmt' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'a' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'r' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'g' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'b' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'e0' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'e1' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'e2' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'e3' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'uc' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'alpha' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'bp' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'flg' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'fm' not described in 'INTERLEAVED_RGB_FMT'
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function parameter or member 'np' not described in 'INTERLEAVED_RGB_FMT'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Fritz Koenig <frkoenig@google.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
index a05282dede91b..21ff8f9e5dfd1 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
@@ -22,7 +22,7 @@
#define DPU_MAX_IMG_WIDTH 0x3FFF
#define DPU_MAX_IMG_HEIGHT 0x3FFF
-/**
+/*
* DPU supported format packing, bpp, and other format
* information.
* DPU currently only supports interleaved RGB formats
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 13/40] drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth'
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (2 preceding siblings ...)
2020-11-23 11:18 ` [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:07 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used Lee Jones
` (8 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:124:19: warning: initialized field overwritten [-Woverride-init]
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:124:19: note: (near initialization for ‘sm8250_dpu_caps.max_linewidth’)
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 6a6a7172e3beb..a7004f18523b0 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -113,7 +113,6 @@ static const struct dpu_caps sm8150_dpu_caps = {
static const struct dpu_caps sm8250_dpu_caps = {
.max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
.max_mixer_blendstages = 0xb,
- .max_linewidth = 4096,
.qseed_type = DPU_SSPP_SCALER_QSEED3, /* TODO: qseed3 lite */
.smart_dma_rev = DPU_SSPP_SMART_DMA_V2, /* TODO: v2.5 */
.ubwc_version = DPU_HW_UBWC_VER_40,
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (3 preceding siblings ...)
2020-11-23 11:18 ` [PATCH 13/40] drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth' Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:23 ` abhinavk
2020-11-23 11:18 ` [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues Lee Jones
` (7 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
These tables are not large or overbearing, so moving them into the
source file seems like the right thing to do. The alternative is to
use __maybe_unused, which is undesirable.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:11:
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h:7:23: warning: ‘qcom_compressed_supported_formats’ defined but not used [-Wunused-const-variable=]
7 | static const uint32_t qcom_compressed_supported_formats[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h:48:23: warning: ‘plane_formats_yuv’ defined but not used [-Wunused-const-variable=]
48 | static const uint32_t plane_formats_yuv[] = {
| ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h:17:23: warning: ‘plane_formats’ defined but not used [-Wunused-const-variable=]
17 | static const uint32_t plane_formats[] = {
| ^~~~~~~~~~~~~
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 74 +++++++++++++++-
.../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 -------------------
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 11 ++-
3 files changed, 83 insertions(+), 90 deletions(-)
delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index a7004f18523b0..9ed6d0c6cd9b2 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -8,7 +8,6 @@
#include <linux/platform_device.h>
#include "dpu_hw_mdss.h"
#include "dpu_hw_catalog.h"
-#include "dpu_hw_catalog_format.h"
#include "dpu_kms.h"
#define VIG_MASK \
@@ -62,6 +61,79 @@
#define STRCAT(X, Y) (X Y)
+static const uint32_t plane_formats[] = {
+ DRM_FORMAT_ARGB8888,
+ DRM_FORMAT_ABGR8888,
+ DRM_FORMAT_RGBA8888,
+ DRM_FORMAT_BGRA8888,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_RGBX8888,
+ DRM_FORMAT_BGRX8888,
+ DRM_FORMAT_XBGR8888,
+ DRM_FORMAT_RGB888,
+ DRM_FORMAT_BGR888,
+ DRM_FORMAT_RGB565,
+ DRM_FORMAT_BGR565,
+ DRM_FORMAT_ARGB1555,
+ DRM_FORMAT_ABGR1555,
+ DRM_FORMAT_RGBA5551,
+ DRM_FORMAT_BGRA5551,
+ DRM_FORMAT_XRGB1555,
+ DRM_FORMAT_XBGR1555,
+ DRM_FORMAT_RGBX5551,
+ DRM_FORMAT_BGRX5551,
+ DRM_FORMAT_ARGB4444,
+ DRM_FORMAT_ABGR4444,
+ DRM_FORMAT_RGBA4444,
+ DRM_FORMAT_BGRA4444,
+ DRM_FORMAT_XRGB4444,
+ DRM_FORMAT_XBGR4444,
+ DRM_FORMAT_RGBX4444,
+ DRM_FORMAT_BGRX4444,
+};
+
+static const uint32_t plane_formats_yuv[] = {
+ DRM_FORMAT_ARGB8888,
+ DRM_FORMAT_ABGR8888,
+ DRM_FORMAT_RGBA8888,
+ DRM_FORMAT_BGRX8888,
+ DRM_FORMAT_BGRA8888,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_XBGR8888,
+ DRM_FORMAT_RGBX8888,
+ DRM_FORMAT_RGB888,
+ DRM_FORMAT_BGR888,
+ DRM_FORMAT_RGB565,
+ DRM_FORMAT_BGR565,
+ DRM_FORMAT_ARGB1555,
+ DRM_FORMAT_ABGR1555,
+ DRM_FORMAT_RGBA5551,
+ DRM_FORMAT_BGRA5551,
+ DRM_FORMAT_XRGB1555,
+ DRM_FORMAT_XBGR1555,
+ DRM_FORMAT_RGBX5551,
+ DRM_FORMAT_BGRX5551,
+ DRM_FORMAT_ARGB4444,
+ DRM_FORMAT_ABGR4444,
+ DRM_FORMAT_RGBA4444,
+ DRM_FORMAT_BGRA4444,
+ DRM_FORMAT_XRGB4444,
+ DRM_FORMAT_XBGR4444,
+ DRM_FORMAT_RGBX4444,
+ DRM_FORMAT_BGRX4444,
+
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_NV21,
+ DRM_FORMAT_NV16,
+ DRM_FORMAT_NV61,
+ DRM_FORMAT_VYUY,
+ DRM_FORMAT_UYVY,
+ DRM_FORMAT_YUYV,
+ DRM_FORMAT_YVYU,
+ DRM_FORMAT_YUV420,
+ DRM_FORMAT_YVU420,
+};
+
/*************************************************************
* DPU sub blocks config
*************************************************************/
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
deleted file mode 100644
index 3766f0fd0bf08..0000000000000
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
+++ /dev/null
@@ -1,88 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.
- */
-
-#include "dpu_hw_mdss.h"
-
-static const uint32_t qcom_compressed_supported_formats[] = {
- DRM_FORMAT_ABGR8888,
- DRM_FORMAT_ARGB8888,
- DRM_FORMAT_XBGR8888,
- DRM_FORMAT_XRGB8888,
- DRM_FORMAT_BGR565,
-
- DRM_FORMAT_NV12,
-};
-
-static const uint32_t plane_formats[] = {
- DRM_FORMAT_ARGB8888,
- DRM_FORMAT_ABGR8888,
- DRM_FORMAT_RGBA8888,
- DRM_FORMAT_BGRA8888,
- DRM_FORMAT_XRGB8888,
- DRM_FORMAT_RGBX8888,
- DRM_FORMAT_BGRX8888,
- DRM_FORMAT_XBGR8888,
- DRM_FORMAT_RGB888,
- DRM_FORMAT_BGR888,
- DRM_FORMAT_RGB565,
- DRM_FORMAT_BGR565,
- DRM_FORMAT_ARGB1555,
- DRM_FORMAT_ABGR1555,
- DRM_FORMAT_RGBA5551,
- DRM_FORMAT_BGRA5551,
- DRM_FORMAT_XRGB1555,
- DRM_FORMAT_XBGR1555,
- DRM_FORMAT_RGBX5551,
- DRM_FORMAT_BGRX5551,
- DRM_FORMAT_ARGB4444,
- DRM_FORMAT_ABGR4444,
- DRM_FORMAT_RGBA4444,
- DRM_FORMAT_BGRA4444,
- DRM_FORMAT_XRGB4444,
- DRM_FORMAT_XBGR4444,
- DRM_FORMAT_RGBX4444,
- DRM_FORMAT_BGRX4444,
-};
-
-static const uint32_t plane_formats_yuv[] = {
- DRM_FORMAT_ARGB8888,
- DRM_FORMAT_ABGR8888,
- DRM_FORMAT_RGBA8888,
- DRM_FORMAT_BGRX8888,
- DRM_FORMAT_BGRA8888,
- DRM_FORMAT_XRGB8888,
- DRM_FORMAT_XBGR8888,
- DRM_FORMAT_RGBX8888,
- DRM_FORMAT_RGB888,
- DRM_FORMAT_BGR888,
- DRM_FORMAT_RGB565,
- DRM_FORMAT_BGR565,
- DRM_FORMAT_ARGB1555,
- DRM_FORMAT_ABGR1555,
- DRM_FORMAT_RGBA5551,
- DRM_FORMAT_BGRA5551,
- DRM_FORMAT_XRGB1555,
- DRM_FORMAT_XBGR1555,
- DRM_FORMAT_RGBX5551,
- DRM_FORMAT_BGRX5551,
- DRM_FORMAT_ARGB4444,
- DRM_FORMAT_ABGR4444,
- DRM_FORMAT_RGBA4444,
- DRM_FORMAT_BGRA4444,
- DRM_FORMAT_XRGB4444,
- DRM_FORMAT_XBGR4444,
- DRM_FORMAT_RGBX4444,
- DRM_FORMAT_BGRX4444,
-
- DRM_FORMAT_NV12,
- DRM_FORMAT_NV21,
- DRM_FORMAT_NV16,
- DRM_FORMAT_NV61,
- DRM_FORMAT_VYUY,
- DRM_FORMAT_UYVY,
- DRM_FORMAT_YUYV,
- DRM_FORMAT_YVYU,
- DRM_FORMAT_YUV420,
- DRM_FORMAT_YVU420,
-};
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 7ea90d25a3b69..c0b1d77369e53 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -19,7 +19,6 @@
#include "dpu_kms.h"
#include "dpu_formats.h"
#include "dpu_hw_sspp.h"
-#include "dpu_hw_catalog_format.h"
#include "dpu_trace.h"
#include "dpu_crtc.h"
#include "dpu_vbif.h"
@@ -63,6 +62,16 @@ enum {
#define DEFAULT_REFRESH_RATE 60
+static const uint32_t qcom_compressed_supported_formats[] = {
+ DRM_FORMAT_ABGR8888,
+ DRM_FORMAT_ARGB8888,
+ DRM_FORMAT_XBGR8888,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_BGR565,
+
+ DRM_FORMAT_NV12,
+};
+
/**
* enum dpu_plane_qos - Different qos configurations for each pipe
*
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (4 preceding siblings ...)
2020-11-23 11:18 ` [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:10 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' Lee Jones
` (6 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function parameter or member 'cur_slave' not described in 'dpu_encoder_virt'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function parameter or member 'hw_pp' not described in 'dpu_encoder_virt'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function parameter or member 'intfs_swapped' not described in 'dpu_encoder_virt'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1445: warning: Function parameter or member 'drm_enc' not described in '_dpu_encoder_trigger_flush'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1445: warning: Function parameter or member 'phys' not described in '_dpu_encoder_trigger_flush'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1445: warning: Function parameter or member 'extra_flush_bits' not described in '_dpu_encoder_trigger_flush'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1481: warning: Function parameter or member 'phys' not described in '_dpu_encoder_trigger_start'
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1564: warning: Function parameter or member 'dpu_enc' not described in '_dpu_encoder_kickoff_phys'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 289bfb6f1861c..288e95ee8e1d5 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -132,9 +132,10 @@ enum dpu_enc_rc_states {
* @phys_encs: Container of physical encoders managed.
* @cur_master: Pointer to the current master in this mode. Optimization
* Only valid after enable. Cleared as disable.
- * @hw_pp Handle to the pingpong blocks used for the display. No.
+ * @cur_slave: As above but for the slave encoder.
+ * @hw_pp: Handle to the pingpong blocks used for the display. No.
* pingpong blocks can be different than num_phys_encs.
- * @intfs_swapped Whether or not the phys_enc interfaces have been swapped
+ * @intfs_swapped: Whether or not the phys_enc interfaces have been swapped
* for partial update right-only cases, such as pingpong
* split where virtual pingpong does not generate IRQs
* @crtc: Pointer to the currently assigned crtc. Normally you
@@ -1436,9 +1437,9 @@ static void dpu_encoder_off_work(struct work_struct *work)
/**
* _dpu_encoder_trigger_flush - trigger flush for a physical encoder
- * drm_enc: Pointer to drm encoder structure
- * phys: Pointer to physical encoder structure
- * extra_flush_bits: Additional bit mask to include in flush trigger
+ * @drm_enc: Pointer to drm encoder structure
+ * @phys: Pointer to physical encoder structure
+ * @extra_flush_bits: Additional bit mask to include in flush trigger
*/
static void _dpu_encoder_trigger_flush(struct drm_encoder *drm_enc,
struct dpu_encoder_phys *phys, uint32_t extra_flush_bits)
@@ -1475,7 +1476,7 @@ static void _dpu_encoder_trigger_flush(struct drm_encoder *drm_enc,
/**
* _dpu_encoder_trigger_start - trigger start for a physical encoder
- * phys: Pointer to physical encoder structure
+ * @phys: Pointer to physical encoder structure
*/
static void _dpu_encoder_trigger_start(struct dpu_encoder_phys *phys)
{
@@ -1558,7 +1559,7 @@ static void dpu_encoder_helper_hw_reset(struct dpu_encoder_phys *phys_enc)
* encoder rather than the individual physical ones in order to handle
* use cases that require visibility into multiple physical encoders at
* a time.
- * dpu_enc: Pointer to virtual encoder structure
+ * @dpu_enc: Pointer to virtual encoder structure
*/
static void _dpu_encoder_kickoff_phys(struct dpu_encoder_virt *dpu_enc)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (5 preceding siblings ...)
2020-11-23 11:18 ` [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:12 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse Lee Jones
` (5 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c:55: warning: Function parameter or member 'ctx' not described in '_stage_offset'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c:55: warning: Excess function parameter 'c' description in '_stage_offset'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
index 4b8baf71423f2..6ac0b5a0e0573 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
@@ -48,7 +48,7 @@ static const struct dpu_lm_cfg *_lm_offset(enum dpu_lm mixer,
/**
* _stage_offset(): returns the relative offset of the blend registers
* for the stage to be setup
- * @c: mixer ctx contains the mixer to be programmed
+ * @ctx: mixer ctx contains the mixer to be programmed
* @stage: stage index to setup
*/
static inline int _stage_offset(struct dpu_hw_mixer *ctx, enum dpu_stage stage)
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (6 preceding siblings ...)
2020-11-23 11:18 ` [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' Lee Jones
@ 2020-11-23 11:18 ` Lee Jones
2020-11-23 21:12 ` [Freedreno] " abhinavk
2020-11-23 11:19 ` [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description Lee Jones
` (4 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Jonathan Marek, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function parameter or member 'ctx' not described in 'dpu_hw_sspp_setup_format'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function parameter or member 'fmt' not described in 'dpu_hw_sspp_setup_format'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function parameter or member 'flags' not described in 'dpu_hw_sspp_setup_format'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function parameter or member 'rect_mode' not described in 'dpu_hw_sspp_setup_format'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:446: warning: Function parameter or member 'ctx' not described in 'dpu_hw_sspp_setup_rects'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:446: warning: Function parameter or member 'cfg' not described in 'dpu_hw_sspp_setup_rects'
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:446: warning: Function parameter or member 'rect_index' not described in 'dpu_hw_sspp_setup_rects'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jonathan Marek <jonathan@marek.ca>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
index c940b69435e16..2c2ca5335aa8c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
@@ -231,7 +231,7 @@ static void _sspp_setup_csc10_opmode(struct dpu_hw_pipe *ctx,
DPU_REG_WRITE(&ctx->hw, SSPP_VIG_CSC_10_OP_MODE + idx, opmode);
}
-/**
+/*
* Setup source pixel format, flip,
*/
static void dpu_hw_sspp_setup_format(struct dpu_hw_pipe *ctx,
@@ -437,7 +437,7 @@ static u32 _dpu_hw_sspp_get_scaler3_ver(struct dpu_hw_pipe *ctx)
return dpu_hw_get_scaler3_ver(&ctx->hw, idx);
}
-/**
+/*
* dpu_hw_sspp_setup_rects()
*/
static void dpu_hw_sspp_setup_rects(struct dpu_hw_pipe *ctx,
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (7 preceding siblings ...)
2020-11-23 11:18 ` [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse Lee Jones
@ 2020-11-23 11:19 ` Lee Jones
2020-11-23 21:13 ` [Freedreno] " abhinavk
2020-11-23 11:19 ` [PATCH 32/40] drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param descriptions Lee Jones
` (3 subsequent siblings)
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Drew Davenport, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:247: warning: Excess function parameter 'Return' description in '_dpu_rm_check_lm_peer'
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Function parameter or member 'global_state' not described in '_dpu_rm_check_lm_and_get_connected_blks'
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Excess function parameter 'Return' description in '_dpu_rm_check_lm_and_get_connected_blks'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Drew Davenport <ddavenport@chromium.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
index 0ae8a36ffcff3..fd2d104f0a91d 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
@@ -239,7 +239,7 @@ static bool _dpu_rm_needs_split_display(const struct msm_display_topology *top)
* @rm: dpu resource manager handle
* @primary_idx: index of primary mixer in rm->mixer_blks[]
* @peer_idx: index of other mixer in rm->mixer_blks[]
- * @Return: true if rm->mixer_blks[peer_idx] is a peer of
+ * Return: true if rm->mixer_blks[peer_idx] is a peer of
* rm->mixer_blks[primary_idx]
*/
static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx,
@@ -264,6 +264,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx,
* proposed use case requirements, incl. hardwired dependent blocks like
* pingpong
* @rm: dpu resource manager handle
+ * @global_state: resources shared across multiple kms objects
* @enc_id: encoder id requesting for allocation
* @lm_idx: index of proposed layer mixer in rm->mixer_blks[], function checks
* if lm, and all other hardwired blocks connected to the lm (pp) is
@@ -274,7 +275,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx,
* mixer in rm->dspp_blks[].
* @reqs: input parameter, rm requirements for HW blocks needed in the
* datapath.
- * @Return: true if lm matches all requirements, false otherwise
+ * Return: true if lm matches all requirements, false otherwise
*/
static bool _dpu_rm_check_lm_and_get_connected_blks(struct dpu_rm *rm,
struct dpu_global_state *global_state,
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 32/40] drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param descriptions
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (8 preceding siblings ...)
2020-11-23 11:19 ` [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description Lee Jones
@ 2020-11-23 11:19 ` Lee Jones
2020-11-23 11:19 ` [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing " Lee Jones
` (2 subsequent siblings)
12 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c:150: warning: Function parameter or member 'dpu_kms' not described in 'dpu_vbif_set_ot_limit'
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c:150: warning: Excess function parameter 'vbif' description in 'dpu_vbif_set_ot_limit'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
index 5e8c3f3e66256..7e08f40e7e6fe 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c
@@ -140,7 +140,7 @@ static u32 _dpu_vbif_get_ot_limit(struct dpu_hw_vbif *vbif,
/**
* dpu_vbif_set_ot_limit - set OT based on usecase & configuration parameters
- * @vbif: Pointer to hardware vbif driver
+ * @dpu_kms: DPU handler
* @params: Pointer to usecase parameters
*
* Note this function would block waiting for bus halt.
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function param descriptions
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (9 preceding siblings ...)
2020-11-23 11:19 ` [PATCH 32/40] drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param descriptions Lee Jones
@ 2020-11-23 11:19 ` Lee Jones
2020-11-23 21:13 ` [Freedreno] " abhinavk
2020-11-23 11:19 ` [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static Lee Jones
2020-11-23 11:52 ` [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Christian König
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Kalyan Thota, linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function parameter or member 'plane' not described in '_dpu_plane_calc_bw'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function parameter or member 'fb' not described in '_dpu_plane_calc_bw'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Excess function parameter 'Plane' description in '_dpu_plane_calc_bw'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:200: warning: Function parameter or member 'plane' not described in '_dpu_plane_calc_clk'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:200: warning: Excess function parameter 'Plane' description in '_dpu_plane_calc_clk'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:232: warning: Function parameter or member 'src_width' not described in '_dpu_plane_calc_fill_level'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:232: warning: Excess function parameter 'src_wdith' description in '_dpu_plane_calc_fill_level'
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:1060: warning: Function parameter or member 'error' not described in 'dpu_plane_set_error'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index c0b1d77369e53..cf0084d7cc7c9 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -142,7 +142,8 @@ static struct dpu_kms *_dpu_plane_get_kms(struct drm_plane *plane)
/**
* _dpu_plane_calc_bw - calculate bandwidth required for a plane
- * @Plane: Pointer to drm plane.
+ * @plane: Pointer to drm plane.
+ * @fb: Pointer to framebuffer associated with the given plane
* Result: Updates calculated bandwidth in the plane state.
* BW Equation: src_w * src_h * bpp * fps * (v_total / v_dest)
* Prefill BW Equation: line src bytes * line_time
@@ -192,7 +193,7 @@ static void _dpu_plane_calc_bw(struct drm_plane *plane,
/**
* _dpu_plane_calc_clk - calculate clock required for a plane
- * @Plane: Pointer to drm plane.
+ * @plane: Pointer to drm plane.
* Result: Updates calculated clock in the plane state.
* Clock equation: dst_w * v_total * fps * (src_h / dst_h)
*/
@@ -224,7 +225,7 @@ static void _dpu_plane_calc_clk(struct drm_plane *plane)
* _dpu_plane_calc_fill_level - calculate fill level of the given source format
* @plane: Pointer to drm plane
* @fmt: Pointer to source buffer format
- * @src_wdith: width of source buffer
+ * @src_width: width of source buffer
* Return: fill level corresponding to the source buffer/format or 0 if error
*/
static int _dpu_plane_calc_fill_level(struct drm_plane *plane,
@@ -1055,6 +1056,7 @@ void dpu_plane_flush(struct drm_plane *plane)
/**
* dpu_plane_set_error: enable/disable error condition
* @plane: pointer to drm_plane structure
+ * @error: error value to set
*/
void dpu_plane_set_error(struct drm_plane *plane, bool error)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (10 preceding siblings ...)
2020-11-23 11:19 ` [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing " Lee Jones
@ 2020-11-23 11:19 ` Lee Jones
2020-11-23 21:14 ` [Freedreno] " abhinavk
2020-11-23 11:52 ` [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Christian König
12 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2020-11-23 11:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/msm_drv.c:124:15: warning: no previous prototype for ‘_msm_ioremap’ [-Wmissing-prototypes]
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/msm_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 4d58668b80853..edc99e3b0eca7 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -121,8 +121,8 @@ struct clk *msm_clk_get(struct platform_device *pdev, const char *name)
return clk;
}
-void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
- const char *dbgname, bool quiet)
+static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
+ const char *dbgname, bool quiet)
{
struct resource *res;
unsigned long size;
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
` (11 preceding siblings ...)
2020-11-23 11:19 ` [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static Lee Jones
@ 2020-11-23 11:52 ` Christian König
2020-11-23 12:30 ` Lee Jones
12 siblings, 1 reply; 26+ messages in thread
From: Christian König @ 2020-11-23 11:52 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs, Daniel Vetter,
David Airlie, Drew Davenport, dri-devel, freedreno, Fritz Koenig,
Hawking Zhang, Huang Rui, Jerome Glisse, Jiansong Chen,
Jonathan Marek, Kalyan Thota, Likun Gao, linaro-mm-sig,
linux-arm-msm, linux-media, Luben Tuikov, nouveau, Qinglang Miao,
Rob Clark, Sean Paul, Sonny Jiang, Sumit Semwal, Tao Zhou
Only skimmed over them, but over all looks sane to me.
Series is Acked-by: Christian König <christian.koenig@amd.com>
Thanks,
Christian.
Am 23.11.20 um 12:18 schrieb Lee Jones:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Only 900 (from 5000) to go!
>
> Lee Jones (40):
> drm/radeon/radeon_device: Consume our own header where the prototypes
> are located
> drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'
> drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s
> 'job' param
> drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot
> misnaming issue
> drm/amd/amdgpu/cik_ih: Supply description for 'ih' in
> 'cik_ih_{get,set}_wptr()'
> drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours
> drm/amd/amdgpu/dce_v8_0: Supply description for 'async'
> drm/amd/amdgpu/cik_sdma: Supply some missing function param
> descriptions
> drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues
> drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues
> drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra
> param description
> drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header
> drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of
> 'max_linewidth'
> drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place
> they are used
> drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
> drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues
> drm/amd/amdgpu/gfx_v6_0: Supply description for
> 'gfx_v6_0_ring_test_ib()'s 'timeout' param
> drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting
> issues
> drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'
> drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse
> drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues
> drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter
> description issues
> drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as
> __maybe_unused
> drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as
> __maybe_unused
> drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as
> __maybe_unused
> drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as
> __maybe_unused
> drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as
> __maybe_unused
> drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as
> __maybe_unused
> drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as
> __maybe_unused
> drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as
> __maybe_unused
> drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply
> 'global_state' description
> drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param
> descriptions
> drm/amd/amdgpu/cik_sdma: Add one and remove another function param
> description
> drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param
> description
> drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function
> param descriptions
> drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions
> drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste
> drm/msm/msm_drv: Make '_msm_ioremap()' static
> drm/amd/amdgpu/gmc_v9_0: Remove unused table
> 'ecc_umc_mcumc_status_addrs'
> drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 +-
> drivers/gpu/drm/amd/amdgpu/cik_ih.c | 2 +
> drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 18 ++-
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 +
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 +
> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++--
> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +-
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 +
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 38 +----
> drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 +-
> drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +-
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 10 +-
> drivers/gpu/drm/amd/include/arct_ip_offset.h | 4 +-
> .../amd/include/dimgrey_cavefish_ip_offset.h | 2 +-
> .../gpu/drm/amd/include/navi10_ip_offset.h | 2 +-
> .../gpu/drm/amd/include/navi12_ip_offset.h | 2 +-
> .../gpu/drm/amd/include/navi14_ip_offset.h | 2 +-
> .../amd/include/sienna_cichlid_ip_offset.h | 2 +-
> .../gpu/drm/amd/include/vangogh_ip_offset.h | 2 +-
> .../gpu/drm/amd/include/vega20_ip_offset.h | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +--
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-
> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 75 +++++++++-
> .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 ------------
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++-
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +-
> drivers/gpu/drm/msm/msm_drv.c | 4 +-
> .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
> drivers/gpu/drm/radeon/radeon_device.c | 1 +
> 37 files changed, 277 insertions(+), 268 deletions(-)
> delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Drew Davenport <ddavenport@chromium.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Cc: Fritz Koenig <frkoenig@google.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jiansong Chen <Jiansong.Chen@amd.com>
> Cc: Jonathan Marek <jonathan@marek.ca>
> Cc: Kalyan Thota <kalyan_t@codeaurora.org>
> Cc: Likun Gao <Likun.Gao@amd.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: Qinglang Miao <miaoqinglang@huawei.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Sonny Jiang <sonny.jiang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Tao Zhou <tao.zhou1@amd.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU
2020-11-23 11:52 ` [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Christian König
@ 2020-11-23 12:30 ` Lee Jones
0 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2020-11-23 12:30 UTC (permalink / raw)
To: Christian König
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs, Daniel Vetter,
David Airlie, Drew Davenport, dri-devel, freedreno, Fritz Koenig,
Hawking Zhang, Huang Rui, Jerome Glisse, Jiansong Chen,
Jonathan Marek, Kalyan Thota, Likun Gao, linaro-mm-sig,
linux-arm-msm, linux-media, Luben Tuikov, nouveau, Qinglang Miao,
Rob Clark, Sean Paul, Sonny Jiang, Sumit Semwal, Tao Zhou
On Mon, 23 Nov 2020, Christian König wrote:
> Only skimmed over them, but over all looks sane to me.
>
> Series is Acked-by: Christian König <christian.koenig@amd.com>
Thanks Christian, much appreciated.
> Am 23.11.20 um 12:18 schrieb Lee Jones:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Only 900 (from 5000) to go!
> >
> > Lee Jones (40):
> > drm/radeon/radeon_device: Consume our own header where the prototypes
> > are located
> > drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'
> > drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s
> > 'job' param
> > drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot
> > misnaming issue
> > drm/amd/amdgpu/cik_ih: Supply description for 'ih' in
[...]
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description
2020-11-23 11:18 ` [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description Lee Jones
@ 2020-11-23 21:06 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:06 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:28: warning: Function
> parameter or member 'hw_blk' not described in 'dpu_hw_blk_init'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:120: warning: Excess
> function parameter 'free_blk' description in 'dpu_hw_blk_put'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> index ca26666d2af91..819b26e660b9c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> @@ -19,6 +19,7 @@ static LIST_HEAD(dpu_hw_blk_list);
>
> /**
> * dpu_hw_blk_init - initialize hw block object
> + * @hw_blk: pointer to hw block object
> * @type: hw block type - enum dpu_hw_blk_type
> * @id: instance id of the hw block
> * @ops: Pointer to block operations
> @@ -114,7 +115,6 @@ struct dpu_hw_blk *dpu_hw_blk_get(struct
> dpu_hw_blk *hw_blk, u32 type, int id)
> /**
> * dpu_hw_blk_put - put hw_blk to free pool if decremented refcount is
> zero
> * @hw_blk: hw block to be freed
> - * @free_blk: function to be called when reference count goes to zero
> */
> void dpu_hw_blk_put(struct dpu_hw_blk *hw_blk)
> {
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 13/40] drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth'
2020-11-23 11:18 ` [PATCH 13/40] drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth' Lee Jones
@ 2020-11-23 21:07 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:07 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:124:19: warning:
> initialized field overwritten [-Woverride-init]
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:124:19: note: (near
> initialization for ‘sm8250_dpu_caps.max_linewidth’)
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 6a6a7172e3beb..a7004f18523b0 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -113,7 +113,6 @@ static const struct dpu_caps sm8150_dpu_caps = {
> static const struct dpu_caps sm8250_dpu_caps = {
> .max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> .max_mixer_blendstages = 0xb,
> - .max_linewidth = 4096,
> .qseed_type = DPU_SSPP_SCALER_QSEED3, /* TODO: qseed3 lite */
> .smart_dma_rev = DPU_SSPP_SMART_DMA_V2, /* TODO: v2.5 */
> .ubwc_version = DPU_HW_UBWC_VER_40,
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header
2020-11-23 11:18 ` [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header Lee Jones
@ 2020-11-23 21:08 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:08 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, Fritz Koenig, David Airlie, linux-arm-msm,
linux-kernel, dri-devel, Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'fmt' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'a' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'r' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'g' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'b' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'e0' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'e1' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'e2' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'e3' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'uc' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'alpha' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'bp' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'flg' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'fm' not described in 'INTERLEAVED_RGB_FMT'
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:50: warning: Function
> parameter or member 'np' not described in 'INTERLEAVED_RGB_FMT'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Fritz Koenig <frkoenig@google.com>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> index a05282dede91b..21ff8f9e5dfd1 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> @@ -22,7 +22,7 @@
> #define DPU_MAX_IMG_WIDTH 0x3FFF
> #define DPU_MAX_IMG_HEIGHT 0x3FFF
>
> -/**
> +/*
> * DPU supported format packing, bpp, and other format
> * information.
> * DPU currently only supports interleaved RGB formats
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues
2020-11-23 11:18 ` [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues Lee Jones
@ 2020-11-23 21:10 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:10 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function
> parameter or member 'cur_slave' not described in 'dpu_encoder_virt'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function
> parameter or member 'hw_pp' not described in 'dpu_encoder_virt'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:207: warning: Function
> parameter or member 'intfs_swapped' not described in
> 'dpu_encoder_virt'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1445: warning: Function
> parameter or member 'drm_enc' not described in
> '_dpu_encoder_trigger_flush'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1445: warning: Function
> parameter or member 'phys' not described in
> '_dpu_encoder_trigger_flush'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1445: warning: Function
> parameter or member 'extra_flush_bits' not described in
> '_dpu_encoder_trigger_flush'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1481: warning: Function
> parameter or member 'phys' not described in
> '_dpu_encoder_trigger_start'
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1564: warning: Function
> parameter or member 'dpu_enc' not described in
> '_dpu_encoder_kickoff_phys'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 289bfb6f1861c..288e95ee8e1d5 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -132,9 +132,10 @@ enum dpu_enc_rc_states {
> * @phys_encs: Container of physical encoders managed.
> * @cur_master: Pointer to the current master in this mode.
> Optimization
> * Only valid after enable. Cleared as disable.
> - * @hw_pp Handle to the pingpong blocks used for the display. No.
> + * @cur_slave: As above but for the slave encoder.
> + * @hw_pp: Handle to the pingpong blocks used for the display. No.
> * pingpong blocks can be different than num_phys_encs.
> - * @intfs_swapped Whether or not the phys_enc interfaces have been
> swapped
> + * @intfs_swapped: Whether or not the phys_enc interfaces have been
> swapped
> * for partial update right-only cases, such as pingpong
> * split where virtual pingpong does not generate IRQs
> * @crtc: Pointer to the currently assigned crtc. Normally you
> @@ -1436,9 +1437,9 @@ static void dpu_encoder_off_work(struct
> work_struct *work)
>
> /**
> * _dpu_encoder_trigger_flush - trigger flush for a physical encoder
> - * drm_enc: Pointer to drm encoder structure
> - * phys: Pointer to physical encoder structure
> - * extra_flush_bits: Additional bit mask to include in flush trigger
> + * @drm_enc: Pointer to drm encoder structure
> + * @phys: Pointer to physical encoder structure
> + * @extra_flush_bits: Additional bit mask to include in flush trigger
> */
> static void _dpu_encoder_trigger_flush(struct drm_encoder *drm_enc,
> struct dpu_encoder_phys *phys, uint32_t extra_flush_bits)
> @@ -1475,7 +1476,7 @@ static void _dpu_encoder_trigger_flush(struct
> drm_encoder *drm_enc,
>
> /**
> * _dpu_encoder_trigger_start - trigger start for a physical encoder
> - * phys: Pointer to physical encoder structure
> + * @phys: Pointer to physical encoder structure
> */
> static void _dpu_encoder_trigger_start(struct dpu_encoder_phys *phys)
> {
> @@ -1558,7 +1559,7 @@ static void dpu_encoder_helper_hw_reset(struct
> dpu_encoder_phys *phys_enc)
> * encoder rather than the individual physical ones in order to handle
> * use cases that require visibility into multiple physical encoders
> at
> * a time.
> - * dpu_enc: Pointer to virtual encoder structure
> + * @dpu_enc: Pointer to virtual encoder structure
> */
> static void _dpu_encoder_kickoff_phys(struct dpu_encoder_virt
> *dpu_enc)
> {
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues
2020-11-23 11:18 ` [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues Lee Jones
@ 2020-11-23 21:10 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:10 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Kalyan Thota, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:31: warning: Enum value
> 'DPU_PERF_MODE_MAX' not described in enum 'dpu_perf_mode'
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:34: warning: Cannot
> understand * @_dpu_core_perf_calc_bw() - to calculate BW per crtc
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:73: warning: Function
> parameter or member 'kms' not described in '_dpu_core_perf_calc_clk'
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:73: warning: Function
> parameter or member 'crtc' not described in '_dpu_core_perf_calc_clk'
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:73: warning: Function
> parameter or member 'state' not described in '_dpu_core_perf_calc_clk'
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:249: warning: Cannot
> understand * @dpu_core_perf_crtc_release_bw() - request zero
> bandwidth
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Kalyan Thota <kalyan_t@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> index 36927fc04a388..b6b3bbab03336 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> @@ -22,6 +22,7 @@
> * @DPU_PERF_MODE_NORMAL: performance controlled by user mode client
> * @DPU_PERF_MODE_MINIMUM: performance bounded by minimum setting
> * @DPU_PERF_MODE_FIXED: performance bounded by fixed setting
> + * @DPU_PERF_MODE_MAX: maximum value, used for error checking
> */
> enum dpu_perf_mode {
> DPU_PERF_MODE_NORMAL,
> @@ -31,9 +32,9 @@ enum dpu_perf_mode {
> };
>
> /**
> - * @_dpu_core_perf_calc_bw() - to calculate BW per crtc
> - * @kms - pointer to the dpu_kms
> - * @crtc - pointer to a crtc
> + * _dpu_core_perf_calc_bw() - to calculate BW per crtc
> + * @kms: pointer to the dpu_kms
> + * @crtc: pointer to a crtc
> * Return: returns aggregated BW for all planes in crtc.
> */
> static u64 _dpu_core_perf_calc_bw(struct dpu_kms *kms,
> @@ -63,9 +64,9 @@ static u64 _dpu_core_perf_calc_bw(struct dpu_kms
> *kms,
>
> /**
> * _dpu_core_perf_calc_clk() - to calculate clock per crtc
> - * @kms - pointer to the dpu_kms
> - * @crtc - pointer to a crtc
> - * @state - pointer to a crtc state
> + * @kms: pointer to the dpu_kms
> + * @crtc: pointer to a crtc
> + * @state: pointer to a crtc state
> * Return: returns max clk for all planes in crtc.
> */
> static u64 _dpu_core_perf_calc_clk(struct dpu_kms *kms,
> @@ -246,8 +247,8 @@ static int _dpu_core_perf_crtc_update_bus(struct
> dpu_kms *kms,
> }
>
> /**
> - * @dpu_core_perf_crtc_release_bw() - request zero bandwidth
> - * @crtc - pointer to a crtc
> + * dpu_core_perf_crtc_release_bw() - request zero bandwidth
> + * @crtc: pointer to a crtc
> *
> * Function checks a state variable for the crtc, if all pending
> commit
> * requests are done, meaning no more bandwidth is needed, release
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse
2020-11-23 11:18 ` [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse Lee Jones
@ 2020-11-23 21:12 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:12 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, Jonathan Marek, David Airlie, linux-arm-msm,
linux-kernel, dri-devel, Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function
> parameter or member 'ctx' not described in 'dpu_hw_sspp_setup_format'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function
> parameter or member 'fmt' not described in 'dpu_hw_sspp_setup_format'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function
> parameter or member 'flags' not described in
> 'dpu_hw_sspp_setup_format'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:240: warning: Function
> parameter or member 'rect_mode' not described in
> 'dpu_hw_sspp_setup_format'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:446: warning: Function
> parameter or member 'ctx' not described in 'dpu_hw_sspp_setup_rects'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:446: warning: Function
> parameter or member 'cfg' not described in 'dpu_hw_sspp_setup_rects'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:446: warning: Function
> parameter or member 'rect_index' not described in
> 'dpu_hw_sspp_setup_rects'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jonathan Marek <jonathan@marek.ca>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> index c940b69435e16..2c2ca5335aa8c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> @@ -231,7 +231,7 @@ static void _sspp_setup_csc10_opmode(struct
> dpu_hw_pipe *ctx,
> DPU_REG_WRITE(&ctx->hw, SSPP_VIG_CSC_10_OP_MODE + idx, opmode);
> }
>
> -/**
> +/*
> * Setup source pixel format, flip,
> */
> static void dpu_hw_sspp_setup_format(struct dpu_hw_pipe *ctx,
> @@ -437,7 +437,7 @@ static u32 _dpu_hw_sspp_get_scaler3_ver(struct
> dpu_hw_pipe *ctx)
> return dpu_hw_get_scaler3_ver(&ctx->hw, idx);
> }
>
> -/**
> +/*
> * dpu_hw_sspp_setup_rects()
> */
> static void dpu_hw_sspp_setup_rects(struct dpu_hw_pipe *ctx,
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx'
2020-11-23 11:18 ` [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' Lee Jones
@ 2020-11-23 21:12 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:12 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c:55: warning: Function
> parameter or member 'ctx' not described in '_stage_offset'
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c:55: warning: Excess
> function parameter 'c' description in '_stage_offset'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> index 4b8baf71423f2..6ac0b5a0e0573 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> @@ -48,7 +48,7 @@ static const struct dpu_lm_cfg *_lm_offset(enum
> dpu_lm mixer,
> /**
> * _stage_offset(): returns the relative offset of the blend registers
> * for the stage to be setup
> - * @c: mixer ctx contains the mixer to be programmed
> + * @ctx: mixer ctx contains the mixer to be programmed
> * @stage: stage index to setup
> */
> static inline int _stage_offset(struct dpu_hw_mixer *ctx, enum
> dpu_stage stage)
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function param descriptions
2020-11-23 11:19 ` [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing " Lee Jones
@ 2020-11-23 21:13 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:13 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Kalyan Thota, Sean Paul
On 2020-11-23 03:19, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function
> parameter or member 'plane' not described in '_dpu_plane_calc_bw'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function
> parameter or member 'fb' not described in '_dpu_plane_calc_bw'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Excess
> function parameter 'Plane' description in '_dpu_plane_calc_bw'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:200: warning: Function
> parameter or member 'plane' not described in '_dpu_plane_calc_clk'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:200: warning: Excess
> function parameter 'Plane' description in '_dpu_plane_calc_clk'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:232: warning: Function
> parameter or member 'src_width' not described in
> '_dpu_plane_calc_fill_level'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:232: warning: Excess
> function parameter 'src_wdith' description in
> '_dpu_plane_calc_fill_level'
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:1060: warning: Function
> parameter or member 'error' not described in 'dpu_plane_set_error'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Kalyan Thota <kalyan_t@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index c0b1d77369e53..cf0084d7cc7c9 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -142,7 +142,8 @@ static struct dpu_kms *_dpu_plane_get_kms(struct
> drm_plane *plane)
>
> /**
> * _dpu_plane_calc_bw - calculate bandwidth required for a plane
> - * @Plane: Pointer to drm plane.
> + * @plane: Pointer to drm plane.
> + * @fb: Pointer to framebuffer associated with the given plane
> * Result: Updates calculated bandwidth in the plane state.
> * BW Equation: src_w * src_h * bpp * fps * (v_total / v_dest)
> * Prefill BW Equation: line src bytes * line_time
> @@ -192,7 +193,7 @@ static void _dpu_plane_calc_bw(struct drm_plane
> *plane,
>
> /**
> * _dpu_plane_calc_clk - calculate clock required for a plane
> - * @Plane: Pointer to drm plane.
> + * @plane: Pointer to drm plane.
> * Result: Updates calculated clock in the plane state.
> * Clock equation: dst_w * v_total * fps * (src_h / dst_h)
> */
> @@ -224,7 +225,7 @@ static void _dpu_plane_calc_clk(struct drm_plane
> *plane)
> * _dpu_plane_calc_fill_level - calculate fill level of the given
> source format
> * @plane: Pointer to drm plane
> * @fmt: Pointer to source buffer format
> - * @src_wdith: width of source buffer
> + * @src_width: width of source buffer
> * Return: fill level corresponding to the source buffer/format or 0
> if error
> */
> static int _dpu_plane_calc_fill_level(struct drm_plane *plane,
> @@ -1055,6 +1056,7 @@ void dpu_plane_flush(struct drm_plane *plane)
> /**
> * dpu_plane_set_error: enable/disable error condition
> * @plane: pointer to drm_plane structure
> + * @error: error value to set
> */
> void dpu_plane_set_error(struct drm_plane *plane, bool error)
> {
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description
2020-11-23 11:19 ` [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description Lee Jones
@ 2020-11-23 21:13 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:13 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Drew Davenport, Sean Paul
On 2020-11-23 03:19, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:247: warning: Excess function
> parameter 'Return' description in '_dpu_rm_check_lm_peer'
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Function
> parameter or member 'global_state' not described in
> '_dpu_rm_check_lm_and_get_connected_blks'
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Excess function
> parameter 'Return' description in
> '_dpu_rm_check_lm_and_get_connected_blks'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Drew Davenport <ddavenport@chromium.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> index 0ae8a36ffcff3..fd2d104f0a91d 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> @@ -239,7 +239,7 @@ static bool _dpu_rm_needs_split_display(const
> struct msm_display_topology *top)
> * @rm: dpu resource manager handle
> * @primary_idx: index of primary mixer in rm->mixer_blks[]
> * @peer_idx: index of other mixer in rm->mixer_blks[]
> - * @Return: true if rm->mixer_blks[peer_idx] is a peer of
> + * Return: true if rm->mixer_blks[peer_idx] is a peer of
> * rm->mixer_blks[primary_idx]
> */
> static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx,
> @@ -264,6 +264,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm
> *rm, int primary_idx,
> * proposed use case requirements, incl. hardwired dependent blocks
> like
> * pingpong
> * @rm: dpu resource manager handle
> + * @global_state: resources shared across multiple kms objects
> * @enc_id: encoder id requesting for allocation
> * @lm_idx: index of proposed layer mixer in rm->mixer_blks[],
> function checks
> * if lm, and all other hardwired blocks connected to the lm (pp)
> is
> @@ -274,7 +275,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm
> *rm, int primary_idx,
> * mixer in rm->dspp_blks[].
> * @reqs: input parameter, rm requirements for HW blocks needed in the
> * datapath.
> - * @Return: true if lm matches all requirements, false otherwise
> + * Return: true if lm matches all requirements, false otherwise
> */
> static bool _dpu_rm_check_lm_and_get_connected_blks(struct dpu_rm *rm,
> struct dpu_global_state *global_state,
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [Freedreno] [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static
2020-11-23 11:19 ` [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static Lee Jones
@ 2020-11-23 21:14 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:14 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Rob Clark, Daniel Vetter, Sean Paul
On 2020-11-23 03:19, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/msm_drv.c:124:15: warning: no previous prototype
> for ‘_msm_ioremap’ [-Wmissing-prototypes]
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c
> b/drivers/gpu/drm/msm/msm_drv.c
> index 4d58668b80853..edc99e3b0eca7 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -121,8 +121,8 @@ struct clk *msm_clk_get(struct platform_device
> *pdev, const char *name)
> return clk;
> }
>
> -void __iomem *_msm_ioremap(struct platform_device *pdev, const char
> *name,
> - const char *dbgname, bool quiet)
> +static void __iomem *_msm_ioremap(struct platform_device *pdev, const
> char *name,
> + const char *dbgname, bool quiet)
> {
> struct resource *res;
> unsigned long size;
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used
2020-11-23 11:18 ` [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used Lee Jones
@ 2020-11-23 21:23 ` abhinavk
0 siblings, 0 replies; 26+ messages in thread
From: abhinavk @ 2020-11-23 21:23 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno
On 2020-11-23 03:18, Lee Jones wrote:
> These tables are not large or overbearing, so moving them into the
> source file seems like the right thing to do. The alternative is to
> use __maybe_unused, which is undesirable.
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:11:
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h:7:23: warning:
> ‘qcom_compressed_supported_formats’ defined but not used
> [-Wunused-const-variable=]
> 7 | static const uint32_t qcom_compressed_supported_formats[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h:48:23: warning:
> ‘plane_formats_yuv’ defined but not used [-Wunused-const-variable=]
> 48 | static const uint32_t plane_formats_yuv[] = {
> | ^~~~~~~~~~~~~~~~~
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h:17:23: warning:
> ‘plane_formats’ defined but not used [-Wunused-const-variable=]
> 17 | static const uint32_t plane_formats[] = {
> | ^~~~~~~~~~~~~
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I think this is reasonable,
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 74 +++++++++++++++-
> .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 -------------------
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 11 ++-
> 3 files changed, 83 insertions(+), 90 deletions(-)
> delete mode 100644
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index a7004f18523b0..9ed6d0c6cd9b2 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -8,7 +8,6 @@
> #include <linux/platform_device.h>
> #include "dpu_hw_mdss.h"
> #include "dpu_hw_catalog.h"
> -#include "dpu_hw_catalog_format.h"
> #include "dpu_kms.h"
>
> #define VIG_MASK \
> @@ -62,6 +61,79 @@
>
> #define STRCAT(X, Y) (X Y)
>
> +static const uint32_t plane_formats[] = {
> + DRM_FORMAT_ARGB8888,
> + DRM_FORMAT_ABGR8888,
> + DRM_FORMAT_RGBA8888,
> + DRM_FORMAT_BGRA8888,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_RGBX8888,
> + DRM_FORMAT_BGRX8888,
> + DRM_FORMAT_XBGR8888,
> + DRM_FORMAT_RGB888,
> + DRM_FORMAT_BGR888,
> + DRM_FORMAT_RGB565,
> + DRM_FORMAT_BGR565,
> + DRM_FORMAT_ARGB1555,
> + DRM_FORMAT_ABGR1555,
> + DRM_FORMAT_RGBA5551,
> + DRM_FORMAT_BGRA5551,
> + DRM_FORMAT_XRGB1555,
> + DRM_FORMAT_XBGR1555,
> + DRM_FORMAT_RGBX5551,
> + DRM_FORMAT_BGRX5551,
> + DRM_FORMAT_ARGB4444,
> + DRM_FORMAT_ABGR4444,
> + DRM_FORMAT_RGBA4444,
> + DRM_FORMAT_BGRA4444,
> + DRM_FORMAT_XRGB4444,
> + DRM_FORMAT_XBGR4444,
> + DRM_FORMAT_RGBX4444,
> + DRM_FORMAT_BGRX4444,
> +};
> +
> +static const uint32_t plane_formats_yuv[] = {
> + DRM_FORMAT_ARGB8888,
> + DRM_FORMAT_ABGR8888,
> + DRM_FORMAT_RGBA8888,
> + DRM_FORMAT_BGRX8888,
> + DRM_FORMAT_BGRA8888,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_XBGR8888,
> + DRM_FORMAT_RGBX8888,
> + DRM_FORMAT_RGB888,
> + DRM_FORMAT_BGR888,
> + DRM_FORMAT_RGB565,
> + DRM_FORMAT_BGR565,
> + DRM_FORMAT_ARGB1555,
> + DRM_FORMAT_ABGR1555,
> + DRM_FORMAT_RGBA5551,
> + DRM_FORMAT_BGRA5551,
> + DRM_FORMAT_XRGB1555,
> + DRM_FORMAT_XBGR1555,
> + DRM_FORMAT_RGBX5551,
> + DRM_FORMAT_BGRX5551,
> + DRM_FORMAT_ARGB4444,
> + DRM_FORMAT_ABGR4444,
> + DRM_FORMAT_RGBA4444,
> + DRM_FORMAT_BGRA4444,
> + DRM_FORMAT_XRGB4444,
> + DRM_FORMAT_XBGR4444,
> + DRM_FORMAT_RGBX4444,
> + DRM_FORMAT_BGRX4444,
> +
> + DRM_FORMAT_NV12,
> + DRM_FORMAT_NV21,
> + DRM_FORMAT_NV16,
> + DRM_FORMAT_NV61,
> + DRM_FORMAT_VYUY,
> + DRM_FORMAT_UYVY,
> + DRM_FORMAT_YUYV,
> + DRM_FORMAT_YVYU,
> + DRM_FORMAT_YUV420,
> + DRM_FORMAT_YVU420,
> +};
> +
> /*************************************************************
> * DPU sub blocks config
> *************************************************************/
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
> deleted file mode 100644
> index 3766f0fd0bf08..0000000000000
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h
> +++ /dev/null
> @@ -1,88 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.
> - */
> -
> -#include "dpu_hw_mdss.h"
> -
> -static const uint32_t qcom_compressed_supported_formats[] = {
> - DRM_FORMAT_ABGR8888,
> - DRM_FORMAT_ARGB8888,
> - DRM_FORMAT_XBGR8888,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_BGR565,
> -
> - DRM_FORMAT_NV12,
> -};
> -
> -static const uint32_t plane_formats[] = {
> - DRM_FORMAT_ARGB8888,
> - DRM_FORMAT_ABGR8888,
> - DRM_FORMAT_RGBA8888,
> - DRM_FORMAT_BGRA8888,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_RGBX8888,
> - DRM_FORMAT_BGRX8888,
> - DRM_FORMAT_XBGR8888,
> - DRM_FORMAT_RGB888,
> - DRM_FORMAT_BGR888,
> - DRM_FORMAT_RGB565,
> - DRM_FORMAT_BGR565,
> - DRM_FORMAT_ARGB1555,
> - DRM_FORMAT_ABGR1555,
> - DRM_FORMAT_RGBA5551,
> - DRM_FORMAT_BGRA5551,
> - DRM_FORMAT_XRGB1555,
> - DRM_FORMAT_XBGR1555,
> - DRM_FORMAT_RGBX5551,
> - DRM_FORMAT_BGRX5551,
> - DRM_FORMAT_ARGB4444,
> - DRM_FORMAT_ABGR4444,
> - DRM_FORMAT_RGBA4444,
> - DRM_FORMAT_BGRA4444,
> - DRM_FORMAT_XRGB4444,
> - DRM_FORMAT_XBGR4444,
> - DRM_FORMAT_RGBX4444,
> - DRM_FORMAT_BGRX4444,
> -};
> -
> -static const uint32_t plane_formats_yuv[] = {
> - DRM_FORMAT_ARGB8888,
> - DRM_FORMAT_ABGR8888,
> - DRM_FORMAT_RGBA8888,
> - DRM_FORMAT_BGRX8888,
> - DRM_FORMAT_BGRA8888,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_XBGR8888,
> - DRM_FORMAT_RGBX8888,
> - DRM_FORMAT_RGB888,
> - DRM_FORMAT_BGR888,
> - DRM_FORMAT_RGB565,
> - DRM_FORMAT_BGR565,
> - DRM_FORMAT_ARGB1555,
> - DRM_FORMAT_ABGR1555,
> - DRM_FORMAT_RGBA5551,
> - DRM_FORMAT_BGRA5551,
> - DRM_FORMAT_XRGB1555,
> - DRM_FORMAT_XBGR1555,
> - DRM_FORMAT_RGBX5551,
> - DRM_FORMAT_BGRX5551,
> - DRM_FORMAT_ARGB4444,
> - DRM_FORMAT_ABGR4444,
> - DRM_FORMAT_RGBA4444,
> - DRM_FORMAT_BGRA4444,
> - DRM_FORMAT_XRGB4444,
> - DRM_FORMAT_XBGR4444,
> - DRM_FORMAT_RGBX4444,
> - DRM_FORMAT_BGRX4444,
> -
> - DRM_FORMAT_NV12,
> - DRM_FORMAT_NV21,
> - DRM_FORMAT_NV16,
> - DRM_FORMAT_NV61,
> - DRM_FORMAT_VYUY,
> - DRM_FORMAT_UYVY,
> - DRM_FORMAT_YUYV,
> - DRM_FORMAT_YVYU,
> - DRM_FORMAT_YUV420,
> - DRM_FORMAT_YVU420,
> -};
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 7ea90d25a3b69..c0b1d77369e53 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -19,7 +19,6 @@
> #include "dpu_kms.h"
> #include "dpu_formats.h"
> #include "dpu_hw_sspp.h"
> -#include "dpu_hw_catalog_format.h"
> #include "dpu_trace.h"
> #include "dpu_crtc.h"
> #include "dpu_vbif.h"
> @@ -63,6 +62,16 @@ enum {
>
> #define DEFAULT_REFRESH_RATE 60
>
> +static const uint32_t qcom_compressed_supported_formats[] = {
> + DRM_FORMAT_ABGR8888,
> + DRM_FORMAT_ARGB8888,
> + DRM_FORMAT_XBGR8888,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_BGR565,
> +
> + DRM_FORMAT_NV12,
> +};
> +
> /**
> * enum dpu_plane_qos - Different qos configurations for each pipe
> *
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2020-11-23 21:24 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 11:18 [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Lee Jones
2020-11-23 11:18 ` [PATCH 10/40] drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues Lee Jones
2020-11-23 21:10 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description Lee Jones
2020-11-23 21:06 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 12/40] drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header Lee Jones
2020-11-23 21:08 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 13/40] drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth' Lee Jones
2020-11-23 21:07 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 14/40] drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used Lee Jones
2020-11-23 21:23 ` abhinavk
2020-11-23 11:18 ` [PATCH 18/40] drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues Lee Jones
2020-11-23 21:10 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 19/40] drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' Lee Jones
2020-11-23 21:12 ` [Freedreno] " abhinavk
2020-11-23 11:18 ` [PATCH 20/40] drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse Lee Jones
2020-11-23 21:12 ` [Freedreno] " abhinavk
2020-11-23 11:19 ` [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description Lee Jones
2020-11-23 21:13 ` [Freedreno] " abhinavk
2020-11-23 11:19 ` [PATCH 32/40] drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param descriptions Lee Jones
2020-11-23 11:19 ` [PATCH 35/40] drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing " Lee Jones
2020-11-23 21:13 ` [Freedreno] " abhinavk
2020-11-23 11:19 ` [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static Lee Jones
2020-11-23 21:14 ` [Freedreno] " abhinavk
2020-11-23 11:52 ` [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU Christian König
2020-11-23 12:30 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).