* [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full
@ 2021-02-17 16:26 Jeffrey Hugo
2021-02-17 16:44 ` Hemant Kumar
2021-02-24 9:55 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2021-02-17 16:26 UTC (permalink / raw)
To: manivannan.sadhasivam, hemantk
Cc: bbhatt, linux-arm-msm, linux-kernel, Fan Wu, Jeffrey Hugo
From: Fan Wu <wufan@codeaurora.org>
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EAGAIN instead.
Signed-off-by: Fan Wu <wufan@codeaurora.org>
Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
---
v3: Fix subject
v2: Change from EBUSY to EAGAIN
drivers/bus/mhi/core/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
index b63f9e6..1eb2fd3 100644
--- a/drivers/bus/mhi/core/main.c
+++ b/drivers/bus/mhi/core/main.c
@@ -1054,7 +1054,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info,
ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
if (unlikely(ret)) {
- ret = -ENOMEM;
+ ret = -EAGAIN;
goto exit_unlock;
}
--
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full
2021-02-17 16:26 [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full Jeffrey Hugo
@ 2021-02-17 16:44 ` Hemant Kumar
2021-02-24 9:55 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Hemant Kumar @ 2021-02-17 16:44 UTC (permalink / raw)
To: Jeffrey Hugo, manivannan.sadhasivam
Cc: bbhatt, linux-arm-msm, linux-kernel, Fan Wu
On 2/17/21 8:26 AM, Jeffrey Hugo wrote:
> From: Fan Wu <wufan@codeaurora.org>
>
> Currently ENOMEM is returned when MHI ring is full. This error code is
> very misleading. Change to EAGAIN instead.
>
> Signed-off-by: Fan Wu <wufan@codeaurora.org>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full
2021-02-17 16:26 [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full Jeffrey Hugo
2021-02-17 16:44 ` Hemant Kumar
@ 2021-02-24 9:55 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-02-24 9:55 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: hemantk, bbhatt, linux-arm-msm, linux-kernel, Fan Wu
On Wed, Feb 17, 2021 at 09:26:49AM -0700, Jeffrey Hugo wrote:
> From: Fan Wu <wufan@codeaurora.org>
>
> Currently ENOMEM is returned when MHI ring is full. This error code is
> very misleading. Change to EAGAIN instead.
>
> Signed-off-by: Fan Wu <wufan@codeaurora.org>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
>
> v3: Fix subject
> v2: Change from EBUSY to EAGAIN
>
> drivers/bus/mhi/core/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index b63f9e6..1eb2fd3 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1054,7 +1054,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info,
>
> ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
> if (unlikely(ret)) {
> - ret = -ENOMEM;
> + ret = -EAGAIN;
> goto exit_unlock;
> }
>
> --
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-24 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-17 16:26 [PATCH v3] bus: mhi: core: Return EAGAIN if MHI ring is full Jeffrey Hugo
2021-02-17 16:44 ` Hemant Kumar
2021-02-24 9:55 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).