* Re: [PATCH] bus: mhi: Make firmware image optional for controller
2021-03-09 18:46 [PATCH] bus: mhi: Make firmware image optional for controller Bhaumik Bhatt
@ 2021-03-09 18:57 ` Jeffrey Hugo
2021-03-10 14:13 ` Manivannan Sadhasivam
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jeffrey Hugo @ 2021-03-09 18:57 UTC (permalink / raw)
To: Bhaumik Bhatt, manivannan.sadhasivam
Cc: linux-arm-msm, hemantk, linux-kernel, carl.yin, naveen.kumar,
loic.poulain
On 3/9/2021 11:46 AM, Bhaumik Bhatt wrote:
> Some controllers can opt to not have MHI download a firmware
> image to have the device bootup and can find the device in a
> pass through execution environment, ready to go. Thus, MHI
> controllers for those devices do not need fw_image defined.
> Make it optional to accommodate different bootup modes.
>
> Suggested-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: Make firmware image optional for controller
2021-03-09 18:46 [PATCH] bus: mhi: Make firmware image optional for controller Bhaumik Bhatt
2021-03-09 18:57 ` Jeffrey Hugo
@ 2021-03-10 14:13 ` Manivannan Sadhasivam
2021-03-10 14:14 ` Manivannan Sadhasivam
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-03-10 14:13 UTC (permalink / raw)
To: Bhaumik Bhatt
Cc: linux-arm-msm, hemantk, jhugo, linux-kernel, carl.yin,
naveen.kumar, loic.poulain
On Tue, Mar 09, 2021 at 10:46:35AM -0800, Bhaumik Bhatt wrote:
> Some controllers can opt to not have MHI download a firmware
> image to have the device bootup and can find the device in a
> pass through execution environment, ready to go. Thus, MHI
> controllers for those devices do not need fw_image defined.
> Make it optional to accommodate different bootup modes.
>
> Suggested-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> include/linux/mhi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 56c4c52..838a3c4 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -296,7 +296,7 @@ struct mhi_controller_config {
> * @wake_db: MHI WAKE doorbell register address
> * @iova_start: IOMMU starting address for data (required)
> * @iova_stop: IOMMU stop address for data (required)
> - * @fw_image: Firmware image name for normal booting (required)
> + * @fw_image: Firmware image name for normal booting (optional)
> * @edl_image: Firmware image name for emergency download mode (optional)
> * @rddm_size: RAM dump size that host should allocate for debugging purpose
> * @sbl_size: SBL image size downloaded through BHIe (optional)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: Make firmware image optional for controller
2021-03-09 18:46 [PATCH] bus: mhi: Make firmware image optional for controller Bhaumik Bhatt
2021-03-09 18:57 ` Jeffrey Hugo
2021-03-10 14:13 ` Manivannan Sadhasivam
@ 2021-03-10 14:14 ` Manivannan Sadhasivam
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-03-10 14:14 UTC (permalink / raw)
To: Bhaumik Bhatt
Cc: linux-arm-msm, hemantk, jhugo, linux-kernel, carl.yin,
naveen.kumar, loic.poulain
On Tue, Mar 09, 2021 at 10:46:35AM -0800, Bhaumik Bhatt wrote:
> Some controllers can opt to not have MHI download a firmware
> image to have the device bootup and can find the device in a
> pass through execution environment, ready to go. Thus, MHI
> controllers for those devices do not need fw_image defined.
> Make it optional to accommodate different bootup modes.
>
> Suggested-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> include/linux/mhi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 56c4c52..838a3c4 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -296,7 +296,7 @@ struct mhi_controller_config {
> * @wake_db: MHI WAKE doorbell register address
> * @iova_start: IOMMU starting address for data (required)
> * @iova_stop: IOMMU stop address for data (required)
> - * @fw_image: Firmware image name for normal booting (required)
> + * @fw_image: Firmware image name for normal booting (optional)
> * @edl_image: Firmware image name for emergency download mode (optional)
> * @rddm_size: RAM dump size that host should allocate for debugging purpose
> * @sbl_size: SBL image size downloaded through BHIe (optional)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: Make firmware image optional for controller
2021-03-09 18:46 [PATCH] bus: mhi: Make firmware image optional for controller Bhaumik Bhatt
` (2 preceding siblings ...)
2021-03-10 14:14 ` Manivannan Sadhasivam
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
To: Bhaumik Bhatt; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Tue, 9 Mar 2021 10:46:35 -0800 you wrote:
> Some controllers can opt to not have MHI download a firmware
> image to have the device bootup and can find the device in a
> pass through execution environment, ready to go. Thus, MHI
> controllers for those devices do not need fw_image defined.
> Make it optional to accommodate different bootup modes.
>
> Suggested-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>
> [...]
Here is the summary with links:
- bus: mhi: Make firmware image optional for controller
https://git.kernel.org/qcom/c/4d5f52838d11
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread