From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Uwe Kleine-K?nig <uwe@kleine-koenig.org>
Cc: Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: Simplify usage of dev_err_probe()
Date: Tue, 27 Apr 2021 11:56:12 -0500 [thread overview]
Message-ID: <20210427165612.GH1908499@yoga> (raw)
In-Reply-To: <20210427164522.2886825-1-uwe@kleine-koenig.org>
On Tue 27 Apr 11:45 CDT 2021, Uwe Kleine-K?nig wrote:
> dev_err_probe() returns the error code passed as second parameter. Also if
> the error code is -EPROBE_DEFER dev_err_probe() is silent, so there is no
> need to check for this value before calling dev_err_probe().
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> drivers/clk/qcom/apcs-sdx55.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/clk/qcom/apcs-sdx55.c b/drivers/clk/qcom/apcs-sdx55.c
> index d0edabebf9c2..6810637f32e3 100644
> --- a/drivers/clk/qcom/apcs-sdx55.c
> +++ b/drivers/clk/qcom/apcs-sdx55.c
> @@ -56,10 +56,8 @@ static int qcom_apcs_sdx55_clk_probe(struct platform_device *pdev)
> int ret;
>
> regmap = dev_get_regmap(parent, NULL);
> - if (!regmap) {
> - dev_err_probe(dev, -ENODEV, "Failed to get parent regmap\n");
> - return -ENODEV;
> - }
> + if (!regmap)
> + return dev_err_probe(dev, -ENODEV, "Failed to get parent regmap\n");
>
> a7cc = devm_kzalloc(dev, sizeof(*a7cc), GFP_KERNEL);
> if (!a7cc)
> @@ -80,19 +78,15 @@ static int qcom_apcs_sdx55_clk_probe(struct platform_device *pdev)
> a7cc->parent_map = apcs_mux_clk_parent_map;
>
> a7cc->pclk = devm_clk_get(parent, "pll");
> - if (IS_ERR(a7cc->pclk)) {
> - ret = PTR_ERR(a7cc->pclk);
> - if (ret != -EPROBE_DEFER)
> - dev_err_probe(dev, ret, "Failed to get PLL clk\n");
> - return ret;
> - }
> + if (IS_ERR(a7cc->pclk))
> + return dev_err_probe(dev, PTR_ERR(a7cc->pclk),
> + "Failed to get PLL clk\n");
>
> a7cc->clk_nb.notifier_call = a7cc_notifier_cb;
> ret = clk_notifier_register(a7cc->pclk, &a7cc->clk_nb);
> - if (ret) {
> - dev_err_probe(dev, ret, "Failed to register clock notifier\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "Failed to register clock notifier\n");
>
> ret = devm_clk_register_regmap(dev, &a7cc->clkr);
> if (ret) {
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-04-27 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 16:45 [PATCH] clk: qcom: Simplify usage of dev_err_probe() Uwe Kleine-König
2021-04-27 16:56 ` Bjorn Andersson [this message]
2021-05-22 14:56 ` Uwe Kleine-König
2021-06-01 23:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427165612.GH1908499@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).