archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: dwc3: gadget: Free gadget structure only after freeing endpoints
@ 2021-05-01  9:30 Jack Pham
  2021-05-01  9:35 ` [PATCH v2] " Jack Pham
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Jack Pham @ 2021-05-01  9:30 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman
  Cc: linux-usb, linux-arm-msm, Peter Chen, Sandeep Maheswaram,
	Wesley Cheng, Elliot Berman, Prasad Sodagudi, Jack Pham

As part of commit e81a7018d93a ("usb: dwc3: allocate gadget structure
dynamically") the dwc3_gadget_release() was added which will free
the dwc->gadget structure upon the device's removal when
usb_del_gadget_udc() is called in dwc3_gadget_exit().

However, simply freeing the gadget results a dangling pointer
situation: the endpoints created in dwc3_gadget_init_endpoints()
have their dep->endpoint.ep_list members chained off the list_head
anchored at dwc->gadget->ep_list.  Thus when dwc->gadget is freed,
the first dwc3_ep in the list now has a dangling prev pointer and
likewise for the next pointer of the dwc3_ep at the tail of the list.
The dwc3_gadget_free_endpoints() that follows will result in a
use-after-free when it calls list_del().

This was caught by enabling KASAN and performing a driver unbind.
The recent commit 568262bf5492 ("usb: dwc3: core: Add shutdown
callback for dwc3") also exposes this as a panic during shutdown.

There are a few possibilities to fix this.  One could be to perform
a list_del() of the gadget->ep_list itself which removes it from
the rest of the dwc3_ep chain.

Another approach is what this patch does, by splitting up the
usb_del_gadget_udc() call into its separate "del" and "put"
components.  This allows dwc3_gadget_free_endpoints() to be
called before the gadget is finally freed with usb_put_gadget().

Fixes: e81a7018d93a ("usb: dwc3: allocate gadget structure dynamically")
Signed-off-by: Jack Pham <>
 drivers/usb/dwc3/gadget.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 6eab78f8a1a7..c7e5f5a07f3b 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4062,8 +4062,9 @@ int dwc3_gadget_init(struct dwc3 *dwc)
 void dwc3_gadget_exit(struct dwc3 *dwc)
-	usb_del_gadget_udc(dwc->gadget);
+	usb_del_gadget(dwc->gadget);
+	usb_del_gadget_put(dwc->gadget);
 	dma_free_coherent(dwc->sysdev, DWC3_BOUNCE_SIZE, dwc->bounce,

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-10 13:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-01  9:30 [PATCH] usb: dwc3: gadget: Free gadget structure only after freeing endpoints Jack Pham
2021-05-01  9:35 ` [PATCH v2] " Jack Pham
2021-05-06 16:02   ` Jack Pham
2021-05-08  6:21   ` Peter Chen
2021-05-10 12:12   ` Felipe Balbi
2021-05-01 11:48 ` [PATCH] " kernel test robot
2021-05-01 13:11 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).