From: Bartosz Dudziak <bartosz.dudziak@snejp.pl>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Kathiravan T <kathirav@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] clk: qcom: smd-rpm: Add support for MSM8226 RPM clocks
Date: Sat, 5 Jun 2021 12:57:14 +0200 [thread overview]
Message-ID: <20210605105714.GA13168@PackardBell> (raw)
In-Reply-To: <162261964337.4130789.14816345669886604238@swboyd.mtv.corp.google.com>
On Wed, Jun 02, 2021 at 12:40:43AM -0700, Stephen Boyd wrote:
> Quoting Bartosz Dudziak (2021-05-02 05:20:27)
> > Add rmp smd clocks, PMIC and bus clocks which are required on MSM8226
> > for clients to vote on.
> >
> > Signed-off-by: Bartosz Dudziak <bartosz.dudziak@snejp.pl>
> > ---
> > drivers/clk/qcom/clk-smd-rpm.c | 74 ++++++++++++++++++++++++++++++++++
> > 1 file changed, 74 insertions(+)
> >
> > diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> > index 0e1dfa8948..bf73942e86 100644
> > --- a/drivers/clk/qcom/clk-smd-rpm.c
> > +++ b/drivers/clk/qcom/clk-smd-rpm.c
> > @@ -406,6 +406,79 @@ static const struct clk_ops clk_smd_rpm_branch_ops = {
> > .unprepare = clk_smd_rpm_unprepare,
> > };
> >
> > +/* msm8226 */
>
> This doesn't apply anymore. Can you resend just this one patch please?
> And base it on clk-next which I will push out shortly. Ideally a bunch
> of clks can be reused instead of redefined.
>
> > +DEFINE_CLK_SMD_RPM(msm8226, pnoc_clk, pnoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 0);
> > +DEFINE_CLK_SMD_RPM(msm8226, snoc_clk, snoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 1);
I have send v2 of this one patch. I have reused the clocks from MSM8974 because
after the change my code happened to be the exacly same as msm8974_clks struct.
prev parent reply other threads:[~2021-06-05 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 12:20 [PATCH 0/4] soc: qcom: Add support for MSM8226 RPM Bartosz Dudziak
2021-05-02 12:20 ` [PATCH 1/4] dt-bindings: soc: qcom: smd-rpm: Add MSM8226 compatible Bartosz Dudziak
2021-05-06 15:21 ` Rob Herring
2021-05-02 12:20 ` [PATCH 2/4] " Bartosz Dudziak
2021-05-02 12:20 ` [PATCH 3/4] dt-bindings: clock: qcom: rpmcc: Document " Bartosz Dudziak
2021-05-06 15:21 ` Rob Herring
2021-06-02 7:39 ` Stephen Boyd
2021-05-02 12:20 ` [PATCH 4/4] clk: qcom: smd-rpm: Add support for MSM8226 RPM clocks Bartosz Dudziak
2021-06-02 7:40 ` Stephen Boyd
2021-06-05 10:57 ` Bartosz Dudziak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605105714.GA13168@PackardBell \
--to=bartosz.dudziak@snejp.pl \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kathirav@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).