From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com,
christian.koenig@amd.com, liviu.dudau@arm.com,
brian.starkey@arm.com, sam@ravnborg.org, bbrezillon@kernel.org,
nicolas.ferre@microchip.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com,
patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com,
robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org,
Dan.Sneddon@microchip.com, tomi.valkeinen@ideasonboard.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 13/14] drm: Remove unused devm_drm_irq_install()
Date: Tue, 3 Aug 2021 11:07:03 +0200 [thread overview]
Message-ID: <20210803090704.32152-14-tzimmermann@suse.de> (raw)
In-Reply-To: <20210803090704.32152-1-tzimmermann@suse.de>
DRM IRQ helpers will become legacy. The function devm_drm_irq_install()
is unused and won't be required later.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_irq.c | 32 --------------------------------
include/drm/drm_irq.h | 1 -
2 files changed, 33 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 201eae4bba6c..dc6e38fa8a48 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -209,38 +209,6 @@ int drm_irq_uninstall(struct drm_device *dev)
}
EXPORT_SYMBOL(drm_irq_uninstall);
-static void devm_drm_irq_uninstall(void *data)
-{
- drm_irq_uninstall(data);
-}
-
-/**
- * devm_drm_irq_install - install IRQ handler
- * @dev: DRM device
- * @irq: IRQ number to install the handler for
- *
- * devm_drm_irq_install is a help function of drm_irq_install.
- *
- * if the driver uses devm_drm_irq_install, there is no need
- * to call drm_irq_uninstall when the drm module get unloaded,
- * as this will done automagically.
- *
- * Returns:
- * Zero on success or a negative error code on failure.
- */
-int devm_drm_irq_install(struct drm_device *dev, int irq)
-{
- int ret;
-
- ret = drm_irq_install(dev, irq);
- if (ret)
- return ret;
-
- return devm_add_action_or_reset(dev->dev,
- devm_drm_irq_uninstall, dev);
-}
-EXPORT_SYMBOL(devm_drm_irq_install);
-
#if IS_ENABLED(CONFIG_DRM_LEGACY)
int drm_legacy_irq_control(struct drm_device *dev, void *data,
struct drm_file *file_priv)
diff --git a/include/drm/drm_irq.h b/include/drm/drm_irq.h
index 631b22f9757d..53634b988f57 100644
--- a/include/drm/drm_irq.h
+++ b/include/drm/drm_irq.h
@@ -28,5 +28,4 @@ struct drm_device;
int drm_irq_install(struct drm_device *dev, int irq);
int drm_irq_uninstall(struct drm_device *dev);
-int devm_drm_irq_install(struct drm_device *dev, int irq);
#endif
--
2.32.0
next prev parent reply other threads:[~2021-08-03 9:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 9:06 [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 01/14] drm/amdgpu: Convert to Linux IRQ interfaces Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 02/14] drm/arm/hdlcd: " Thomas Zimmermann
2021-08-20 16:05 ` Liviu Dudau
2021-08-03 9:06 ` [PATCH v2 03/14] drm/atmel-hlcdc: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 04/14] drm/fsl-dcu: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 05/14] drm/gma500: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 06/14] drm/kmb: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 07/14] drm/msm: " Thomas Zimmermann
2021-08-03 9:37 ` Dmitry Baryshkov
2021-08-03 15:04 ` Rob Clark
2021-08-07 17:08 ` Rob Clark
2021-08-07 18:40 ` Thomas Zimmermann
2021-08-07 18:50 ` Rob Clark
2021-08-03 17:20 ` [Freedreno] " abhinavk
2021-08-03 9:06 ` [PATCH v2 08/14] drm/mxsfb: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 09/14] drm/radeon: " Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 10/14] drm/tidss: " Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 11/14] drm/tilcdc: " Thomas Zimmermann
[not found] ` <YQlZ+EQVbO9N3Mla@ravnborg.org>
2021-08-04 18:30 ` Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 12/14] drm/vc4: " Thomas Zimmermann
2021-08-03 9:07 ` Thomas Zimmermann [this message]
2021-08-03 9:07 ` [PATCH v2 14/14] drm: IRQ midlayer is now legacy Thomas Zimmermann
[not found] ` <YQlbFjbrnyeWv7QP@ravnborg.org>
2021-08-03 18:36 ` [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy Chrisanthus, Anitha
2021-08-04 7:10 ` Thomas Zimmermann
2021-08-05 23:59 ` Chrisanthus, Anitha
2021-08-07 6:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803090704.32152-14-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=Dan.Sneddon@microchip.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alison.wang@nxp.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anitha.chrisanthus@intel.com \
--cc=bbrezillon@kernel.org \
--cc=brian.starkey@arm.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tomba@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).