From: Thomas Zimmermann <tzimmermann@suse.de>
To: "Chrisanthus, Anitha" <anitha.chrisanthus@intel.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: "daniel@ffwll.ch" <daniel@ffwll.ch>,
"airlied@linux.ie" <airlied@linux.ie>,
"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
"brian.starkey@arm.com" <brian.starkey@arm.com>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"alison.wang@nxp.com" <alison.wang@nxp.com>,
"patrik.r.jakobsson@gmail.com" <patrik.r.jakobsson@gmail.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"Dea, Edmund J" <edmund.j.dea@intel.com>,
"sean@poorly.run" <sean@poorly.run>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"jyri.sarha@iki.fi" <jyri.sarha@iki.fi>,
"tomba@kernel.org" <tomba@kernel.org>,
"Dan.Sneddon@microchip.com" <Dan.Sneddon@microchip.com>,
"tomi.valkeinen@ideasonboard.com"
<tomi.valkeinen@ideasonboard.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"freedreno@lists.freedesktop.org"
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy
Date: Wed, 4 Aug 2021 09:10:43 +0200 [thread overview]
Message-ID: <4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de> (raw)
In-Reply-To: <BY5PR11MB41822706053ADEE927E34E628CF09@BY5PR11MB4182.namprd11.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 3945 bytes --]
Hi
Am 03.08.21 um 20:36 schrieb Chrisanthus, Anitha:
> Hi Thomas,
> Can you please hold off on applying the kmb patch, I am seeing some issues while testing. Modetest works, but video playback only plays once, and it fails the second time with this patch.
Sounds a bit like the testing issue at [1]. For testing, you need the
latest drm-misc-next or drm-tip. Specifically, you need commit
1e4cd78ed493 ("drm: Don't test for IRQ support in VBLANK ioctls").
Let me know whether this works for you.
Best regards
Thomas
[1] https://patchwork.freedesktop.org/patch/447057/?series=93078&rev=1
>
> Thanks,
> Anitha
>
>
>> -----Original Message-----
>> From: Sam Ravnborg <sam@ravnborg.org>
>> Sent: Tuesday, August 3, 2021 8:05 AM
>> To: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: daniel@ffwll.ch; airlied@linux.ie; alexander.deucher@amd.com;
>> christian.koenig@amd.com; liviu.dudau@arm.com; brian.starkey@arm.com;
>> bbrezillon@kernel.org; nicolas.ferre@microchip.com;
>> maarten.lankhorst@linux.intel.com; mripard@kernel.org; stefan@agner.ch;
>> alison.wang@nxp.com; patrik.r.jakobsson@gmail.com; Chrisanthus, Anitha
>> <anitha.chrisanthus@intel.com>; robdclark@gmail.com; Dea, Edmund J
>> <edmund.j.dea@intel.com>; sean@poorly.run; shawnguo@kernel.org;
>> s.hauer@pengutronix.de; kernel@pengutronix.de; jyri.sarha@iki.fi;
>> tomba@kernel.org; Dan.Sneddon@microchip.com;
>> tomi.valkeinen@ideasonboard.com; amd-gfx@lists.freedesktop.org; dri-
>> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-arm-
>> msm@vger.kernel.org; freedreno@lists.freedesktop.org
>> Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy
>>
>> Hi Thomas,
>>
>> On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote:
>>> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move
>>> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux
>>> IRQ interfaces.
>>>
>>> DRM provides IRQ helpers for setting up, receiving and removing IRQ
>>> handlers. It's an abstraction over plain Linux functions. The code
>>> is mid-layerish with several callbacks to hook into the rsp drivers.
>>> Old UMS driver have their interrupts enabled via ioctl, so these
>>> abstractions makes some sense. Modern KMS manage all their interrupts
>>> internally. Using the DRM helpers adds indirection without benefits.
>>>
>>> Most KMS drivers already use Linux IRQ functions instead of DRM's
>>> abstraction layer. Patches 1 to 12 convert the remaining ones.
>>> The patches also resolve a bug for devices without assigned interrupt
>>> number. DRM helpers don't test for IRQ_NOTCONNECTED, so drivers do
>>> not detect if the device has no interrupt assigned.
>>>
>>> Patch 13 removes an unused function.
>>>
>>> Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only
>>> the old non-KMS drivers still use the functionality.
>>>
>>> v2:
>>> * drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam)
>>> * use devm_request_irq() in atmel-hlcdc (Sam)
>>> * unify variable names in arm/hlcdc (Sam)
>>>
>>> Thomas Zimmermann (14):
>>
>> The following patches are all:
>> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>>
>>> drm/fsl-dcu: Convert to Linux IRQ interfaces
>>> drm/gma500: Convert to Linux IRQ interfaces
>>> drm/kmb: Convert to Linux IRQ interfaces
>>> drm/msm: Convert to Linux IRQ interfaces
>>> drm/mxsfb: Convert to Linux IRQ interfaces
>>> drm/tidss: Convert to Linux IRQ interfaces
>>> drm/vc4: Convert to Linux IRQ interfaces
>>> drm: Remove unused devm_drm_irq_install()
>>
>> The remaining patches I either skipped or already had a feedback from
>> me or I asked a question.
>>
>> Sam
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-08-04 7:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 9:06 [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 01/14] drm/amdgpu: Convert to Linux IRQ interfaces Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 02/14] drm/arm/hdlcd: " Thomas Zimmermann
2021-08-20 16:05 ` Liviu Dudau
2021-08-03 9:06 ` [PATCH v2 03/14] drm/atmel-hlcdc: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 04/14] drm/fsl-dcu: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 05/14] drm/gma500: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 06/14] drm/kmb: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 07/14] drm/msm: " Thomas Zimmermann
2021-08-03 9:37 ` Dmitry Baryshkov
2021-08-03 15:04 ` Rob Clark
2021-08-07 17:08 ` Rob Clark
2021-08-07 18:40 ` Thomas Zimmermann
2021-08-07 18:50 ` Rob Clark
2021-08-03 17:20 ` [Freedreno] " abhinavk
2021-08-03 9:06 ` [PATCH v2 08/14] drm/mxsfb: " Thomas Zimmermann
2021-08-03 9:06 ` [PATCH v2 09/14] drm/radeon: " Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 10/14] drm/tidss: " Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 11/14] drm/tilcdc: " Thomas Zimmermann
[not found] ` <YQlZ+EQVbO9N3Mla@ravnborg.org>
2021-08-04 18:30 ` Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 12/14] drm/vc4: " Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 13/14] drm: Remove unused devm_drm_irq_install() Thomas Zimmermann
2021-08-03 9:07 ` [PATCH v2 14/14] drm: IRQ midlayer is now legacy Thomas Zimmermann
[not found] ` <YQlbFjbrnyeWv7QP@ravnborg.org>
2021-08-03 18:36 ` [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy Chrisanthus, Anitha
2021-08-04 7:10 ` Thomas Zimmermann [this message]
2021-08-05 23:59 ` Chrisanthus, Anitha
2021-08-07 6:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dbc29d7-5f88-e3ac-5dab-e2dc5c6a703e@suse.de \
--to=tzimmermann@suse.de \
--cc=Dan.Sneddon@microchip.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alison.wang@nxp.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anitha.chrisanthus@intel.com \
--cc=bbrezillon@kernel.org \
--cc=brian.starkey@arm.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tomba@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).