From: DENG Qingfang <dqfext@gmail.com>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Russell King <linux@armlinux.org.uk>,
John Crispin <john@phrozen.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [net-next PATCH v6 05/16] net: dsa: qca8k: add support for cpu port 6
Date: Wed, 13 Oct 2021 12:10:04 +0800 [thread overview]
Message-ID: <20211013041004.29805-1-dqfext@gmail.com> (raw)
In-Reply-To: <20211013011622.10537-6-ansuelsmth@gmail.com>
On Wed, Oct 13, 2021 at 03:16:11AM +0200, Ansuel Smith wrote:
> @@ -1017,13 +1033,14 @@ static int
> qca8k_setup(struct dsa_switch *ds)
> {
> struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
> + u8 cpu_port;
> int ret, i;
> u32 mask;
>
> - /* Make sure that port 0 is the cpu port */
> - if (!dsa_is_cpu_port(ds, 0)) {
> - dev_err(priv->dev, "port 0 is not the CPU port");
> - return -EINVAL;
> + cpu_port = qca8k_find_cpu_port(ds);
> + if (cpu_port < 0) {
cpu_port should be of type int, otherwise this is always false.
> + dev_err(priv->dev, "No cpu port configured in both cpu port0 and port6");
> + return cpu_port;
> }
next prev parent reply other threads:[~2021-10-13 4:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 1:16 [net-next PATCH v6 00/16] Multiple improvement for qca8337 switch Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 01/16] dsa: qca8k: add mac_power_sel support Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 02/16] dt-bindings: net: dsa: qca8k: Add SGMII clock phase properties Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 03/16] net: dsa: qca8k: add support for sgmii falling edge Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 04/16] dt-bindings: net: dsa: qca8k: Document support for CPU port 6 Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 05/16] net: dsa: qca8k: add support for cpu " Ansuel Smith
2021-10-13 4:10 ` DENG Qingfang [this message]
2021-10-13 11:42 ` Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 06/16] net: dsa: qca8k: rework rgmii delay logic and scan " Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 07/16] dt-bindings: net: dsa: qca8k: Document qca,sgmii-enable-pll Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 08/16] net: dsa: qca8k: add explicit SGMII PLL enable Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 09/16] dt-bindings: net: dsa: qca8k: Document qca,led-open-drain binding Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 10/16] net: dsa: qca8k: add support for pws config reg Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 11/16] dt-bindings: net: dsa: qca8k: document support for qca8328 Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 12/16] net: dsa: qca8k: add support for QCA8328 Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 13/16] net: dsa: qca8k: set internal delay also for sgmii Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 14/16] net: dsa: qca8k: move port config to dedicated struct Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 15/16] dt-bindings: net: dsa: qca8k: convert to YAML schema Ansuel Smith
2021-10-13 3:08 ` Rob Herring
2021-10-13 10:30 ` Ansuel Smith
2021-10-13 1:16 ` [net-next PATCH v6 16/16] dt-bindings: net: ipq8064-mdio: fix warning with new qca8k switch Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013041004.29805-1-dqfext@gmail.com \
--to=dqfext@gmail.com \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).