Re: [net-next PATCH v6 15/16] dt-bindings: net: dsa: qca8k: convert to YAML schema

From: Ansuel Smith <ansuelsmth@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	netdev@vger.kernel.org, Matthew Hagan <mnhagan88@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	John Crispin <john@phrozen.org>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [net-next PATCH v6 15/16] dt-bindings: net: dsa: qca8k: convert to YAML schema
Date: Wed, 13 Oct 2021 12:30:03 +0200	[thread overview]
Message-ID: <YWa1KwlM2SFP5jM0@Ansuel-xps.localdomain> (raw)
In-Reply-To: <1634094529.487895.3858822.nullmailer@robh.at.kernel.org>

On Tue, Oct 12, 2021 at 10:08:49PM -0500, Rob Herring wrote:
> On Wed, 13 Oct 2021 03:16:21 +0200, Ansuel Smith wrote:
> > From: Matthew Hagan <mnhagan88@gmail.com>
> > 
> > Convert the qca8k bindings to YAML format.
> > 
> > Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
> > Co-developed-by: Ansuel Smith <ansuelsmth@gmail.com>
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> >  .../devicetree/bindings/net/dsa/qca8k.txt     | 245 ------------
> >  .../devicetree/bindings/net/dsa/qca8k.yaml    | 362 ++++++++++++++++++
> >  2 files changed, 362 insertions(+), 245 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/dsa/qca8k.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/net/dsa/qca8k.yaml:362:7: [error] no new line character at the end of file (new-line-at-end-of-file)
>

Stupid me will fix that...

> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.example.dt.yaml: switch@10: 'oneOf' conditional failed, one must be fixed:
> 	'ports' is a required property
> 	'ethernet-ports' is a required property
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> 

About this i fixed with the next patch. Should I include that in this
patch? Or i can ignore this error?

> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1540096
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 

-- 
	Ansuel