linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file
@ 2021-12-01 23:18 Jean THOMAS
  2021-12-01 23:18 ` [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0 Jean THOMAS
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Jean THOMAS @ 2021-12-01 23:18 UTC (permalink / raw)
  To: virgule
  Cc: linux-arm-msm, devicetree, linux-kernel,
	~postmarketos/upstreaming, petr.vorel, konradybcio

This patch puts the generic code common across all hardware revisions
into a DTSI file.

It also prefixes the DTS filename with the vendor name, to follow the
naming convention used by other DTS files.

Changes since v1:
 - Added "model" property to the DTS file

Signed-off-by: Jean THOMAS <virgule@jeanthomas.me>
---
 arch/arm64/boot/dts/qcom/Makefile                  |  2 +-
 .../boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts  | 14 ++++++++++++++
 ...llhead-rev-101.dts => msm8992-lg-bullhead.dtsi} |  2 --
 3 files changed, 15 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
 rename arch/arm64/boot/dts/qcom/{msm8992-bullhead-rev-101.dts => msm8992-lg-bullhead.dtsi} (98%)

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6b816eb33309..3617157f1420 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -17,7 +17,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a3u-eur.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a5u-eur.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-serranove.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt88047.dtb
-dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-bullhead-rev-101.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-lg-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-msft-lumia-octagon-talkman.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-xiaomi-libra.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8994-angler-rev-101.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
new file mode 100644
index 000000000000..bcda7dbec6a4
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* Copyright (c) Jean Thomas <virgule@jeanthomas.me>
+ */
+
+/dts-v1/;
+
+#include "msm8992-lg-bullhead.dtsi"
+
+/ {
+	model = "LG Nexus 5X rev 1.01";
+	
+	/* required for bootloader to select correct board */
+	qcom,board-id = <0xb64 0>;
+};
diff --git a/arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
similarity index 98%
rename from arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts
rename to arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
index 4da6c44bf532..3b0cc85d6674 100644
--- a/arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
@@ -18,9 +18,7 @@ / {
 	compatible = "lg,bullhead", "qcom,msm8992";
 	chassis-type = "handset";
 
-	/* required for bootloader to select correct board */
 	qcom,msm-id = <251 0>, <252 0>;
-	qcom,board-id = <0xb64 0>;
 	qcom,pmic-id = <0x10009 0x1000A 0x0 0x0>;
 
 	/* Bullhead firmware doesn't support PSCI */
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0
  2021-12-01 23:18 [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Jean THOMAS
@ 2021-12-01 23:18 ` Jean THOMAS
  2021-12-03 21:51   ` Petr Vorel
  2021-12-03 21:50 ` [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Petr Vorel
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Jean THOMAS @ 2021-12-01 23:18 UTC (permalink / raw)
  To: virgule
  Cc: linux-arm-msm, devicetree, linux-kernel,
	~postmarketos/upstreaming, petr.vorel, konradybcio

This commit implements a DTS file for LG Bullhead (Nexus 5X) rev 1.0
with its matching "qcom,board-id" property.

Changes since v1:
 - Added "model" property to the DTS file

Signed-off-by: Jean THOMAS <virgule@jeanthomas.me>
---
 arch/arm64/boot/dts/qcom/Makefile                  |  1 +
 .../boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts   | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 3617157f1420..17aa096f8b99 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -17,6 +17,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a3u-eur.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-a5u-eur.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-samsung-serranove.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt88047.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-lg-bullhead-rev-10.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-lg-bullhead-rev-101.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-msft-lumia-octagon-talkman.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8992-xiaomi-libra.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
new file mode 100644
index 000000000000..7e6bce4af441
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* Copyright (c) Jean Thomas <virgule@jeanthomas.me>
+ */
+
+/dts-v1/;
+
+#include "msm8992-lg-bullhead.dtsi"
+
+/ {
+	model = "LG Nexus 5X rev 1.0";
+
+	/* required for bootloader to select correct board */
+	qcom,board-id = <0xa64 0>;
+};
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file
  2021-12-01 23:18 [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Jean THOMAS
  2021-12-01 23:18 ` [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0 Jean THOMAS
@ 2021-12-03 21:50 ` Petr Vorel
  2022-01-13 20:38 ` Petr Vorel
  2022-02-01  5:20 ` Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-12-03 21:50 UTC (permalink / raw)
  To: Jean THOMAS
  Cc: linux-arm-msm, devicetree, linux-kernel,
	~postmarketos/upstreaming, konradybcio

Hi Jean,

> This patch puts the generic code common across all hardware revisions
> into a DTSI file.

> It also prefixes the DTS filename with the vendor name, to follow the
> naming convention used by other DTS files.

> Changes since v1:
>  - Added "model" property to the DTS file
Not sure if model should stay also in msm8992-lg-bullhead.dtsi, probably yes.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0
  2021-12-01 23:18 ` [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0 Jean THOMAS
@ 2021-12-03 21:51   ` Petr Vorel
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-12-03 21:51 UTC (permalink / raw)
  To: Jean THOMAS
  Cc: linux-arm-msm, devicetree, linux-kernel,
	~postmarketos/upstreaming, konradybcio

Hi Jean,

> This commit implements a DTS file for LG Bullhead (Nexus 5X) rev 1.0
> with its matching "qcom,board-id" property.

> Changes since v1:
>  - Added "model" property to the DTS file

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Thanks!

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file
  2021-12-01 23:18 [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Jean THOMAS
  2021-12-01 23:18 ` [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0 Jean THOMAS
  2021-12-03 21:50 ` [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Petr Vorel
@ 2022-01-13 20:38 ` Petr Vorel
  2022-02-01  5:20 ` Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2022-01-13 20:38 UTC (permalink / raw)
  To: Jean THOMAS
  Cc: linux-arm-msm, devicetree, linux-kernel,
	~postmarketos/upstreaming, konradybcio

Hi Jean,

also for next time, also "qcom:" should be in subject (very minor).

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file
  2021-12-01 23:18 [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Jean THOMAS
                   ` (2 preceding siblings ...)
  2022-01-13 20:38 ` Petr Vorel
@ 2022-02-01  5:20 ` Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-02-01  5:20 UTC (permalink / raw)
  To: Jean THOMAS
  Cc: devicetree, ~postmarketos/upstreaming, linux-arm-msm,
	linux-kernel, petr.vorel, konradybcio

On Thu, 2 Dec 2021 00:18:31 +0100, Jean THOMAS wrote:
> This patch puts the generic code common across all hardware revisions
> into a DTSI file.
> 
> It also prefixes the DTS filename with the vendor name, to follow the
> naming convention used by other DTS files.
> 
> Changes since v1:
>  - Added "model" property to the DTS file
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file
      commit: 3f99518c6f6520ad0fd14d862d54ee12f16156b4
[2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0
      commit: cd4bd4704ec8cff3d045493e2130c7095bbabf78

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-01  5:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 23:18 [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Jean THOMAS
2021-12-01 23:18 ` [PATCH v2 2/2] arm64: dts: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0 Jean THOMAS
2021-12-03 21:51   ` Petr Vorel
2021-12-03 21:50 ` [PATCH v2 1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Petr Vorel
2022-01-13 20:38 ` Petr Vorel
2022-02-01  5:20 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).