* [PATCH] drm/msm: change msm_sched_ops from global to static
@ 2022-04-21 13:15 Tom Rix
2022-04-25 22:12 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-04-21 13:15 UTC (permalink / raw)
To: robdclark, sean, quic_abhinavk, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Tom Rix
Smatch reports this issue
msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static?
msm_sched_ops is only used in msm_ringbuffer.c so change its
storage-class specifier to static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c
index 367a6aaa3a20..66f4ec09ef67 100644
--- a/drivers/gpu/drm/msm/msm_ringbuffer.c
+++ b/drivers/gpu/drm/msm/msm_ringbuffer.c
@@ -40,7 +40,7 @@ static void msm_job_free(struct drm_sched_job *job)
msm_gem_submit_put(submit);
}
-const struct drm_sched_backend_ops msm_sched_ops = {
+static const struct drm_sched_backend_ops msm_sched_ops = {
.run_job = msm_job_run,
.free_job = msm_job_free
};
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm: change msm_sched_ops from global to static
2022-04-21 13:15 [PATCH] drm/msm: change msm_sched_ops from global to static Tom Rix
@ 2022-04-25 22:12 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2022-04-25 22:12 UTC (permalink / raw)
To: Tom Rix, robdclark, sean, quic_abhinavk, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 21/04/2022 16:15, Tom Rix wrote:
> Smatch reports this issue
> msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static?
>
> msm_sched_ops is only used in msm_ringbuffer.c so change its
> storage-class specifier to static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c
> index 367a6aaa3a20..66f4ec09ef67 100644
> --- a/drivers/gpu/drm/msm/msm_ringbuffer.c
> +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c
> @@ -40,7 +40,7 @@ static void msm_job_free(struct drm_sched_job *job)
> msm_gem_submit_put(submit);
> }
>
> -const struct drm_sched_backend_ops msm_sched_ops = {
> +static const struct drm_sched_backend_ops msm_sched_ops = {
> .run_job = msm_job_run,
> .free_job = msm_job_free
> };
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-25 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 13:15 [PATCH] drm/msm: change msm_sched_ops from global to static Tom Rix
2022-04-25 22:12 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).