From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <quic_tdas@quicinc.com>, Vinod Koul <vkoul@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: fixed-rate: add devm_clk_hw_register_fixed_rate
Date: Thu, 23 Jun 2022 18:10:50 -0700 [thread overview]
Message-ID: <20220624011052.1EC7BC3411D@smtp.kernel.org> (raw)
In-Reply-To: <20220620153956.1723269-1-dmitry.baryshkov@linaro.org>
Quoting Dmitry Baryshkov (2022-06-20 08:39:55)
> Add devm_clk_hw_register_fixed_rate(), devres-managed helper to register
> fixed-rate clock.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/clk-asm9260.c | 2 +-
> drivers/clk/clk-fixed-rate.c | 28 ++++++++++++++++++++++++----
> include/linux/clk-provider.h | 27 ++++++++++++++++++++-------
> 3 files changed, 45 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/clk/clk-asm9260.c b/drivers/clk/clk-asm9260.c
> index bacebd457e6f..4da5f38249bf 100644
> --- a/drivers/clk/clk-asm9260.c
> +++ b/drivers/clk/clk-asm9260.c
> @@ -278,7 +278,7 @@ static void __init asm9260_acc_init(struct device_node *np)
> ref_clk = of_clk_get_parent_name(np, 0);
> hw = __clk_hw_register_fixed_rate(NULL, NULL, pll_clk,
> ref_clk, NULL, NULL, 0, rate, 0,
> - CLK_FIXED_RATE_PARENT_ACCURACY);
> + CLK_FIXED_RATE_PARENT_ACCURACY, false);
Can you also make this usage into a macro so that it doesn't change in
the future when a new argument is added?
>
> if (IS_ERR(hw))
> panic("%pOFn: can't register REFCLK. Check DT!", np);
prev parent reply other threads:[~2022-06-24 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:39 [PATCH 1/2] clk: fixed-rate: add devm_clk_hw_register_fixed_rate Dmitry Baryshkov
2022-06-20 15:39 ` [PATCH 2/2] phy: qcom-qmp-ufs: provide symbol clocks Dmitry Baryshkov
2022-06-24 1:09 ` Stephen Boyd
2022-07-07 7:38 ` Johan Hovold
2022-06-24 1:10 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624011052.1EC7BC3411D@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_tdas@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).