* [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes
@ 2022-10-17 9:45 Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
` (10 more replies)
0 siblings, 11 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
This is a first round of trivial bindings & DT fixes for the MDM9615 platform.
This first round focuses on trivial changes, the remaining work will
mainly be .txt to .yaml transition of old qcom pmic & co device bindings.
To: Andy Gross <agross@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Lee Jones <lee@kernel.org>
To: Satya Priya <quic_c_skakit@quicinc.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alessandro Zummo <a.zummo@towertech.it>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: linux-input@vger.kernel.org
Cc: linux-rtc@vger.kernel.org
Dependencies: None
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v3:
- Rebased on v6.1-rc1
- patch 1: Added reviewed-by tag
- patch 2: Fixes typo in commit msg and added precision about why MIT was selected
- patch 3: Added reviewed-by tag
- patch 4: None
- patch 5: Drop second example node
- patch 6: Drop Andy, fix interrupts desc and fix example indentation
- patch 7: Fix commit msg wrap & add reviewed-by tag
- patch 8: Reword commit msg & add reviewed-by tag
- patch 9: Reword commit msg & add reviewed-by tag
- patch 10: None
- patch 11: Added reviewed-by tag
- Link to v2: https://lore.kernel.org/r/20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org
Changes in v2:
- patch 1: switch to move from swir.txt to qcom.yaml
- patch 2: use MIT licence instead of X11 licence
- patch 3: move reg after compatible
- patch 4: added Krzysztof's review
- patch 5: split into 5 changes:
- document qcom,pm8921 as fallback of qcom,pm8018
- convert qcom,pm8921-pwrkey to dt-schema
- document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
- drop unused PM8018 compatible
- drop unused pm8018 RTC compatible
- patch 6: None
- patch 7: Reworded commit log based on Dmitry's wording on similar patches
- Link to v1: https://lore.kernel.org/r/20220928-mdm9615-dt-schema-fixes-v1-0-b6e63a7df1e8@linaro.org
---
Neil Armstrong (11):
dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml
arm: dts: qcom: mdm9615*: add SPDX-License-Identifier
arm: dts: qcom: mdm9615: add missing reg in cpu@0 node
arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node
dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
mfd: qcom-pm8xxx: drop unused PM8018 compatible
rtc: pm8xxx: drop unused pm8018 compatible
arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes
arm: dts: qcom: mdm9615: remove useless amba subnode
Documentation/devicetree/bindings/arm/qcom.yaml | 6 +
Documentation/devicetree/bindings/arm/swir.txt | 12 --
.../bindings/input/qcom,pm8921-pwrkey.yaml | 75 +++++++++++++
.../bindings/input/qcom,pm8xxx-pwrkey.txt | 46 --------
.../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 33 +++++-
.../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 16 ++-
.../boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 39 +------
arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi | 39 +------
arch/arm/boot/dts/qcom-mdm9615.dtsi | 121 +++++++--------------
drivers/mfd/qcom-pm8xxx.c | 1 -
drivers/rtc/rtc-pm8xxx.c | 1 -
11 files changed, 159 insertions(+), 230 deletions(-)
---
base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
change-id: 20220928-mdm9615-dt-schema-fixes-66d4d0ccb7c7
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
` (9 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
Document into the main qcom.yaml as conversion from swir.txt to dt-schema.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
Documentation/devicetree/bindings/arm/swir.txt | 12 ------------
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1b5ac6b02bc5..0a9a1dc68c1b 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -265,6 +265,12 @@ properties:
- qcom,ipq8074-hk10-c2
- const: qcom,ipq8074
+ - description: Sierra Wireless MangOH Green with WP8548 Module
+ items:
+ - const: swir,mangoh-green-wp8548
+ - const: swir,wp8548
+ - const: qcom,mdm9615
+
- description: Qualcomm Technologies, Inc. SC7180 IDP
items:
- enum:
diff --git a/Documentation/devicetree/bindings/arm/swir.txt b/Documentation/devicetree/bindings/arm/swir.txt
deleted file mode 100644
index 042be73a95d3..000000000000
--- a/Documentation/devicetree/bindings/arm/swir.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Sierra Wireless Modules device tree bindings
---------------------------------------------
-
-Supported Modules :
- - WP8548 : Includes MDM9615 and PM8018 in a module
-
-Sierra Wireless modules shall have the following properties :
- Required root node property
- - compatible: "swir,wp8548" for the WP8548 CF3 Module
-
-Board compatible values:
- - "swir,mangoh-green-wp8548" for the mangOH green board with the WP8548 module
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
` (8 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
Replace the license blob by a clean SPDX-License-Identifier with GPL2+
or MIT even if X11 is specified in the original blob since the actual
license text corresponds to a MIT license.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 39 +---------------------
arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi | 39 +---------------------
arch/arm/boot/dts/qcom-mdm9615.dtsi | 39 +---------------------
3 files changed, 3 insertions(+), 114 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
index 0827de5426c1..4e53b3d70195 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
@@ -1,46 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
/*
* Device Tree Source for mangOH Green Board with WP8548 Module
*
* Copyright (C) 2016 BayLibre, SAS.
* Author : Neil Armstrong <narmstrong@baylibre.com>
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/
#include <dt-bindings/input/input.h>
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi b/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
index 49de1821ac3a..2fe8693dc3cd 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548.dtsi
@@ -1,46 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
/*
* Device Tree Source for Sierra Wireless WP8548 Module
*
* Copyright (C) 2016 BayLibre, SAS.
* Author : Neil Armstrong <narmstrong@baylibre.com>
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/
#include "qcom-mdm9615.dtsi"
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index b47c86412de2..de36e4545e75 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -1,46 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
/*
* Device Tree Source for Qualcomm MDM9615 SoC
*
* Copyright (C) 2016 BayLibre, SAS.
* Author : Neil Armstrong <narmstrong@baylibre.com>
- *
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of the
- * License, or (at your option) any later version.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/
/dts-v1/;
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
` (7 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
Fixes cpu@0: 'reg' is a required property from dtbs check.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/qcom-mdm9615.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index de36e4545e75..eaa3236f62db 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -27,6 +27,7 @@ cpus {
cpu0: cpu@0 {
compatible = "arm,cortex-a5";
+ reg = <0>;
device_type = "cpu";
next-level-cache = <&L2>;
};
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (2 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
` (6 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
The spi-max-frequency property has nothing to do in the controller's node,
remove it and fix the 'spi-max-frequency' was unexpected dtbs check error.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/qcom-mdm9615.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index eaa3236f62db..366241dee522 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -170,7 +170,6 @@ gsbi3_spi: spi@16280000 {
#size-cells = <0>;
reg = <0x16280000 0x1000>;
interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>;
- spi-max-frequency = <24000000>;
clocks = <&gcc GSBI3_QUP_CLK>, <&gcc GSBI3_H_CLK>;
clock-names = "core", "iface";
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (3 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 18:59 ` Rob Herring
2022-10-17 9:45 ` [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
` (5 subsequent siblings)
10 siblings, 1 reply; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation,
and an example section to validate this change.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 33 ++++++++++++++++++----
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
index 61bd0b3ce02f..84b87f01e029 100644
--- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
@@ -15,11 +15,15 @@ description: |
properties:
compatible:
- enum:
- - qcom,pm8018
- - qcom,pm8058
- - qcom,pm8821
- - qcom,pm8921
+ oneOf:
+ - enum:
+ - qcom,pm8058
+ - qcom,pm8821
+ - qcom,pm8921
+ - items:
+ - enum:
+ - qcom,pm8018
+ - const: qcom,pm8921
reg:
maxItems: 1
@@ -52,4 +56,23 @@ required:
- interrupt-controller
additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ ssbi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pmic@0 {
+ compatible = "qcom,pm8921";
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <32 IRQ_TYPE_EDGE_RISING>;
+ };
+ };
...
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (4 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 19:01 ` Rob Herring
2022-10-17 22:16 ` Krzysztof Kozlowski
2022-10-17 9:45 ` [PATCH v3 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
` (4 subsequent siblings)
10 siblings, 2 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../bindings/input/qcom,pm8921-pwrkey.yaml | 75 ++++++++++++++++++++++
.../bindings/input/qcom,pm8xxx-pwrkey.txt | 46 -------------
2 files changed, 75 insertions(+), 46 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
new file mode 100644
index 000000000000..9591f77aa22a
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PM8921 PMIC Power Key
+
+maintainers:
+ - Bjorn Andersson <andersson@kernel.org>
+
+allOf:
+ - $ref: input.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - qcom,pm8921-pwrkey
+ - qcom,pm8058-pwrkey
+ - items:
+ - enum:
+ - qcom,pm8018-pwrkey
+ - const: qcom,pm8921-pwrkey
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ items:
+ - description: key release
+ - description: key press
+
+ debounce:
+ description: |
+ Time in microseconds that key must be pressed or
+ released for state change interrupt to trigger.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ pull-up:
+ description: |
+ Presence of this property indicates that the KPDPWR_N
+ pin should be configured for pull up.
+ $ref: /schemas/types.yaml#/definitions/flag
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ ssbi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@0 {
+ reg = <0x0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pwrkey@1c {
+ compatible = "qcom,pm8921-pwrkey";
+ reg = <0x1c>;
+ interrupt-parent = <&pmicint>;
+ interrupts = <50 IRQ_TYPE_EDGE_RISING>, <51 IRQ_TYPE_EDGE_RISING>;
+ debounce = <15625>;
+ pull-up;
+ };
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
deleted file mode 100644
index 588536cc96ed..000000000000
--- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
+++ /dev/null
@@ -1,46 +0,0 @@
-Qualcomm PM8xxx PMIC Power Key
-
-PROPERTIES
-
-- compatible:
- Usage: required
- Value type: <string>
- Definition: must be one of:
- "qcom,pm8058-pwrkey"
- "qcom,pm8921-pwrkey"
-
-- reg:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: address of power key control register
-
-- interrupts:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: the first interrupt specifies the key release interrupt
- and the second interrupt specifies the key press interrupt.
- The format of the specifier is defined by the binding
- document describing the node's interrupt parent.
-
-- debounce:
- Usage: optional
- Value type: <u32>
- Definition: time in microseconds that key must be pressed or release
- for state change interrupt to trigger.
-
-- pull-up:
- Usage: optional
- Value type: <empty>
- Definition: presence of this property indicates that the KPDPWR_N pin
- should be configured for pull up.
-
-EXAMPLE
-
- pwrkey@1c {
- compatible = "qcom,pm8921-pwrkey";
- reg = <0x1c>;
- interrupt-parent = <&pmicintc>;
- interrupts = <50 1>, <51 1>;
- debounce = <15625>;
- pull-up;
- };
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (5 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
` (3 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
The PM8018 RTC is used as compatible with PM8921 RTC on the MDM9615,
document this situation.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
index 23ab5bb4f395..0a7aa29563c1 100644
--- a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
@@ -11,12 +11,16 @@ maintainers:
properties:
compatible:
- enum:
- - qcom,pm8058-rtc
- - qcom,pm8921-rtc
- - qcom,pm8941-rtc
- - qcom,pm8018-rtc
- - qcom,pmk8350-rtc
+ oneOf:
+ - enum:
+ - qcom,pm8058-rtc
+ - qcom,pm8921-rtc
+ - qcom,pm8941-rtc
+ - qcom,pmk8350-rtc
+ - items:
+ - enum:
+ - qcom,pm8018-rtc
+ - const: qcom,pm8921-rtc
reg:
minItems: 1
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (6 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
` (2 subsequent siblings)
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
The PM8018 compatible is always used with PM8921 fallback, so PM8018
compatible can be safely removed from device ID table
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/mfd/qcom-pm8xxx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
index 2f2734ba5273..601106580e2e 100644
--- a/drivers/mfd/qcom-pm8xxx.c
+++ b/drivers/mfd/qcom-pm8xxx.c
@@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = {
};
static const struct of_device_id pm8xxx_id_table[] = {
- { .compatible = "qcom,pm8018", .data = &pm8xxx_data},
{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
{ .compatible = "qcom,pm8821", .data = &pm8821_data},
{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 09/11] rtc: pm8xxx: drop unused pm8018 compatible
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (7 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 13:18 ` Alexandre Belloni
2022-10-17 9:45 ` [PATCH v3 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
10 siblings, 1 reply; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
The PM8018 compatible is always used with PM8921 fallback, so PM8018
compatible can be safely removed from device ID table
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/rtc/rtc-pm8xxx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index dc6d1476baa5..716e5d9ad74d 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -461,7 +461,6 @@ static const struct pm8xxx_rtc_regs pmk8350_regs = {
*/
static const struct of_device_id pm8xxx_id_table[] = {
{ .compatible = "qcom,pm8921-rtc", .data = &pm8921_regs },
- { .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
{ .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
{ .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
{ .compatible = "qcom,pmk8350-rtc", .data = &pmk8350_regs },
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (8 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
This solves the 'interrupt-names' was unexpected dtbs check error.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/qcom-mdm9615.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index 366241dee522..9d950f96280d 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -325,7 +325,6 @@ sdcc1: mmc@12180000 {
arm,primecell-periphid = <0x00051180>;
reg = <0x12180000 0x2000>;
interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "cmd_irq";
clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
clock-names = "mclk", "apb_pclk";
bus-width = <8>;
@@ -345,7 +344,6 @@ sdcc2: mmc@12140000 {
status = "disabled";
reg = <0x12140000 0x2000>;
interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "cmd_irq";
clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
clock-names = "mclk", "apb_pclk";
bus-width = <4>;
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
` (9 preceding siblings ...)
2022-10-17 9:45 ` [PATCH v3 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
@ 2022-10-17 9:45 ` Neil Armstrong
10 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2022-10-17 9:45 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Rob Herring, Satya Priya,
Lee Jones, Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, Neil Armstrong, linux-kernel, Bjorn Andersson,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
The separate amba device node doesn't add anything significant to the
DT. The OF parsing code already creates amba_device or platform_device
depending on the compatibility lists.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm/boot/dts/qcom-mdm9615.dtsi | 78 +++++++++++++++++--------------------
1 file changed, 36 insertions(+), 42 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index 9d950f96280d..482fd246321c 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -314,49 +314,43 @@ sdcc2bam: dma-controller@12142000{
qcom,ee = <0>;
};
- amba {
- compatible = "simple-bus";
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
- sdcc1: mmc@12180000 {
- status = "disabled";
- compatible = "arm,pl18x", "arm,primecell";
- arm,primecell-periphid = <0x00051180>;
- reg = <0x12180000 0x2000>;
- interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
- clock-names = "mclk", "apb_pclk";
- bus-width = <8>;
- max-frequency = <48000000>;
- cap-sd-highspeed;
- cap-mmc-highspeed;
- vmmc-supply = <&vsdcc_fixed>;
- dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
- dma-names = "tx", "rx";
- assigned-clocks = <&gcc SDC1_CLK>;
- assigned-clock-rates = <400000>;
- };
+ sdcc1: mmc@12180000 {
+ status = "disabled";
+ compatible = "arm,pl18x", "arm,primecell";
+ arm,primecell-periphid = <0x00051180>;
+ reg = <0x12180000 0x2000>;
+ interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
+ clock-names = "mclk", "apb_pclk";
+ bus-width = <8>;
+ max-frequency = <48000000>;
+ cap-sd-highspeed;
+ cap-mmc-highspeed;
+ vmmc-supply = <&vsdcc_fixed>;
+ dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
+ dma-names = "tx", "rx";
+ assigned-clocks = <&gcc SDC1_CLK>;
+ assigned-clock-rates = <400000>;
+ };
- sdcc2: mmc@12140000 {
- compatible = "arm,pl18x", "arm,primecell";
- arm,primecell-periphid = <0x00051180>;
- status = "disabled";
- reg = <0x12140000 0x2000>;
- interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
- clock-names = "mclk", "apb_pclk";
- bus-width = <4>;
- cap-sd-highspeed;
- cap-mmc-highspeed;
- max-frequency = <48000000>;
- no-1-8-v;
- vmmc-supply = <&vsdcc_fixed>;
- dmas = <&sdcc2bam 2>, <&sdcc2bam 1>;
- dma-names = "tx", "rx";
- assigned-clocks = <&gcc SDC2_CLK>;
- assigned-clock-rates = <400000>;
- };
+ sdcc2: mmc@12140000 {
+ compatible = "arm,pl18x", "arm,primecell";
+ arm,primecell-periphid = <0x00051180>;
+ status = "disabled";
+ reg = <0x12140000 0x2000>;
+ interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
+ clock-names = "mclk", "apb_pclk";
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cap-mmc-highspeed;
+ max-frequency = <48000000>;
+ no-1-8-v;
+ vmmc-supply = <&vsdcc_fixed>;
+ dmas = <&sdcc2bam 2>, <&sdcc2bam 1>;
+ dma-names = "tx", "rx";
+ assigned-clocks = <&gcc SDC2_CLK>;
+ assigned-clock-rates = <400000>;
};
tcsr: syscon@1a400000 {
--
b4 0.10.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v3 09/11] rtc: pm8xxx: drop unused pm8018 compatible
2022-10-17 9:45 ` [PATCH v3 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
@ 2022-10-17 13:18 ` Alexandre Belloni
0 siblings, 0 replies; 16+ messages in thread
From: Alexandre Belloni @ 2022-10-17 13:18 UTC (permalink / raw)
To: Neil Armstrong
Cc: Alessandro Zummo, Rob Herring, Satya Priya, Lee Jones,
Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio, linux-rtc, linux-kernel,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
On 17/10/2022 11:45:34+0200, Neil Armstrong wrote:
> The PM8018 compatible is always used with PM8921 fallback, so PM8018
> compatible can be safely removed from device ID table
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-pm8xxx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index dc6d1476baa5..716e5d9ad74d 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -461,7 +461,6 @@ static const struct pm8xxx_rtc_regs pmk8350_regs = {
> */
> static const struct of_device_id pm8xxx_id_table[] = {
> { .compatible = "qcom,pm8921-rtc", .data = &pm8921_regs },
> - { .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
> { .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
> { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
> { .compatible = "qcom,pmk8350-rtc", .data = &pmk8350_regs },
>
> --
> b4 0.10.1
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018
2022-10-17 9:45 ` [PATCH v3 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
@ 2022-10-17 18:59 ` Rob Herring
0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2022-10-17 18:59 UTC (permalink / raw)
To: Neil Armstrong
Cc: Konrad Dybcio, devicetree, Krzysztof Kozlowski, linux-kernel,
Alexandre Belloni, Rob Herring, linux-arm-msm, linux-input,
Satya Priya, Bjorn Andersson, Alessandro Zummo, Andy Gross,
Dmitry Torokhov, Lee Jones, linux-rtc, Krzysztof Kozlowski
On Mon, 17 Oct 2022 11:45:30 +0200, Neil Armstrong wrote:
> The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation,
> and an example section to validate this change.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 33 ++++++++++++++++++----
> 1 file changed, 28 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
2022-10-17 9:45 ` [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
@ 2022-10-17 19:01 ` Rob Herring
2022-10-17 22:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring @ 2022-10-17 19:01 UTC (permalink / raw)
To: Neil Armstrong
Cc: Alessandro Zummo, Alexandre Belloni, Satya Priya, Lee Jones,
Krzysztof Kozlowski, Andy Gross, Dmitry Torokhov,
Bjorn Andersson, Konrad Dybcio, linux-rtc, linux-kernel,
linux-arm-msm, devicetree, Krzysztof Kozlowski, linux-input
On Mon, Oct 17, 2022 at 11:45:31AM +0200, Neil Armstrong wrote:
> Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
> the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/input/qcom,pm8921-pwrkey.yaml | 75 ++++++++++++++++++++++
> .../bindings/input/qcom,pm8xxx-pwrkey.txt | 46 -------------
> 2 files changed, 75 insertions(+), 46 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
> new file mode 100644
> index 000000000000..9591f77aa22a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PM8921 PMIC Power Key
> +
> +maintainers:
> + - Bjorn Andersson <andersson@kernel.org>
> +
> +allOf:
> + - $ref: input.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - qcom,pm8921-pwrkey
> + - qcom,pm8058-pwrkey
> + - items:
> + - enum:
> + - qcom,pm8018-pwrkey
> + - const: qcom,pm8921-pwrkey
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: key release
> + - description: key press
> +
> + debounce:
> + description: |
> + Time in microseconds that key must be pressed or
> + released for state change interrupt to trigger.
Don't need '|' and use standard indentation of 2 chars.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pull-up:
> + description: |
> + Presence of this property indicates that the KPDPWR_N
> + pin should be configured for pull up.
Ditto.
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema
2022-10-17 9:45 ` [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
2022-10-17 19:01 ` Rob Herring
@ 2022-10-17 22:16 ` Krzysztof Kozlowski
1 sibling, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-17 22:16 UTC (permalink / raw)
To: Neil Armstrong, Alessandro Zummo, Alexandre Belloni, Rob Herring,
Satya Priya, Lee Jones, Krzysztof Kozlowski, Andy Gross,
Dmitry Torokhov, Bjorn Andersson, Konrad Dybcio
Cc: linux-rtc, linux-kernel, linux-arm-msm, devicetree, linux-input
On 17/10/2022 05:45, Neil Armstrong wrote:
> Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
> the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/input/qcom,pm8921-pwrkey.yaml | 75 ++++++++++++++++++++++
> .../bindings/input/qcom,pm8xxx-pwrkey.txt | 46 -------------
> 2 files changed, 75 insertions(+), 46 deletions(-)
Thanks for the changes.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-10-17 22:17 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 9:45 [PATCH v3 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
2022-10-17 18:59 ` Rob Herring
2022-10-17 9:45 ` [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
2022-10-17 19:01 ` Rob Herring
2022-10-17 22:16 ` Krzysztof Kozlowski
2022-10-17 9:45 ` [PATCH v3 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
2022-10-17 13:18 ` Alexandre Belloni
2022-10-17 9:45 ` [PATCH v3 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-17 9:45 ` [PATCH v3 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).