[PATCH v2 0/2] Add dma gpi support for QDU1000/QRU1000 SoCs

[PATCH v2 0/2] Add dma gpi support for QDU1000/QRU1000 SoCs

[Melody Olvera]

This series adds the dt bindings and driver support for dma gpi driver
on the QDU1000 and QRU1000 SoCs.

This patchset is based off of patches found at [1].

The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf

[1] https://lore.kernel.org/all/20220927014846.32892-1-mailingradian@gmail.com/

Melody Olvera (2):
  dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and
    QRU1000
  dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

 Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
 drivers/dma/qcom/gpi.c                              | 2 ++
 2 files changed, 4 insertions(+)


base-commit: dca0a0385a4963145593ba417e1417af88a7c18d
prerequisite-patch-id: 3fbdc40584bde724063f88038e6e5178413fa9ce
prerequisite-patch-id: 7df51dc9dfa16d11f910c5142513ca7e43e5c4d4
prerequisite-patch-id: cb57181838cf718e80f2e07b290ffaf67b5acbc9
prerequisite-patch-id: efc95efd7a81f8bc65dc188f5d7c75769340dbe7
-- 
2.38.0

[PATCH v2 1/2] dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

[Melody Olvera]

Add compatible documentation for Qualcomm QDU1000 and QRU1000 SoCs.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index 750b40c32213..8c52ea5525c7 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -20,6 +20,8 @@ properties:
   compatible:
     oneOf:
       - enum:
+          - qcom,qdu1000-gpi-dma
+          - qcom,qru1000-gpi-dma
           - qcom,sc7280-gpi-dma
           - qcom,sdm845-gpi-dma
           - qcom,sm6350-gpi-dma
-- 
2.38.0

[PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

[Melody Olvera]

Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 drivers/dma/qcom/gpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index cc938a31dc2d..02438735e92b 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id gpi_of_match[] = {
+	{ .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
+	{ .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
 	{ .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
 	{ .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
-- 
2.38.0

Re: [PATCH v2 0/2] Add dma gpi support for QDU1000/QRU1000 SoCs

[Melody Olvera]

On 10/14/2022 3:11 PM, Melody Olvera wrote:
> This series adds the dt bindings and driver support for dma gpi driver
> on the QDU1000 and QRU1000 SoCs.
>
> This patchset is based off of patches found at [1].
>
> The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
> 1000 are new SoCs meant for enabling Open RAN solutions. See more at
> https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
>
> [1] https://lore.kernel.org/all/20220927014846.32892-1-mailingradian@gmail.com/
Changes from v1:
- fixed ordering
- rebased on top of [1]
>
> Melody Olvera (2):
>   dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and
>     QRU1000
>   dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000
>
>  Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
>  drivers/dma/qcom/gpi.c                              | 2 ++
>  2 files changed, 4 insertions(+)
>
>
> base-commit: dca0a0385a4963145593ba417e1417af88a7c18d
> prerequisite-patch-id: 3fbdc40584bde724063f88038e6e5178413fa9ce
> prerequisite-patch-id: 7df51dc9dfa16d11f910c5142513ca7e43e5c4d4
> prerequisite-patch-id: cb57181838cf718e80f2e07b290ffaf67b5acbc9
> prerequisite-patch-id: efc95efd7a81f8bc65dc188f5d7c75769340dbe7

Re: [PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

[Krzysztof Kozlowski]

On 14/10/2022 18:11, Melody Olvera wrote:
> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  drivers/dma/qcom/gpi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index cc938a31dc2d..02438735e92b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id gpi_of_match[] = {
> +	{ .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
> +	{ .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },

The feedback was: drop entire patch.

There is really no need for this pattern to keep growing.

Best regards,
Krzysztof

Re: [PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

[Vinod Koul]

On 15-10-22, 09:42, Krzysztof Kozlowski wrote:
> On 14/10/2022 18:11, Melody Olvera wrote:
> > Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
> > 
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> > ---
> >  drivers/dma/qcom/gpi.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > index cc938a31dc2d..02438735e92b 100644
> > --- a/drivers/dma/qcom/gpi.c
> > +++ b/drivers/dma/qcom/gpi.c
> > @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev)
> >  }
> >  
> >  static const struct of_device_id gpi_of_match[] = {
> > +	{ .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
> > +	{ .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
> 
> The feedback was: drop entire patch.
> 
> There is really no need for this pattern to keep growing.

Right, I have picked the patches so you dont need to add yours to driver
file, please check dmaengine/next

-- 
~Vinod

Re: [PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

[Melody Olvera]

On 10/19/2022 6:30 AM, Vinod Koul wrote:
> On 15-10-22, 09:42, Krzysztof Kozlowski wrote:
>> On 14/10/2022 18:11, Melody Olvera wrote:
>>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>>  drivers/dma/qcom/gpi.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>>> index cc938a31dc2d..02438735e92b 100644
>>> --- a/drivers/dma/qcom/gpi.c
>>> +++ b/drivers/dma/qcom/gpi.c
>>> @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev)
>>>  }
>>>  
>>>  static const struct of_device_id gpi_of_match[] = {
>>> +	{ .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>>> +	{ .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
>> The feedback was: drop entire patch.
>>
>> There is really no need for this pattern to keep growing.
> Right, I have picked the patches so you dont need to add yours to driver
> file, please check dmaengine/next
>
Yes, I think I understand now; I'll just use existing compatibles and drop this PS.

Thanks,
Melody