From: Marijn Suijten <marijn.suijten@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral
Date: Wed, 14 Dec 2022 21:39:02 +0100 [thread overview]
Message-ID: <20221214203902.jilmsvf3bhg2kwqf@SoMainline.org> (raw)
In-Reply-To: <cd23d45c-f0a0-d81f-5230-a7de2bb90c07@linaro.org>
On 2022-12-11 21:11:51, Krzysztof Kozlowski wrote:
> On 10/12/2022 17:31, Marijn Suijten wrote:
> > [..]
> > If we were able to have rules for labels, would I then be allowed to
> > "correct" this?
>
> If we had rules, yes. But we do not have. That's like - I will rename
> all variables because of some non-existing rules... There is no rule, no
> coding style (except what I wrote)...
>
> > The inconsistency between DTs is /super/ annoying (and
> > it looks wrong to have a singular _gpio named thing contain /multiple
> > gpios/),
>
> What do you mean - looks wrong? It's just a label which does not matter,
> so how it can be wrong?
>
> > but just because we can't express this in dt-bindings (or so I
> > think) we shouldn't change it?
>
> No, it just does not matter, so there is no benefit to change it, in my
> opinion, if label is readable and follows generic convention
> (underscores). Of course someone might treat its readability different
> and maybe for someone the missing "s" at the end is important.
That must be me.
> I am just
> saying that, unlike the node names, the label has little impact/effect.
>
> However just be clear - this change also does not harm, so I am
> perfectly fine with it.
Okay, I'd prefer to have it :)
- Marijn
next prev parent reply other threads:[~2022-12-14 20:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 16:17 [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible Luca Weiss
2022-11-01 16:18 ` [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral Luca Weiss
2022-11-04 23:44 ` Marijn Suijten
2022-11-06 19:37 ` Marijn Suijten
2022-12-02 9:36 ` Marijn Suijten
2022-12-04 16:19 ` Luca Weiss
2022-12-08 10:12 ` Marijn Suijten
2022-12-08 10:23 ` Krzysztof Kozlowski
2022-12-08 11:20 ` Marijn Suijten
2022-12-09 16:54 ` Luca Weiss
2022-12-09 20:38 ` Marijn Suijten
2022-12-10 10:58 ` Krzysztof Kozlowski
2022-12-10 16:31 ` Marijn Suijten
2022-12-11 20:11 ` Krzysztof Kozlowski
2022-12-14 20:39 ` Marijn Suijten [this message]
2022-11-02 13:55 ` [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible Daniel Thompson
2022-11-02 17:29 ` Rob Herring
2022-11-07 9:19 ` Lee Jones
2022-12-06 18:19 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214203902.jilmsvf3bhg2kwqf@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kholk11@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).