* [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible
@ 2023-02-14 9:08 Konrad Dybcio
2023-02-14 9:08 ` [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Konrad Dybcio @ 2023-02-14 9:08 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Krzysztof Kozlowski,
Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
Add a specific compatible for the coincell charger present on PM8998.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Pick up ab
.../bindings/power/supply/qcom,pm8941-coincell.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index 0450f4dd4e51..b7b58aed3f3c 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -16,7 +16,13 @@ maintainers:
properties:
compatible:
- const: qcom,pm8941-coincell
+ oneOf:
+ - items:
+ - enum:
+ - qcom,pm8998-coincell
+ - const: qcom,pm8941-coincell
+
+ - const: qcom,pm8941-coincell
reg:
maxItems: 1
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-14 9:08 [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
@ 2023-02-14 9:08 ` Konrad Dybcio
2023-02-15 19:04 ` Krzysztof Kozlowski
2023-02-14 9:08 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Konrad Dybcio @ 2023-02-14 9:08 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Krzysztof Kozlowski,
Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
It's fine for these properties to be absent, as the driver doesn't fail
without them and functions with settings inherited from the reset/previous
stage bootloader state.
Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Describe the behaviour when the properties are absent
.../bindings/power/supply/qcom,pm8941-coincell.yaml | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index b7b58aed3f3c..1d2405bea109 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -28,12 +28,18 @@ properties:
maxItems: 1
qcom,rset-ohms:
- description: resistance (in ohms) for current-limiting resistor
+ description: |
+ Resistance (in ohms) for current-limiting resistor. If unspecified,
+ inherit the previous configuration (e.g. from bootloader or hardware
+ default value).
enum: [ 800, 1200, 1700, 2100 ]
qcom,vset-millivolts:
$ref: /schemas/types.yaml#/definitions/uint32
- description: voltage (in millivolts) to apply for charging
+ description: |
+ Voltage (in millivolts) to apply for charging. If unspecified, inherit
+ the previous configuration (e.g. from bootloader or hardware default
+ value).
enum: [ 2500, 3000, 3100, 3200 ]
qcom,charger-disable:
@@ -43,8 +49,6 @@ properties:
required:
- compatible
- reg
- - qcom,rset-ohms
- - qcom,vset-millivolts
additionalProperties: false
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg
2023-02-14 9:08 [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-14 9:08 ` [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
@ 2023-02-14 9:08 ` Konrad Dybcio
2023-02-14 11:40 ` Marijn Suijten
2023-02-16 0:06 ` [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Sebastian Reichel
2023-03-15 23:35 ` (subset) " Bjorn Andersson
3 siblings, 1 reply; 8+ messages in thread
From: Konrad Dybcio @ 2023-02-14 9:08 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Krzysztof Kozlowski,
Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
Add a PM8998-specific compatibel to the coincell charger and keep the
PM8941 one as fallback.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
No changes
arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index adbba9f4089a..340033ac3186 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -72,7 +72,7 @@ pm8998_temp: temp-alarm@2400 {
};
pm8998_coincell: charger@2800 {
- compatible = "qcom,pm8941-coincell";
+ compatible = "qcom,pm8998-coincell", "qcom,pm8941-coincell";
reg = <0x2800>;
status = "disabled";
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg
2023-02-14 9:08 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
@ 2023-02-14 11:40 ` Marijn Suijten
0 siblings, 0 replies; 8+ messages in thread
From: Marijn Suijten @ 2023-02-14 11:40 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, Krzysztof Kozlowski,
Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
On 2023-02-14 10:08:49, Konrad Dybcio wrote:
> Add a PM8998-specific compatibel to the coincell charger and keep the
I know you've been taking Dutch lessons, compatibel is a Dutch word :)
> PM8941 one as fallback.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> v1 -> v2:
>
> No changes
>
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index adbba9f4089a..340033ac3186 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -72,7 +72,7 @@ pm8998_temp: temp-alarm@2400 {
> };
>
> pm8998_coincell: charger@2800 {
> - compatible = "qcom,pm8941-coincell";
> + compatible = "qcom,pm8998-coincell", "qcom,pm8941-coincell";
> reg = <0x2800>;
>
> status = "disabled";
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-14 9:08 ` [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
@ 2023-02-15 19:04 ` Krzysztof Kozlowski
2023-02-16 0:06 ` Sebastian Reichel
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-15 19:04 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross
Cc: marijn.suijten, Sebastian Reichel, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
On 14/02/2023 10:08, Konrad Dybcio wrote:
> It's fine for these properties to be absent, as the driver doesn't fail
> without them and functions with settings inherited from the reset/previous
> stage bootloader state.
>
> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible
2023-02-14 9:08 [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-14 9:08 ` [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
2023-02-14 9:08 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
@ 2023-02-16 0:06 ` Sebastian Reichel
2023-03-15 23:35 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2023-02-16 0:06 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, marijn.suijten,
Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]
Hi,
On Tue, Feb 14, 2023 at 10:08:47AM +0100, Konrad Dybcio wrote:
> Add a specific compatible for the coincell charger present on PM8998.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Thanks, queued.
-- Sebastian
> v1 -> v2:
>
> - Pick up ab
>
> .../bindings/power/supply/qcom,pm8941-coincell.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> index 0450f4dd4e51..b7b58aed3f3c 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> @@ -16,7 +16,13 @@ maintainers:
>
> properties:
> compatible:
> - const: qcom,pm8941-coincell
> + oneOf:
> + - items:
> + - enum:
> + - qcom,pm8998-coincell
> + - const: qcom,pm8941-coincell
> +
> + - const: qcom,pm8941-coincell
>
> reg:
> maxItems: 1
> --
> 2.39.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-15 19:04 ` Krzysztof Kozlowski
@ 2023-02-16 0:06 ` Sebastian Reichel
0 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2023-02-16 0:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Konrad Dybcio, linux-arm-msm, andersson, agross, marijn.suijten,
Rob Herring, Krzysztof Kozlowski, linux-pm, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
Hi,
On Wed, Feb 15, 2023 at 08:04:00PM +0100, Krzysztof Kozlowski wrote:
> On 14/02/2023 10:08, Konrad Dybcio wrote:
> > It's fine for these properties to be absent, as the driver doesn't fail
> > without them and functions with settings inherited from the reset/previous
> > stage bootloader state.
> >
> > Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible
2023-02-14 9:08 [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
` (2 preceding siblings ...)
2023-02-16 0:06 ` [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Sebastian Reichel
@ 2023-03-15 23:35 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2023-03-15 23:35 UTC (permalink / raw)
To: agross, linux-arm-msm, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Krzysztof Kozlowski, linux-pm,
marijn.suijten, devicetree, linux-kernel, Sebastian Reichel
On Tue, 14 Feb 2023 10:08:47 +0100, Konrad Dybcio wrote:
> Add a specific compatible for the coincell charger present on PM8998.
>
>
Applied, thanks!
[3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg
commit: 0d589dc92fca4679186a949194fc7c452d37c575
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-15 23:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-14 9:08 [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-14 9:08 ` [PATCH v2 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
2023-02-15 19:04 ` Krzysztof Kozlowski
2023-02-16 0:06 ` Sebastian Reichel
2023-02-14 9:08 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
2023-02-14 11:40 ` Marijn Suijten
2023-02-16 0:06 ` [PATCH v2 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Sebastian Reichel
2023-03-15 23:35 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).