* [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks
@ 2023-03-22 17:35 Krzysztof Kozlowski
2023-03-22 17:35 ` [PATCH v3 2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match Krzysztof Kozlowski
2023-03-24 18:34 ` (subset) [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-22 17:35 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Jassi Brar,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, devicetree
Cc: Krzysztof Kozlowski, Rob Herring
SDX55 and SDX65 DTS takes clocks in a bit different order. Adjust
bindings to the DTS.
Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
---
Changes since v1:
1. Add Fixes tag
2. Add Acks
3. Split from other patchset, so it can be applied independently
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index d888ead09282..2992227631c4 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -97,14 +97,14 @@ allOf:
properties:
clocks:
items:
+ - description: reference clock
- description: primary pll parent of the clock driver
- description: auxiliary parent
- - description: reference clock
clock-names:
items:
+ - const: ref
- const: pll
- const: aux
- - const: ref
- if:
properties:
compatible:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match
2023-03-22 17:35 [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks Krzysztof Kozlowski
@ 2023-03-22 17:35 ` Krzysztof Kozlowski
2023-03-24 18:34 ` (subset) [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-22 17:35 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Jassi Brar,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, devicetree
Cc: Krzysztof Kozlowski, Rob Herring
The qcom,sdx55-apcs-gcc is followed by another compatible (syscon), thus
the 'if' clause must match by contains.
Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
---
Changes since v1:
1. Add Acks
2. Split from other patchset, so it can be applied independently
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 2992227631c4..4d2f408a5efb 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -91,8 +91,9 @@ allOf:
- if:
properties:
compatible:
- enum:
- - qcom,sdx55-apcs-gcc
+ contains:
+ enum:
+ - qcom,sdx55-apcs-gcc
then:
properties:
clocks:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks
2023-03-22 17:35 [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks Krzysztof Kozlowski
2023-03-22 17:35 ` [PATCH v3 2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match Krzysztof Kozlowski
@ 2023-03-24 18:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-03-24 18:34 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, linux-kernel, Krzysztof Kozlowski,
devicetree, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Jassi Brar, Andy Gross
Cc: Rob Herring
On Wed, 22 Mar 2023 18:35:58 +0100, Krzysztof Kozlowski wrote:
> SDX55 and SDX65 DTS takes clocks in a bit different order. Adjust
> bindings to the DTS.
>
>
Applied, thanks!
[1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks
commit: 8504fa9baf8bdc5f333f24077b54df1d16173d99
[2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match
commit: 22ead09ba40745e50970565af1996c2c1cc4e909
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-24 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 17:35 [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks Krzysztof Kozlowski
2023-03-22 17:35 ` [PATCH v3 2/2] dt-bindings: mailbox: qcom,apcs-kpss-global: fix SDX55 'if' match Krzysztof Kozlowski
2023-03-24 18:34 ` (subset) [PATCH v3 1/2] dt-bindings: mailbox: qcom,apcs-kpss-global: correct SDX55 clocks Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).