From: Marijn Suijten <marijn.suijten@somainline.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Caleb Connolly <caleb@connolly.tech>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: [PATCH RFC 00/10] drm/panel: Drivers for four Sony CMD-mode (and DSC) panels
Date: Sun, 21 May 2023 23:23:02 +0200 [thread overview]
Message-ID: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> (raw)
Sending in a bunch of almost-finished (hence RFC) Sony panel drivers
upon drm/msm request, to further discussions around DSC panels and DSI
pclk calculations. This brings support for the following Sony Xperia
devices:
- Xperia XZ3 (DSC)
- Xperia 1 (DSC)
- Xperia 5
- Xperia 10 II (shared with Xperia 5)
- Xperia 5 II (DSC, 120Hz)
And, since the XZ3 already has all the DT in place to enable the panels
on its smaller XZ2(c) siblings, an extra patch is included to add the
new compatible string and properties to this device .dts. DTS for other
boards/platforms will come later, after cleaning up preliminary patches
(e.g. DPU catalog additions, SoC/board DTS for the MDSS subsystem, etc).
- File- and compatible names:
None of my downstream sources describe the product name of the panels
used here; in few cases the Display-IC is known but for the Xperia XZ3
Xperia 1 we have to make-do with a vendor name only.
Naming suggestions definitely welcome; i.e. I'm especially not fond of
sony-griffin-samsung.c :)
- Panels/drivers featuring multiple modes
As brought up earlier in #freedreno drm_panel drivers can provide
multiple modes, but the selected mode is never communicated back to
the panel. This either has to be added to the driver, or the drivers
in question have to be converted to drm_bridges (suggestion from
#freedreno). That should allow us to select a mode at runtime, and
downstream even defines "fast paths" to switch from one mode to the
next (e.g. when only adjusting the refresh rate) without powering the
panel off and on again, which we can hopefully support too.
For now the choice between either mode has been hardcoded behind a
static const bool.
- DSC
Not much to discuss here except that "it works" after piecing together
various series on the lists. No dependencies to make this series
apply/compile, though.
- pclk
The brunt of the discussion is around getting these command mode
panels functioning at their desired 60Hz or 120Hz refresh rate without
tearing/artifacts, and without hacks. Part of that discussion around
DSC-specific timing adjustments is happening in [1], but the sofef01
(non-DSC) Driver-IC is also struggling on the Xperia 5 specifically,
as outlined in that specific patch. That is currently "addressed"
with a "porch hack" but should probably have some sort of overhead /
transfer time taken into account in the MSM DSI driver.
Let me know what the best place is to collate all the relevant info
(links to downstream panel DTS, outcomes with different patches and
tweaks, etc). A new fd.o drm/msm issue?
[1]: https://gitlab.freedesktop.org/drm/msm/-/issues/24#note_1917707
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
Marijn Suijten (10):
drm/panel: Clean up SOFEF00 config dependencies
dt-bindings: display: panel: Describe Sony Xperia XZ3's LGD panel
drm/panel: Add LGD panel driver for Sony Xperia XZ3
arm64: dts: qcom: sdm845-akatsuki: Configure OLED panel
dt-bindings: display: panel: Describe Samsung SOFEF01-M Display-IC
drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II
dt-bindings: display: panel: Describe Samsung SOFEF03-M Display-IC
drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II
dt-bindings: display: panel: Describe Sony Xperia 1 display
drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1
.../bindings/display/panel/samsung,sofef01-m.yaml | 109 ++++++
.../bindings/display/panel/samsung,sofef03-m.yaml | 73 ++++
.../bindings/display/panel/sony,akatsuki-lgd.yaml | 71 ++++
.../display/panel/sony,griffin-samsung.yaml | 73 ++++
.../dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts | 9 +
drivers/gpu/drm/panel/Kconfig | 52 ++-
drivers/gpu/drm/panel/Makefile | 4 +
drivers/gpu/drm/panel/panel-samsung-sofef01.c | 360 ++++++++++++++++++
drivers/gpu/drm/panel/panel-samsung-sofef03.c | 423 +++++++++++++++++++++
drivers/gpu/drm/panel/panel-sony-akatsuki-lgd.c | 362 ++++++++++++++++++
drivers/gpu/drm/panel/panel-sony-griffin-samsung.c | 410 ++++++++++++++++++++
11 files changed, 1945 insertions(+), 1 deletion(-)
---
base-commit: dbd91ef4e91c1ce3a24429f5fb3876b7a0306733
change-id: 20230521-drm-panels-sony-3c5ac3218427
Best regards,
--
Marijn Suijten <marijn.suijten@somainline.org>
next reply other threads:[~2023-05-21 21:23 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 21:23 Marijn Suijten [this message]
2023-05-21 21:23 ` [PATCH RFC 01/10] drm/panel: Clean up SOFEF00 config dependencies Marijn Suijten
2023-05-22 9:01 ` Neil Armstrong
2023-05-28 22:00 ` Caleb Connolly
2023-05-21 21:23 ` [PATCH RFC 02/10] dt-bindings: display: panel: Describe Sony Xperia XZ3's LGD panel Marijn Suijten
2023-05-22 0:10 ` Dmitry Baryshkov
2023-05-21 21:23 ` [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3 Marijn Suijten
2023-05-22 1:16 ` Dmitry Baryshkov
2023-05-22 9:04 ` Neil Armstrong
2023-05-22 12:58 ` Dmitry Baryshkov
2023-05-29 21:07 ` Marijn Suijten
2023-05-29 22:18 ` Dmitry Baryshkov
2023-05-29 22:37 ` Marijn Suijten
2023-05-29 22:39 ` Dmitry Baryshkov
2023-05-30 8:27 ` Marijn Suijten
2023-05-30 11:11 ` Dmitry Baryshkov
2023-05-30 18:19 ` Marijn Suijten
2023-05-30 17:54 ` Abhinav Kumar
2023-05-30 18:13 ` Marijn Suijten
2023-05-30 23:16 ` Dmitry Baryshkov
2023-05-29 21:11 ` Marijn Suijten
2023-05-29 22:17 ` Dmitry Baryshkov
2023-05-29 22:36 ` Dmitry Baryshkov
2023-05-30 7:24 ` Neil Armstrong
2023-05-30 8:41 ` Marijn Suijten
2023-05-30 9:29 ` Konrad Dybcio
2023-05-30 11:44 ` RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3) Dmitry Baryshkov
2023-05-30 12:15 ` AngeloGioacchino Del Regno
2023-05-30 12:36 ` Dmitry Baryshkov
2023-05-30 15:44 ` Neil Armstrong
2023-05-31 8:02 ` AngeloGioacchino Del Regno
2023-07-05 12:04 ` Maxime Ripard
2023-07-05 13:05 ` Neil Armstrong
2023-07-05 13:29 ` Maxime Ripard
2023-07-05 13:37 ` Dmitry Baryshkov
2023-07-05 14:24 ` Maxime Ripard
2023-07-05 15:20 ` Dmitry Baryshkov
2023-07-05 16:53 ` Maxime Ripard
2023-07-05 20:09 ` Dmitry Baryshkov
2023-07-06 7:24 ` Maxime Ripard
2023-07-06 7:33 ` Neil Armstrong
2023-07-06 7:59 ` Maxime Ripard
2023-07-06 8:03 ` Neil Armstrong
2023-07-05 15:58 ` Neil Armstrong
2023-05-21 21:23 ` [PATCH RFC 04/10] arm64: dts: qcom: sdm845-akatsuki: Configure OLED panel Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 05/10] dt-bindings: display: panel: Describe Samsung SOFEF01-M Display-IC Marijn Suijten
2023-05-21 22:23 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II Marijn Suijten
2023-05-22 1:19 ` Dmitry Baryshkov
2023-05-22 16:30 ` Konrad Dybcio
2023-05-22 22:38 ` Marijn Suijten
2023-05-22 22:32 ` Marijn Suijten
2023-05-22 22:56 ` Dmitry Baryshkov
2023-05-29 20:58 ` Marijn Suijten
2023-05-29 22:20 ` Dmitry Baryshkov
2023-05-29 22:35 ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 07/10] dt-bindings: display: panel: Describe Samsung SOFEF03-M Display-IC Marijn Suijten
2023-06-08 19:43 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 08/10] drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II Marijn Suijten
2023-05-22 1:23 ` Dmitry Baryshkov
2023-05-22 9:08 ` Neil Armstrong
2023-05-22 12:57 ` Dmitry Baryshkov
2023-05-29 21:21 ` Marijn Suijten
2023-05-29 21:29 ` Konrad Dybcio
2023-05-29 22:22 ` Dmitry Baryshkov
2023-05-29 22:33 ` Marijn Suijten
2023-05-22 16:31 ` Konrad Dybcio
2023-05-21 21:23 ` [PATCH RFC 09/10] dt-bindings: display: panel: Describe Sony Xperia 1 display Marijn Suijten
2023-05-21 22:23 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 Marijn Suijten
2023-06-28 9:22 ` Linus Walleij
2023-06-28 14:20 ` Marijn Suijten
2023-06-28 19:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=caleb@connolly.tech \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).