From: Caleb Connolly <caleb@connolly.tech>
To: Marijn Suijten <marijn.suijten@somainline.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Jessica Zhang <quic_jesszhan@quicinc.com>
Subject: Re: [PATCH RFC 01/10] drm/panel: Clean up SOFEF00 config dependencies
Date: Sun, 28 May 2023 22:00:47 +0000 [thread overview]
Message-ID: <fca259bd-5047-06bf-2c66-21acc92d22a7@connolly.tech> (raw)
In-Reply-To: <20230521-drm-panels-sony-v1-1-541c341d6bee@somainline.org>
On 21/05/2023 22:23, Marijn Suijten wrote:
> As per the config name this Display IC features a DSI command-mode
> interface (or the command to switch to video mode is not
> known/documented) and does not use any of the video-mode helper
> utilities, hence should not select VIDEOMODE_HELPERS. In addition it
> uses devm_gpiod_get() and related functions from GPIOLIB.
>
> Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
> drivers/gpu/drm/panel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 2b9d6db7860ba..67ef898d133f2 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -608,10 +608,10 @@ config DRM_PANEL_SAMSUNG_S6E8AA0
>
> config DRM_PANEL_SAMSUNG_SOFEF00
> tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels"
> + depends on GPIOLIB
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> - select VIDEOMODE_HELPERS
> help
> Say Y or M here if you want to enable support for the Samsung AMOLED
> command mode panels found in the OnePlus 6/6T smartphones.
>
> --
> 2.40.1
>
--
Kind Regards,
Caleb
next prev parent reply other threads:[~2023-05-28 22:01 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 21:23 [PATCH RFC 00/10] drm/panel: Drivers for four Sony CMD-mode (and DSC) panels Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 01/10] drm/panel: Clean up SOFEF00 config dependencies Marijn Suijten
2023-05-22 9:01 ` Neil Armstrong
2023-05-28 22:00 ` Caleb Connolly [this message]
2023-05-21 21:23 ` [PATCH RFC 02/10] dt-bindings: display: panel: Describe Sony Xperia XZ3's LGD panel Marijn Suijten
2023-05-22 0:10 ` Dmitry Baryshkov
2023-05-21 21:23 ` [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3 Marijn Suijten
2023-05-22 1:16 ` Dmitry Baryshkov
2023-05-22 9:04 ` Neil Armstrong
2023-05-22 12:58 ` Dmitry Baryshkov
2023-05-29 21:07 ` Marijn Suijten
2023-05-29 22:18 ` Dmitry Baryshkov
2023-05-29 22:37 ` Marijn Suijten
2023-05-29 22:39 ` Dmitry Baryshkov
2023-05-30 8:27 ` Marijn Suijten
2023-05-30 11:11 ` Dmitry Baryshkov
2023-05-30 18:19 ` Marijn Suijten
2023-05-30 17:54 ` Abhinav Kumar
2023-05-30 18:13 ` Marijn Suijten
2023-05-30 23:16 ` Dmitry Baryshkov
2023-05-29 21:11 ` Marijn Suijten
2023-05-29 22:17 ` Dmitry Baryshkov
2023-05-29 22:36 ` Dmitry Baryshkov
2023-05-30 7:24 ` Neil Armstrong
2023-05-30 8:41 ` Marijn Suijten
2023-05-30 9:29 ` Konrad Dybcio
2023-05-30 11:44 ` RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3) Dmitry Baryshkov
2023-05-30 12:15 ` AngeloGioacchino Del Regno
2023-05-30 12:36 ` Dmitry Baryshkov
2023-05-30 15:44 ` Neil Armstrong
2023-05-31 8:02 ` AngeloGioacchino Del Regno
2023-07-05 12:04 ` Maxime Ripard
2023-07-05 13:05 ` Neil Armstrong
2023-07-05 13:29 ` Maxime Ripard
2023-07-05 13:37 ` Dmitry Baryshkov
2023-07-05 14:24 ` Maxime Ripard
2023-07-05 15:20 ` Dmitry Baryshkov
2023-07-05 16:53 ` Maxime Ripard
2023-07-05 20:09 ` Dmitry Baryshkov
2023-07-06 7:24 ` Maxime Ripard
2023-07-06 7:33 ` Neil Armstrong
2023-07-06 7:59 ` Maxime Ripard
2023-07-06 8:03 ` Neil Armstrong
2023-07-05 15:58 ` Neil Armstrong
2023-05-21 21:23 ` [PATCH RFC 04/10] arm64: dts: qcom: sdm845-akatsuki: Configure OLED panel Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 05/10] dt-bindings: display: panel: Describe Samsung SOFEF01-M Display-IC Marijn Suijten
2023-05-21 22:23 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II Marijn Suijten
2023-05-22 1:19 ` Dmitry Baryshkov
2023-05-22 16:30 ` Konrad Dybcio
2023-05-22 22:38 ` Marijn Suijten
2023-05-22 22:32 ` Marijn Suijten
2023-05-22 22:56 ` Dmitry Baryshkov
2023-05-29 20:58 ` Marijn Suijten
2023-05-29 22:20 ` Dmitry Baryshkov
2023-05-29 22:35 ` Marijn Suijten
2023-05-21 21:23 ` [PATCH RFC 07/10] dt-bindings: display: panel: Describe Samsung SOFEF03-M Display-IC Marijn Suijten
2023-06-08 19:43 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 08/10] drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II Marijn Suijten
2023-05-22 1:23 ` Dmitry Baryshkov
2023-05-22 9:08 ` Neil Armstrong
2023-05-22 12:57 ` Dmitry Baryshkov
2023-05-29 21:21 ` Marijn Suijten
2023-05-29 21:29 ` Konrad Dybcio
2023-05-29 22:22 ` Dmitry Baryshkov
2023-05-29 22:33 ` Marijn Suijten
2023-05-22 16:31 ` Konrad Dybcio
2023-05-21 21:23 ` [PATCH RFC 09/10] dt-bindings: display: panel: Describe Sony Xperia 1 display Marijn Suijten
2023-05-21 22:23 ` Rob Herring
2023-05-21 21:23 ` [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 Marijn Suijten
2023-06-28 9:22 ` Linus Walleij
2023-06-28 14:20 ` Marijn Suijten
2023-06-28 19:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fca259bd-5047-06bf-2c66-21acc92d22a7@connolly.tech \
--to=caleb@connolly.tech \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).