linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/7] random msm bindings fixes
@ 2023-06-26 20:00 Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro" Konrad Dybcio
                   ` (9 more replies)
  0 siblings, 10 replies; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (7):
      dt-bindings: qcom: Allow SoC names ending in "pro"
      dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
      arm64: dts: qcom: pm6150l: Add missing short interrupt
      arm64: dts: qcom: pm660l: Add missing short interrupt
      arm64: dts: qcom: pmi8950: Add missing OVP interrupt
      arm64: dts: qcom: pmi8994: Add missing OVP interrupt
      arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3

 Documentation/devicetree/bindings/arm/qcom-soc.yaml                | 2 +-
 .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml       | 7 +++----
 arch/arm64/boot/dts/qcom/pm6150l.dtsi                              | 5 +++--
 arch/arm64/boot/dts/qcom/pm660l.dtsi                               | 5 +++--
 arch/arm64/boot/dts/qcom/pmi8950.dtsi                              | 5 +++--
 arch/arm64/boot/dts/qcom/pmi8994.dtsi                              | 5 +++--
 arch/arm64/boot/dts/qcom/sc8180x.dtsi                              | 1 +
 7 files changed, 17 insertions(+), 13 deletions(-)
---
base-commit: 3eedd211ad93c322fb360b83a3d76a2c6cd622dc
change-id: 20230626-topic-bindingsfixups-93d737dbf054

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro"
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-26 21:27   ` Rob Herring
  2023-06-26 20:00 ` [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks Konrad Dybcio
                   ` (8 subsequent siblings)
  9 siblings, 1 reply; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

There are a couple of SoCs whose names end in "pro", with the currently-
upstream examples being msm8974pro and msm8996pro. Allow such suffix in
SoC-specific compatibles.

Fixes: 5aa332c5e7ca ("dt-bindings: qcom: document preferred compatible naming")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index e333ec4a9c5f..607a1cf1ef94 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -31,7 +31,7 @@ properties:
   compatible:
     oneOf:
       # Preferred naming style for compatibles of SoC components:
-      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$"
+      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+(pro|)-.*$"
       - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
 
       # Legacy namings - variations of existing patterns/compatibles are OK,

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro" Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-26 21:28   ` Rob Herring
  2023-06-26 20:00 ` [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt Konrad Dybcio
                   ` (7 subsequent siblings)
  9 siblings, 1 reply; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Change RPMH to RPM (as RPMh was introduced 2 generations later) and drop
the prng reference, which made ARRAY_SIZE(clocks) !=
ARRAY_SIZE(clock-names).

Fixes: bdea142295ff ("dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml       | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
index c1ac6ca1e759..4e2358fea49e 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
@@ -215,13 +215,12 @@ allOf:
             - description: GCC MSS IFACE clock
             - description: GCC MSS BUS clock
             - description: GCC MSS MEM clock
-            - description: RPMH XO clock
+            - description: RPM XO clock
             - description: GCC MSS GPLL0 clock
             - description: GCC MSS SNOC_AXI clock
             - description: GCC MSS MNOC_AXI clock
-            - description: RPMH PNOC clock
-            - description: GCC MSS PRNG clock
-            - description: RPMH QDSS clock
+            - description: RPM PNOC clock
+            - description: RPM QDSS clock
         clock-names:
           items:
             - const: iface

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro" Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-26 20:17   ` Luca Weiss
  2023-06-26 20:00 ` [PATCH 4/7] arm64: dts: qcom: pm660l: " Konrad Dybcio
                   ` (6 subsequent siblings)
  9 siblings, 1 reply; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Add the missing short interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['ovp'] is too short

Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
index 6a7fe1e59f15..d13a1ab7c20b 100644
--- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
@@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
 		pm6150l_wled: leds@d800 {
 			compatible = "qcom,pm6150l-wled";
 			reg = <0xd800>, <0xd900>;
-			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
-			interrupt-names = "ovp";
+			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ovp", "short";
 			label = "backlight";
 
 			status = "disabled";

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 4/7] arm64: dts: qcom: pm660l: Add missing short interrupt
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (2 preceding siblings ...)
  2023-06-26 20:00 ` [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt Konrad Dybcio
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Add the missing short interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['ovp'] is too short

Fixes: 7b56a804e58b ("arm64: dts: qcom: pm660l: Add WLED support")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm660l.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
index 87b71b7205b8..6fdbf507c262 100644
--- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
@@ -74,8 +74,9 @@ pm660l_lpg: pwm {
 		pm660l_wled: leds@d800 {
 			compatible = "qcom,pm660l-wled";
 			reg = <0xd800>, <0xd900>;
-			interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
-			interrupt-names = "ovp";
+			interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+				     <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ovp", "short";
 			label = "backlight";
 
 			status = "disabled";

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (3 preceding siblings ...)
  2023-06-26 20:00 ` [PATCH 4/7] arm64: dts: qcom: pm660l: " Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 6/7] arm64: dts: qcom: pmi8994: " Konrad Dybcio
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Add the missing OVP interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['short'] is too short

Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8950.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index c09a9681bc0c..1029f3b1bb9a 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -87,8 +87,9 @@ pmic@3 {
 		pmi8950_wled: leds@d800 {
 			compatible = "qcom,pmi8950-wled";
 			reg = <0xd800>, <0xd900>;
-			interrupts = <0x3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
-			interrupt-names = "short";
+			interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+				     <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ovp", "short";
 			label = "backlight";
 
 			status = "disabled";

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 6/7] arm64: dts: qcom: pmi8994: Add missing OVP interrupt
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (4 preceding siblings ...)
  2023-06-26 20:00 ` [PATCH 5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-26 20:00 ` [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3 Konrad Dybcio
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Add the missing OVP interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['short'] is too short

Fixes: 37aa540cbd30 ("arm64: dts: qcom: pmi8994: Add WLED node")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8994.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
index 0192968f4d9b..36d6a1fb553a 100644
--- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
@@ -54,8 +54,9 @@ pmi8994_spmi_regulators: regulators {
 		pmi8994_wled: wled@d800 {
 			compatible = "qcom,pmi8994-wled";
 			reg = <0xd800>, <0xd900>;
-			interrupts = <3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
-			interrupt-names = "short";
+			interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+				     <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "ovp", "short";
 			qcom,cabc;
 			qcom,external-pfet;
 			status = "disabled";

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (5 preceding siblings ...)
  2023-06-26 20:00 ` [PATCH 6/7] arm64: dts: qcom: pmi8994: " Konrad Dybcio
@ 2023-06-26 20:00 ` Konrad Dybcio
  2023-06-27  6:09   ` Krzysztof Kozlowski
  2023-07-14  5:48 ` (subset) [PATCH 0/7] random msm bindings fixes Bjorn Andersson
                   ` (2 subsequent siblings)
  9 siblings, 1 reply; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

Add the missing property to fix the dt checker warning:

qcom/sc8180x-primus.dtb: l3-cache: 'cache-unified' is a required property

Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 204deefbfa8b..5d8303a8dc95 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -64,6 +64,7 @@ L2_0: l2-cache {
 				L3_0: l3-cache {
 					compatible = "cache";
 					cache-level = <3>;
+					cache-unified;
 				};
 			};
 		};

-- 
2.41.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
  2023-06-26 20:00 ` [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt Konrad Dybcio
@ 2023-06-26 20:17   ` Luca Weiss
  2023-06-26 20:18     ` Konrad Dybcio
  0 siblings, 1 reply; 17+ messages in thread
From: Luca Weiss @ 2023-06-26 20:17 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Vinod Koul, Konrad Dybcio
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio,
	Konrad Dybcio

On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> Add the missing short interrupt. This fixes the schema warning:
> 
> wled@d800: interrupt-names: ['ovp'] is too short
> 
> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> 100644
> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
>  		pm6150l_wled: leds@d800 {
>  			compatible = "qcom,pm6150l-wled";
>  			reg = <0xd800>, <0xd900>;
> -			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
> -			interrupt-names = "ovp";
> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "ovp", "short";

Are you sure this interrupt really exists? It's not a thing used downstream at
least:
https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293

Regards
Luca

>  			label = "backlight";
> 
>  			status = "disabled";





^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
  2023-06-26 20:17   ` Luca Weiss
@ 2023-06-26 20:18     ` Konrad Dybcio
  2023-06-26 20:26       ` Luca Weiss
  0 siblings, 1 reply; 17+ messages in thread
From: Konrad Dybcio @ 2023-06-26 20:18 UTC (permalink / raw)
  To: Luca Weiss, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bhupesh Sharma,
	Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar, Luca Weiss,
	AngeloGioacchino Del Regno, AngeloGioacchino Del Regno,
	Vinod Koul
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio

On 26.06.2023 22:17, Luca Weiss wrote:
> On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
>> Add the missing short interrupt. This fixes the schema warning:
>>
>> wled@d800: interrupt-names: ['ovp'] is too short
>>
>> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
>> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
>>  		pm6150l_wled: leds@d800 {
>>  			compatible = "qcom,pm6150l-wled";
>>  			reg = <0xd800>, <0xd900>;
>> -			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
>> -			interrupt-names = "ovp";
>> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
>> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-names = "ovp", "short";
> 
> Are you sure this interrupt really exists? It's not a thing used downstream at
> least:
> https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> 
Confirmed with a reliable source.

Konrad
> Regards
> Luca
> 
>>  			label = "backlight";
>>
>>  			status = "disabled";
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
  2023-06-26 20:18     ` Konrad Dybcio
@ 2023-06-26 20:26       ` Luca Weiss
  0 siblings, 0 replies; 17+ messages in thread
From: Luca Weiss @ 2023-06-26 20:26 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier,
	Sibi Sankar, Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Vinod Koul, Konrad Dybcio
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio

On Montag, 26. Juni 2023 22:18:11 CEST Konrad Dybcio wrote:
> On 26.06.2023 22:17, Luca Weiss wrote:
> > On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> >> Add the missing short interrupt. This fixes the schema warning:
> >> 
> >> wled@d800: interrupt-names: ['ovp'] is too short
> >> 
> >> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> >> 
> >>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> >> 100644
> >> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> >> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@d300 {
> >> 
> >>  		pm6150l_wled: leds@d800 {
> >>  		
> >>  			compatible = "qcom,pm6150l-wled";
> >>  			reg = <0xd800>, <0xd900>;
> >> 
> >> -			interrupts = <0x5 0xd8 0x1 
IRQ_TYPE_EDGE_RISING>;
> >> -			interrupt-names = "ovp";
> >> +			interrupts = <0x5 0xd8 0x1 
IRQ_TYPE_EDGE_RISING>,
> >> +				     <0x5 0xd8 0x2 
IRQ_TYPE_EDGE_RISING>;
> >> +			interrupt-names = "ovp", "short";
> > 
> > Are you sure this interrupt really exists? It's not a thing used
> > downstream at least:
> > https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/
> > android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293
> Confirmed with a reliable source.

Fine by me then.

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> 
> Konrad
> 
> > Regards
> > Luca
> > 
> >>  			label = "backlight";
> >>  			
> >>  			status = "disabled";





^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro"
  2023-06-26 20:00 ` [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro" Konrad Dybcio
@ 2023-06-26 21:27   ` Rob Herring
  0 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2023-06-26 21:27 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski, Conor Dooley,
	Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar,
	Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul,
	Marijn Suijten, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, linux-remoteproc, Konrad Dybcio

On Mon, Jun 26, 2023 at 10:00:23PM +0200, Konrad Dybcio wrote:
> There are a couple of SoCs whose names end in "pro", with the currently-
> upstream examples being msm8974pro and msm8996pro. Allow such suffix in
> SoC-specific compatibles.
> 
> Fixes: 5aa332c5e7ca ("dt-bindings: qcom: document preferred compatible naming")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index e333ec4a9c5f..607a1cf1ef94 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -31,7 +31,7 @@ properties:
>    compatible:
>      oneOf:
>        # Preferred naming style for compatibles of SoC components:
> -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$"
> +      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+(pro|)-.*$"

"(pro)?" would be slightly better than "(pro|)" IMO.

Acked-by: Rob Herring <robh@kernel.org>

>        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
>  
>        # Legacy namings - variations of existing patterns/compatibles are OK,
> 
> -- 
> 2.41.0
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
  2023-06-26 20:00 ` [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks Konrad Dybcio
@ 2023-06-26 21:28   ` Rob Herring
  0 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2023-06-26 21:28 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski, Conor Dooley,
	Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar,
	Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul,
	Marijn Suijten, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, linux-remoteproc, Konrad Dybcio

On Mon, Jun 26, 2023 at 10:00:24PM +0200, Konrad Dybcio wrote:
> Change RPMH to RPM (as RPMh was introduced 2 generations later) and drop
> the prng reference, which made ARRAY_SIZE(clocks) !=
> ARRAY_SIZE(clock-names).
> 
> Fixes: bdea142295ff ("dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml       | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3
  2023-06-26 20:00 ` [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3 Konrad Dybcio
@ 2023-06-27  6:09   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-27  6:09 UTC (permalink / raw)
  To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bhupesh Sharma,
	Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar, Luca Weiss,
	AngeloGioacchino Del Regno, AngeloGioacchino Del Regno,
	Luca Weiss, Vinod Koul
  Cc: Marijn Suijten, Rob Herring, linux-arm-msm, devicetree,
	linux-kernel, linux-remoteproc, Konrad Dybcio

On 26/06/2023 22:00, Konrad Dybcio wrote:
> Add the missing property to fix the dt checker warning:
> 
> qcom/sc8180x-primus.dtb: l3-cache: 'cache-unified' is a required property
> 
> Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---

The last one, I hope...

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: (subset) [PATCH 0/7] random msm bindings fixes
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (6 preceding siblings ...)
  2023-06-26 20:00 ` [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3 Konrad Dybcio
@ 2023-07-14  5:48 ` Bjorn Andersson
  2023-07-19  3:21 ` Bjorn Andersson
  2023-07-22  5:17 ` Bjorn Andersson
  9 siblings, 0 replies; 17+ messages in thread
From: Bjorn Andersson @ 2023-07-14  5:48 UTC (permalink / raw)
  To: Andy Gross, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar,
	Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul,
	Konrad Dybcio
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio


On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
> 


Applied, thanks!

[3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
      commit: 7e1f024ef0d1da456f61d00f01dc3287ede915b3
[4/7] arm64: dts: qcom: pm660l: Add missing short interrupt
      commit: 9a4ac09db3c7413e334b4abd6b2f6de8930dd781
[5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt
      commit: 4d77b639531fd85b84a7079c3369908dfaddf8b2
[6/7] arm64: dts: qcom: pmi8994: Add missing OVP interrupt
      commit: 8db94432690371b1736e9a2566a9b3d8a73d5a97
[7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3
      commit: e4322bb818bbcd36b441de9880fa4ac911a5eb51

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: (subset) [PATCH 0/7] random msm bindings fixes
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (7 preceding siblings ...)
  2023-07-14  5:48 ` (subset) [PATCH 0/7] random msm bindings fixes Bjorn Andersson
@ 2023-07-19  3:21 ` Bjorn Andersson
  2023-07-22  5:17 ` Bjorn Andersson
  9 siblings, 0 replies; 17+ messages in thread
From: Bjorn Andersson @ 2023-07-19  3:21 UTC (permalink / raw)
  To: Andy Gross, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar,
	Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul,
	Konrad Dybcio
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio


On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
> 


Applied, thanks!

[2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
      commit: 7784311cad42e67a1a51a9d1b961752c0f9b7200

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: (subset) [PATCH 0/7] random msm bindings fixes
  2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
                   ` (8 preceding siblings ...)
  2023-07-19  3:21 ` Bjorn Andersson
@ 2023-07-22  5:17 ` Bjorn Andersson
  9 siblings, 0 replies; 17+ messages in thread
From: Bjorn Andersson @ 2023-07-22  5:17 UTC (permalink / raw)
  To: Andy Gross, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bhupesh Sharma, Dmitry Baryshkov, Mathieu Poirier, Sibi Sankar,
	Luca Weiss, AngeloGioacchino Del Regno,
	AngeloGioacchino Del Regno, Luca Weiss, Vinod Koul,
	Konrad Dybcio
  Cc: Marijn Suijten, Krzysztof Kozlowski, Rob Herring, linux-arm-msm,
	devicetree, linux-kernel, linux-remoteproc, Konrad Dybcio


On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
> 


Applied, thanks!

[1/7] dt-bindings: qcom: Allow SoC names ending in "pro"
      commit: e40266d90545ef11f95832177faedf41eadcc453

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2023-07-22  5:14 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 20:00 [PATCH 0/7] random msm bindings fixes Konrad Dybcio
2023-06-26 20:00 ` [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro" Konrad Dybcio
2023-06-26 21:27   ` Rob Herring
2023-06-26 20:00 ` [PATCH 2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks Konrad Dybcio
2023-06-26 21:28   ` Rob Herring
2023-06-26 20:00 ` [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt Konrad Dybcio
2023-06-26 20:17   ` Luca Weiss
2023-06-26 20:18     ` Konrad Dybcio
2023-06-26 20:26       ` Luca Weiss
2023-06-26 20:00 ` [PATCH 4/7] arm64: dts: qcom: pm660l: " Konrad Dybcio
2023-06-26 20:00 ` [PATCH 5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt Konrad Dybcio
2023-06-26 20:00 ` [PATCH 6/7] arm64: dts: qcom: pmi8994: " Konrad Dybcio
2023-06-26 20:00 ` [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3 Konrad Dybcio
2023-06-27  6:09   ` Krzysztof Kozlowski
2023-07-14  5:48 ` (subset) [PATCH 0/7] random msm bindings fixes Bjorn Andersson
2023-07-19  3:21 ` Bjorn Andersson
2023-07-22  5:17 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).