linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
@ 2023-09-11 16:15 Vignesh Raman
  2023-09-12 17:09 ` Helen Koike
  2023-09-22 13:53 ` Bjorn Andersson
  0 siblings, 2 replies; 9+ messages in thread
From: Vignesh Raman @ 2023-09-11 16:15 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: guilherme.gallo, sergi.blanch.torne, daniels, emma, robdclark,
	Vignesh Raman, Dmitry Baryshkov, Maxime Ripard, Helen Koike,
	David Heidelberg, linux-arm-msm, devicetree, linux-kernel

Due to the presence of the fastboot micro cable in the CI farm,
it causes the hardware to remain in gadget mode instead of host mode.
So it doesn't find the network, which results in failure to mount root
fs via NFS.

Add an overlay dtso file that sets the dr_mode to host, allowing the
USB controllers to work in host mode. With commit 15d16d6dadf6
("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
be used to simplify the build of DTB overlays. It uses fdtoverlay to
merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
file can be used by drm-ci, mesa-ci.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Suggested-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---
 arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 2cca20563a1d..99190a6ba6ff 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -1,5 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
+
+apq8016-sbc-usb-host-dtbs	:= apq8016-sbc.dtb apq8016-sbc-usb-host.dtbo
+
+dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-usb-host.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-d3-camera-mezzanine.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8039-t2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
new file mode 100644
index 000000000000..a82c26b7eae8
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+/plugin/;
+
+&usb {
+         dr_mode = "host";
+};
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
  2023-09-11 16:15 [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode Vignesh Raman
@ 2023-09-12 17:09 ` Helen Koike
  2023-09-21 14:01   ` Vignesh Raman
  2023-09-22 13:53 ` Bjorn Andersson
  1 sibling, 1 reply; 9+ messages in thread
From: Helen Koike @ 2023-09-12 17:09 UTC (permalink / raw)
  To: Vignesh Raman, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: guilherme.gallo, sergi.blanch.torne, daniels, emma, robdclark,
	Dmitry Baryshkov, Maxime Ripard, David Heidelberg, linux-arm-msm,
	devicetree, linux-kernel



On 11/09/2023 13:15, Vignesh Raman wrote:
> Due to the presence of the fastboot micro cable in the CI farm,
> it causes the hardware to remain in gadget mode instead of host mode.
> So it doesn't find the network, which results in failure to mount root
> fs via NFS.

Just a context for others, this was part of this patch series 
https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com

> 
> Add an overlay dtso file that sets the dr_mode to host, allowing the
> USB controllers to work in host mode. With commit 15d16d6dadf6
> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
> be used to simplify the build of DTB overlays. It uses fdtoverlay to
> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
> file can be used by drm-ci, mesa-ci.
> 
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Suggested-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Acked-by: Helen Koike <helen.koike@collabora.com>


> ---
>   arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
>   arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
>   2 files changed, 12 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 2cca20563a1d..99190a6ba6ff 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,5 +1,9 @@
>   # SPDX-License-Identifier: GPL-2.0
>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
> +
> +apq8016-sbc-usb-host-dtbs	:= apq8016-sbc.dtb apq8016-sbc-usb-host.dtbo
> +
> +dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-usb-host.dtb
>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-d3-camera-mezzanine.dtb
>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8039-t2.dtb
>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
> new file mode 100644
> index 000000000000..a82c26b7eae8
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
> @@ -0,0 +1,8 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&usb {
> +         dr_mode = "host";
> +};

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
  2023-09-12 17:09 ` Helen Koike
@ 2023-09-21 14:01   ` Vignesh Raman
  2023-09-21 14:53     ` Dmitry Baryshkov
  0 siblings, 1 reply; 9+ messages in thread
From: Vignesh Raman @ 2023-09-21 14:01 UTC (permalink / raw)
  To: Helen Koike, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: guilherme.gallo, sergi.blanch.torne, daniels, emma, robdclark,
	Dmitry Baryshkov, Maxime Ripard, David Heidelberg, linux-arm-msm,
	devicetree, linux-kernel

Hi maintainers,

On 12/09/23 22:39, Helen Koike wrote:
> 
> 
> On 11/09/2023 13:15, Vignesh Raman wrote:
>> Due to the presence of the fastboot micro cable in the CI farm,
>> it causes the hardware to remain in gadget mode instead of host mode.
>> So it doesn't find the network, which results in failure to mount root
>> fs via NFS.
> 
> Just a context for others, this was part of this patch series 
> https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com
> 
>>
>> Add an overlay dtso file that sets the dr_mode to host, allowing the
>> USB controllers to work in host mode. With commit 15d16d6dadf6
>> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
>> be used to simplify the build of DTB overlays. It uses fdtoverlay to
>> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
>> file can be used by drm-ci, mesa-ci.
>>
>> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Suggested-by: Maxime Ripard <mripard@kernel.org>
>> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> 
> Acked-by: Helen Koike <helen.koike@collabora.com>
> 
> 
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
>>   arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
>>   2 files changed, 12 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile 
>> b/arch/arm64/boot/dts/qcom/Makefile
>> index 2cca20563a1d..99190a6ba6ff 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -1,5 +1,9 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc.dtb
>> +
>> +apq8016-sbc-usb-host-dtbs    := apq8016-sbc.dtb 
>> apq8016-sbc-usb-host.dtbo
>> +
>> +dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc-usb-host.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc-d3-camera-mezzanine.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)    += apq8039-t2.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)    += 
>> apq8094-sony-xperia-kitakami-karin_windy.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso 
>> b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
>> new file mode 100644
>> index 000000000000..a82c26b7eae8
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
>> @@ -0,0 +1,8 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +&usb {
>> +         dr_mode = "host";
>> +};

Please could you review this patch. Thanks.

Regards,
Vignesh

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
  2023-09-21 14:01   ` Vignesh Raman
@ 2023-09-21 14:53     ` Dmitry Baryshkov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2023-09-21 14:53 UTC (permalink / raw)
  To: Vignesh Raman
  Cc: Helen Koike, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, guilherme.gallo,
	sergi.blanch.torne, daniels, emma, robdclark, Maxime Ripard,
	David Heidelberg, linux-arm-msm, devicetree, linux-kernel

On Thu, 21 Sept 2023 at 17:01, Vignesh Raman
<vignesh.raman@collabora.com> wrote:
>
> Hi maintainers,
>
> On 12/09/23 22:39, Helen Koike wrote:
> >
> >
> > On 11/09/2023 13:15, Vignesh Raman wrote:
> >> Due to the presence of the fastboot micro cable in the CI farm,
> >> it causes the hardware to remain in gadget mode instead of host mode.
> >> So it doesn't find the network, which results in failure to mount root
> >> fs via NFS.
> >
> > Just a context for others, this was part of this patch series
> > https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com
> >
> >>
> >> Add an overlay dtso file that sets the dr_mode to host, allowing the
> >> USB controllers to work in host mode. With commit 15d16d6dadf6
> >> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
> >> be used to simplify the build of DTB overlays. It uses fdtoverlay to
> >> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
> >> file can be used by drm-ci, mesa-ci.
> >>
> >> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >> Suggested-by: Maxime Ripard <mripard@kernel.org>
> >> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> >> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> >
> > Acked-by: Helen Koike <helen.koike@collabora.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> >
> >
> >> ---
> >>   arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
> >>   arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
> >>   2 files changed, 12 insertions(+)
> >>   create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
  2023-09-11 16:15 [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode Vignesh Raman
  2023-09-12 17:09 ` Helen Koike
@ 2023-09-22 13:53 ` Bjorn Andersson
  1 sibling, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2023-09-22 13:53 UTC (permalink / raw)
  To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vignesh Raman
  Cc: guilherme.gallo, sergi.blanch.torne, daniels, emma, robdclark,
	Dmitry Baryshkov, Maxime Ripard, Helen Koike, David Heidelberg,
	linux-arm-msm, devicetree, linux-kernel


On Mon, 11 Sep 2023 21:45:18 +0530, Vignesh Raman wrote:
> Due to the presence of the fastboot micro cable in the CI farm,
> it causes the hardware to remain in gadget mode instead of host mode.
> So it doesn't find the network, which results in failure to mount root
> fs via NFS.
> 
> Add an overlay dtso file that sets the dr_mode to host, allowing the
> USB controllers to work in host mode. With commit 15d16d6dadf6
> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
> be used to simplify the build of DTB overlays. It uses fdtoverlay to
> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
> file can be used by drm-ci, mesa-ci.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
      commit: bdc4d17e1627e3b44f25b8f87509023dc2b438a2

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
  2023-09-11 15:39 ` Krzysztof Kozlowski
@ 2023-09-11 16:04   ` Vignesh Raman
  0 siblings, 0 replies; 9+ messages in thread
From: Vignesh Raman @ 2023-09-11 16:04 UTC (permalink / raw)
  To: Krzysztof Kozlowski, devicetree
  Cc: helen.koike, guilherme.gallo, sergi.blanch.torne,
	david.heidelberg, daniels, emma, robdclark, mripard,
	dmitry.baryshkov, linux-arm-msm

Hi Krzysztof,

On 11/09/23 21:09, Krzysztof Kozlowski wrote:
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
> 
> You skipped all maintainers, so this patch will be simply ignored.

Apologies. I think the second time also the patch was ignored.

Will use 
https://www.marcusfolkesson.se/blog/get_maintainers-and-git-send-email/ 
to populate the correct to and cc list.

Thanks.

Regards,
Vigesh



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
@ 2023-09-11 15:47 Vignesh Raman
  0 siblings, 0 replies; 9+ messages in thread
From: Vignesh Raman @ 2023-09-11 15:47 UTC (permalink / raw)
  To: devicetree
  Cc: helen.koike, guilherme.gallo, sergi.blanch.torne,
	david.heidelberg, daniels, emma, robdclark, mripard,
	dmitry.baryshkov, krzysztof.kozlowski, agross, andersson,
	konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	linux-arm-msm, linux-kernel

Due to the presence of the fastboot micro cable in the CI farm,
it causes the hardware to remain in gadget mode instead of host mode.
So it doesn't find the network, which results in failure to mount root
fs via NFS.

Add an overlay dtso file that sets the dr_mode to host, allowing the
USB controllers to work in host mode. With commit 15d16d6dadf6
("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
be used to simplify the build of DTB overlays. It uses fdtoverlay to
merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
file can be used by drm-ci, mesa-ci.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Suggested-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---
 arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 2cca20563a1d..99190a6ba6ff 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -1,5 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
+
+apq8016-sbc-usb-host-dtbs	:= apq8016-sbc.dtb apq8016-sbc-usb-host.dtbo
+
+dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-usb-host.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-d3-camera-mezzanine.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8039-t2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
new file mode 100644
index 000000000000..a82c26b7eae8
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+/plugin/;
+
+&usb {
+         dr_mode = "host";
+};
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
  2023-09-11 15:32 Vignesh Raman
@ 2023-09-11 15:39 ` Krzysztof Kozlowski
  2023-09-11 16:04   ` Vignesh Raman
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-11 15:39 UTC (permalink / raw)
  To: Vignesh Raman, devicetree
  Cc: helen.koike, guilherme.gallo, sergi.blanch.torne,
	david.heidelberg, daniels, emma, robdclark, mripard,
	dmitry.baryshkov, linux-arm-msm

On 11/09/2023 17:32, Vignesh Raman wrote:
> Due to the presence of the fastboot micro cable in the CI farm,
> it causes the hardware to remain in gadget mode instead of host mode.
> So it doesn't find the network, which results in failure to mount root
> fs via NFS.
> 
> Add an overlay dtso file that sets the dr_mode to host, allowing the
> USB controllers to work in host mode. With commit 15d16d6dadf6
> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
> be used to simplify the build of DTB overlays. It uses fdtoverlay to
> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
> file can be used by drm-ci, mesa-ci.
> 
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Suggested-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

You skipped all maintainers, so this patch will be simply ignored.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode
@ 2023-09-11 15:32 Vignesh Raman
  2023-09-11 15:39 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Vignesh Raman @ 2023-09-11 15:32 UTC (permalink / raw)
  To: devicetree
  Cc: helen.koike, guilherme.gallo, sergi.blanch.torne,
	david.heidelberg, daniels, emma, robdclark, mripard,
	dmitry.baryshkov, krzysztof.kozlowski, linux-arm-msm

Due to the presence of the fastboot micro cable in the CI farm,
it causes the hardware to remain in gadget mode instead of host mode.
So it doesn't find the network, which results in failure to mount root
fs via NFS.

Add an overlay dtso file that sets the dr_mode to host, allowing the
USB controllers to work in host mode. With commit 15d16d6dadf6
("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
be used to simplify the build of DTB overlays. It uses fdtoverlay to
merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
file can be used by drm-ci, mesa-ci.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Suggested-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---
 arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 2cca20563a1d..99190a6ba6ff 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -1,5 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
+
+apq8016-sbc-usb-host-dtbs	:= apq8016-sbc.dtb apq8016-sbc-usb-host.dtbo
+
+dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-usb-host.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc-d3-camera-mezzanine.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8039-t2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
new file mode 100644
index 000000000000..a82c26b7eae8
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+/plugin/;
+
+&usb {
+         dr_mode = "host";
+};
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-09-22 13:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 16:15 [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode Vignesh Raman
2023-09-12 17:09 ` Helen Koike
2023-09-21 14:01   ` Vignesh Raman
2023-09-21 14:53     ` Dmitry Baryshkov
2023-09-22 13:53 ` Bjorn Andersson
  -- strict thread matches above, loose matches on Subject: below --
2023-09-11 15:47 Vignesh Raman
2023-09-11 15:32 Vignesh Raman
2023-09-11 15:39 ` Krzysztof Kozlowski
2023-09-11 16:04   ` Vignesh Raman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).