[PATCH 0/5] arm64: defconfig: build some essential Qualcomm platform drivers

[PATCH 0/5] arm64: defconfig: build some essential Qualcomm platform drivers

[Vladimir Zapolskiy]

It's discovered that a kernel image for Qualcomm QCM2290/SM6115 built
from a defconfig misses a few important platform device drivers, the
changeset enables them.

Konrad Dybcio (1):
  arm64: defconfig: Build SM6115 display and GPU clock controller drivers

Vladimir Zapolskiy (4):
  arm64: defconfig: Build MSM power manager driver
  arm64: defconfig: Build Global Clock Controller driver for QCM2290
  arm64: defconfig: Build interconnect driver for QCM2290
  arm64: defconfig: Build display clock controller driver for QCM2290

 arch/arm64/configs/defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.33.0

[PATCH 1/5] arm64: defconfig: Build MSM power manager driver

[Vladimir Zapolskiy]

Build Qualcomm MSM Power Manager driver, which is needed for QCM2290
platform, otherwise the TLMM pin controller driver probe fails on boot.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 72136a45c634..40100b9dd6e0 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1323,6 +1323,7 @@ CONFIG_PWM_TEGRA=m
 CONFIG_PWM_VISCONTI=m
 CONFIG_SL28CPLD_INTC=y
 CONFIG_QCOM_PDC=y
+CONFIG_QCOM_MPM=y
 CONFIG_RESET_IMX7=y
 CONFIG_RESET_QCOM_AOSS=y
 CONFIG_RESET_QCOM_PDC=m
-- 
2.33.0

[PATCH 2/5] arm64: defconfig: Build Global Clock Controller driver for QCM2290

[Vladimir Zapolskiy]

Build Qualcomm QCM2290 GCC driver.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 40100b9dd6e0..e2f6a352a0ad 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1163,6 +1163,7 @@ CONFIG_MSM_MMCC_8994=m
 CONFIG_MSM_MMCC_8996=m
 CONFIG_MSM_MMCC_8998=m
 CONFIG_MSM_GCC_8998=y
+CONFIG_QCM_GCC_2290=y
 CONFIG_QCS_GCC_404=y
 CONFIG_SA_GCC_8775P=y
 CONFIG_SC_DISPCC_8280XP=m
-- 
2.33.0

[PATCH 3/5] arm64: defconfig: Build interconnect driver for QCM2290

[Vladimir Zapolskiy]

Build Qualcomm QCM2290 interconnect driver.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index e2f6a352a0ad..ec9b828b14e2 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y
 CONFIG_INTERCONNECT_QCOM_MSM8916=m
 CONFIG_INTERCONNECT_QCOM_MSM8996=m
 CONFIG_INTERCONNECT_QCOM_OSM_L3=m
+CONFIG_INTERCONNECT_QCOM_QCM2290=y
 CONFIG_INTERCONNECT_QCOM_QCS404=m
 CONFIG_INTERCONNECT_QCOM_SA8775P=y
 CONFIG_INTERCONNECT_QCOM_SC7180=y
-- 
2.33.0

[PATCH 4/5] arm64: defconfig: Build display clock controller driver for QCM2290

[Vladimir Zapolskiy]

Build display clock controller driver for Qualcomm QCM2290 platform.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index ec9b828b14e2..3ec556cdfac3 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1164,6 +1164,7 @@ CONFIG_MSM_MMCC_8996=m
 CONFIG_MSM_MMCC_8998=m
 CONFIG_MSM_GCC_8998=y
 CONFIG_QCM_GCC_2290=y
+CONFIG_QCM_DISPCC_2290=m
 CONFIG_QCS_GCC_404=y
 CONFIG_SA_GCC_8775P=y
 CONFIG_SC_DISPCC_8280XP=m
-- 
2.33.0

[PATCH 5/5] arm64: defconfig: Build SM6115 display and GPU clock controller drivers

[Vladimir Zapolskiy]

From: Konrad Dybcio <konrad.dybcio@linaro.org>

Enable the clock controllers required for a good visual experience
on Qualcomm SM6115 platform boards.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
[vzapolskiy: minimal changes to a commit message]
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3ec556cdfac3..82aead857cb2 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1179,6 +1179,7 @@ CONFIG_SDM_VIDEOCC_845=y
 CONFIG_SDM_DISPCC_845=y
 CONFIG_SDM_LPASSCC_845=m
 CONFIG_SM_CAMCC_8250=m
+CONFIG_SM_DISPCC_6115=m
 CONFIG_SM_DISPCC_8250=y
 CONFIG_SM_DISPCC_8450=m
 CONFIG_SM_DISPCC_8550=m
@@ -1187,6 +1188,7 @@ CONFIG_SM_GCC_8350=y
 CONFIG_SM_GCC_8450=y
 CONFIG_SM_GCC_8550=y
 CONFIG_SM_TCSRCC_8550=y
+CONFIG_SM_GPUCC_6115=m
 CONFIG_SM_GPUCC_8150=y
 CONFIG_SM_GPUCC_8250=y
 CONFIG_SM_VIDEOCC_8250=y
-- 
2.33.0

Re: [PATCH 1/5] arm64: defconfig: Build MSM power manager driver

[Konrad Dybcio]

On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
> Build Qualcomm MSM Power Manager driver, which is needed for QCM2290
> platform, otherwise the TLMM pin controller driver probe fails on boot.
Nit: that is the case on our integration branch today, but will only
be the case upstream soon:tm:

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 72136a45c634..40100b9dd6e0 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1323,6 +1323,7 @@ CONFIG_PWM_TEGRA=m
>  CONFIG_PWM_VISCONTI=m
>  CONFIG_SL28CPLD_INTC=y
>  CONFIG_QCOM_PDC=y
> +CONFIG_QCOM_MPM=y
>  CONFIG_RESET_IMX7=y
>  CONFIG_RESET_QCOM_AOSS=y
>  CONFIG_RESET_QCOM_PDC=m

Re: [PATCH 2/5] arm64: defconfig: Build Global Clock Controller driver for QCM2290

[Konrad Dybcio]

On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
> Build Qualcomm QCM2290 GCC driver.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 40100b9dd6e0..e2f6a352a0ad 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1163,6 +1163,7 @@ CONFIG_MSM_MMCC_8994=m
>  CONFIG_MSM_MMCC_8996=m
>  CONFIG_MSM_MMCC_8998=m
>  CONFIG_MSM_GCC_8998=y
> +CONFIG_QCM_GCC_2290=y
>  CONFIG_QCS_GCC_404=y
>  CONFIG_SA_GCC_8775P=y
>  CONFIG_SC_DISPCC_8280XP=m

Re: [PATCH 3/5] arm64: defconfig: Build interconnect driver for QCM2290

[Konrad Dybcio]

On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
> Build Qualcomm QCM2290 interconnect driver.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
Do we know why some are =y and some are =m?

I'm for =y either way, if we can.

Konrad
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index e2f6a352a0ad..ec9b828b14e2 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y
>  CONFIG_INTERCONNECT_QCOM_MSM8916=m
>  CONFIG_INTERCONNECT_QCOM_MSM8996=m
>  CONFIG_INTERCONNECT_QCOM_OSM_L3=m
> +CONFIG_INTERCONNECT_QCOM_QCM2290=y
>  CONFIG_INTERCONNECT_QCOM_QCS404=m
>  CONFIG_INTERCONNECT_QCOM_SA8775P=y
>  CONFIG_INTERCONNECT_QCOM_SC7180=y

Re: [PATCH 4/5] arm64: defconfig: Build display clock controller driver for QCM2290

[Konrad Dybcio]

On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
> Build display clock controller driver for Qualcomm QCM2290 platform.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index ec9b828b14e2..3ec556cdfac3 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1164,6 +1164,7 @@ CONFIG_MSM_MMCC_8996=m
>  CONFIG_MSM_MMCC_8998=m
>  CONFIG_MSM_GCC_8998=y
>  CONFIG_QCM_GCC_2290=y
> +CONFIG_QCM_DISPCC_2290=m
>  CONFIG_QCS_GCC_404=y
>  CONFIG_SA_GCC_8775P=y
>  CONFIG_SC_DISPCC_8280XP=m

Re: [PATCH 3/5] arm64: defconfig: Build interconnect driver for QCM2290

[Dmitry Baryshkov]

On 23/05/2023 20:30, Konrad Dybcio wrote:
> 
> 
> On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
>> Build Qualcomm QCM2290 interconnect driver.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> ---
> Do we know why some are =y and some are =m?
> 
> I'm for =y either way, if we can.

I think this might change from platform to platform. What is the 
condition for selecting 'y' or 'm' for the core drivers? Is it 'should 
boot to rootfs without modules' or 'should boot to UART and load initrd 
without modules' ?

> 
> Konrad
>>   arch/arm64/configs/defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index e2f6a352a0ad..ec9b828b14e2 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y
>>   CONFIG_INTERCONNECT_QCOM_MSM8916=m
>>   CONFIG_INTERCONNECT_QCOM_MSM8996=m
>>   CONFIG_INTERCONNECT_QCOM_OSM_L3=m
>> +CONFIG_INTERCONNECT_QCOM_QCM2290=y
>>   CONFIG_INTERCONNECT_QCOM_QCS404=m
>>   CONFIG_INTERCONNECT_QCOM_SA8775P=y
>>   CONFIG_INTERCONNECT_QCOM_SC7180=y

-- 
With best wishes
Dmitry

Re: [PATCH 3/5] arm64: defconfig: Build interconnect driver for QCM2290

[Arnd Bergmann]

On Tue, May 23, 2023, at 23:11, Dmitry Baryshkov wrote:
> On 23/05/2023 20:30, Konrad Dybcio wrote:
>> 
>> 
>> On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
>>> Build Qualcomm QCM2290 interconnect driver.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>> ---
>> Do we know why some are =y and some are =m?
>> 
>> I'm for =y either way, if we can.
>
> I think this might change from platform to platform. What is the 
> condition for selecting 'y' or 'm' for the core drivers? Is it 'should 
> boot to rootfs without modules' or 'should boot to UART and load initrd 
> without modules' ?

I think we are a bit inconsistent here. I'm generally fine taking
changes that are required to boot into rootfs without initramfs,
but would like everything else to be loadable modules.

Android tends to want everything as modules and require an initramfs
for loading them, so I think platforms that are mostly Android
specific lean towards that even for core drivers.

     Arnd

Re: [PATCH 3/5] arm64: defconfig: Build interconnect driver for QCM2290

[Bjorn Andersson]

On Wed, May 24, 2023 at 08:36:20AM +0200, Arnd Bergmann wrote:
> On Tue, May 23, 2023, at 23:11, Dmitry Baryshkov wrote:
> > On 23/05/2023 20:30, Konrad Dybcio wrote:
> >> 
> >> 
> >> On 23.05.2023 18:54, Vladimir Zapolskiy wrote:
> >>> Build Qualcomm QCM2290 interconnect driver.
> >>>
> >>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> >>> ---
> >> Do we know why some are =y and some are =m?
> >> 
> >> I'm for =y either way, if we can.
> >
> > I think this might change from platform to platform. What is the 
> > condition for selecting 'y' or 'm' for the core drivers? Is it 'should 
> > boot to rootfs without modules' or 'should boot to UART and load initrd 
> > without modules' ?
> 
> I think we are a bit inconsistent here. I'm generally fine taking
> changes that are required to boot into rootfs without initramfs,
> but would like everything else to be loadable modules.
> 
> Android tends to want everything as modules and require an initramfs
> for loading them, so I think platforms that are mostly Android
> specific lean towards that even for core drivers.
> 

I (any many other in the Qcom community) do most of my (our) testing and
development using a ramdisk-only approach and if systemd isn't provided
a valid /dev/console at launch, things doesn't work as expected...

So the inconsistency here relates to the fact that not all platforms has
the UART defined to depend on interconnect, once this is populated in
DT, we tend to be forced to move them to =y, together with GCC and
pinctrl-msm.


Looking to storage etc on a modern Qualcomm platform, the dependency
tree is growing quite a bit (regulators, genpd providers etc), and we
have UFS, SDHCI and NVME to support. So I think it's reasonable to have
the generic defconfig require that you use a initramfs to get further
(on the Qualcomm platforms).

Regards,
Bjorn

Re: [PATCH 3/5] arm64: defconfig: Build interconnect driver for QCM2290

[Bjorn Andersson]

On Tue, May 23, 2023 at 07:54:09PM +0300, Vladimir Zapolskiy wrote:
> Build Qualcomm QCM2290 interconnect driver.

In line with the questions that followed, and previous requests. Please
document why this should be =y.

Regards,
Bjorn

> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index e2f6a352a0ad..ec9b828b14e2 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y
>  CONFIG_INTERCONNECT_QCOM_MSM8916=m
>  CONFIG_INTERCONNECT_QCOM_MSM8996=m
>  CONFIG_INTERCONNECT_QCOM_OSM_L3=m
> +CONFIG_INTERCONNECT_QCOM_QCM2290=y
>  CONFIG_INTERCONNECT_QCOM_QCS404=m
>  CONFIG_INTERCONNECT_QCOM_SA8775P=y
>  CONFIG_INTERCONNECT_QCOM_SC7180=y
> -- 
> 2.33.0
>