linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thara Gopinath <thara.gopinath@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Ansuel Smith <ansuelsmth@gmail.com>,
	Amit Kucheria <amitk@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 0/8] Add support for ipq8064 tsens
Date: Wed, 10 Mar 2021 08:32:51 -0500	[thread overview]
Message-ID: <44c7919c-0ed4-abba-21e0-226bb553aad3@linaro.org> (raw)
In-Reply-To: <f0ab094e-440d-993c-6618-bf80fd05d484@linaro.org>



On 3/10/21 7:19 AM, Daniel Lezcano wrote:
> 
> Hi Ansuel,
> 
> On 17/02/2021 20:40, Ansuel Smith wrote:
>> This patchset convert msm8960 to reg_filed, use int_common instead
>> of a custom function and fix wrong tsens get_temp function for msm8960.
>> Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs
>> to be registered as a gcc child as the tsens regs on this platform are
>> shared with the controller.
>> This is based on work and code here
>> https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage
> 
> I don't have major concerns with the series except there is no comment
> from the maintainer / reviewer of the sensor.
> 
> Given it is based on Amit's work, I can assume they are correct.
> 
> I added Thara in Cc hoping she has time to review the changes. If nobody
> complains with the series, I'll merge them in the next days

Hi Ansuel/Daniel,

Just wanted to let you know that I have started looking into this and 
review this within next week or two.

> 
> Thanks
> 
>    -- Daniel
> 
> 

-- 
Warm Regards
Thara

  reply	other threads:[~2021-03-10 13:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 19:40 [PATCH v10 0/8] Add support for ipq8064 tsens Ansuel Smith
2021-02-17 19:40 ` [PATCH v10 1/8] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 2/8] drivers: thermal: tsens: Don't hardcode sensor slope Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 3/8] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 4/8] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 5/8] drivers: thermal: tsens: Fix bug in sensor enable " Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 6/8] drivers: thermal: tsens: Use get_temp_common " Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 7/8] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2021-03-18 21:14   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 8/8] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
2021-03-05 15:24   ` Rob Herring
2021-03-10 12:19 ` [PATCH v10 0/8] Add support for ipq8064 tsens Daniel Lezcano
2021-03-10 13:32   ` Thara Gopinath [this message]
2021-03-10 13:40     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44c7919c-0ed4-abba-21e0-226bb553aad3@linaro.org \
    --to=thara.gopinath@linaro.org \
    --cc=agross@kernel.org \
    --cc=amitk@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).