linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thara Gopinath <thara.gopinath@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>, Amit Kucheria <amitk@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 2/8] drivers: thermal: tsens: Don't hardcode sensor slope
Date: Thu, 18 Mar 2021 17:15:15 -0400	[thread overview]
Message-ID: <7e81650f-c058-c105-d465-f35dd890e563@linaro.org> (raw)
In-Reply-To: <20210217194011.22649-3-ansuelsmth@gmail.com>



On 2/17/21 2:40 PM, Ansuel Smith wrote:
> Function compute_intercept_slope hardcode the sensor slope to
> SLOPE_DEFAULT. Change this and use the default value only if a slope is
> not defined. This is needed for tsens VER_0 that has a hardcoded slope
> table.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

Warm Regards
Thara

> ---
>   drivers/thermal/qcom/tsens.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index f9126909892b..842f518fdf84 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -86,7 +86,8 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
>   			"%s: sensor%d - data_point1:%#x data_point2:%#x\n",
>   			__func__, i, p1[i], p2[i]);
>   
> -		priv->sensor[i].slope = SLOPE_DEFAULT;
> +		if (!priv->sensor[i].slope)
> +			priv->sensor[i].slope = SLOPE_DEFAULT;
>   		if (mode == TWO_PT_CALIB) {
>   			/*
>   			 * slope (m) = adc_code2 - adc_code1 (y2 - y1)/
> 

-- 
Warm Regards
Thara

  reply	other threads:[~2021-03-18 21:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 19:40 [PATCH v10 0/8] Add support for ipq8064 tsens Ansuel Smith
2021-02-17 19:40 ` [PATCH v10 1/8] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 2/8] drivers: thermal: tsens: Don't hardcode sensor slope Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath [this message]
2021-02-17 19:40 ` [PATCH v10 3/8] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 4/8] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 5/8] drivers: thermal: tsens: Fix bug in sensor enable " Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 6/8] drivers: thermal: tsens: Use get_temp_common " Ansuel Smith
2021-03-18 21:15   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 7/8] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2021-03-18 21:14   ` Thara Gopinath
2021-02-17 19:40 ` [PATCH v10 8/8] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
2021-03-05 15:24   ` Rob Herring
2021-03-10 12:19 ` [PATCH v10 0/8] Add support for ipq8064 tsens Daniel Lezcano
2021-03-10 13:32   ` Thara Gopinath
2021-03-10 13:40     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e81650f-c058-c105-d465-f35dd890e563@linaro.org \
    --to=thara.gopinath@linaro.org \
    --cc=agross@kernel.org \
    --cc=amitk@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).