From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org
Cc: bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
agross@kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, stephan@gerhold.net,
Thara Gopinath <thara.gopinath@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v5 13/22] dma: qcom: bam_dma: Add support to initialize interconnect path
Date: Fri, 13 May 2022 02:39:00 +0300 [thread overview]
Message-ID: <49615bc9-c7a4-09ed-c89f-39c50e1d90ba@linaro.org> (raw)
In-Reply-To: <20211110105922.217895-14-bhupesh.sharma@linaro.org>
On 10/11/2021 13:59, Bhupesh Sharma wrote:
> From: Thara Gopinath <thara.gopinath@linaro.org>
>
> BAM dma engine associated with certain hardware blocks could require
> relevant interconnect pieces be initialized prior to the dma engine
> initialization. For e.g. crypto bam dma engine on sm8250. Such requirement
> is passed on to the bam dma driver from dt via the "interconnects"
> property. Add support in bam_dma driver to check whether the interconnect
> path is accessible/enabled prior to attempting driver intializations.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> [Make header file inclusion alphabetical and use 'devm_of_icc_get()']
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> drivers/dma/qcom/bam_dma.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
> index c8a77b428b52..19fb17db467f 100644
> --- a/drivers/dma/qcom/bam_dma.c
> +++ b/drivers/dma/qcom/bam_dma.c
> @@ -26,6 +26,7 @@
> #include <linux/kernel.h>
> #include <linux/io.h>
> #include <linux/init.h>
> +#include <linux/interconnect.h>
> #include <linux/slab.h>
> #include <linux/module.h>
> #include <linux/interrupt.h>
> @@ -392,6 +393,7 @@ struct bam_device {
> const struct reg_offset_data *layout;
>
> struct clk *bamclk;
> + struct icc_path *mem_path;
> int irq;
>
> /* dma start transaction tasklet */
> @@ -1284,6 +1286,15 @@ static int bam_dma_probe(struct platform_device *pdev)
> return ret;
> }
>
> + /* Ensure that interconnects are initialized */
> + bdev->mem_path = devm_of_icc_get(bdev->dev, "memory");
Also, as a note, the "memory" is not a good name for the ICC path.
Usually they take the form of "src-dst". However in this case you can
probably use NULL for the first and the only icc path.
> +
Extra newline, not necessary.
> + if (IS_ERR(bdev->mem_path)) {
> + ret = PTR_ERR(bdev->mem_path);
> + dev_err(bdev->dev, "failed to acquire icc path %d\n", ret);
> + goto err_disable_clk;
> + }
> +
> ret = bam_init(bdev);
> if (ret)
> goto err_disable_clk;
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-05-12 23:39 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 10:59 [PATCH v5 00/22] Enable Qualcomm Crypto Engine on sm8150 & sm8250 Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 01/22] arm64: dts: qcom: msm8996: Fix qcom,controlled-remotely property Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 02/22] arm64: dts: qcom: msm8996: Fix 'dma' nodes in dts Bhupesh Sharma
2021-11-17 5:53 ` Vinod Koul
2021-11-10 10:59 ` [PATCH v5 03/22] dt-bindings: qcom-bam: Convert binding to YAML Bhupesh Sharma
2021-11-10 19:44 ` Rob Herring
2021-11-15 6:04 ` Bhupesh Sharma
2021-11-12 8:41 ` Vladimir Zapolskiy
2021-11-15 6:00 ` Bhupesh Sharma
2021-11-13 19:13 ` Bjorn Andersson
2021-11-15 8:05 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 04/22] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties Bhupesh Sharma
2021-11-18 23:52 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 05/22] dt-bindings: qcom-bam: Add 'iommus' " Bhupesh Sharma
2021-11-18 23:52 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 06/22] dt-bindings: qcom-bam: Add "powered remotely" mode Bhupesh Sharma
2021-11-12 10:20 ` Vladimir Zapolskiy
2021-11-10 10:59 ` [PATCH v5 07/22] dt-bindings: qcom-qce: Convert bindings to yaml Bhupesh Sharma
2021-11-13 19:41 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 08/22] dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' Bhupesh Sharma
2021-11-18 23:53 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 09/22] dt-bindings: qcom-qce: Move 'clocks' to optional properties Bhupesh Sharma
2021-11-13 20:02 ` Bjorn Andersson
2021-11-15 5:34 ` Bhupesh Sharma
2021-11-18 23:57 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 10/22] dt-bindings: qcom-qce: Add 'iommus' " Bhupesh Sharma
2021-11-13 21:23 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 11/22] dt-bindings: crypto : Add new compatible strings for qcom-qce Bhupesh Sharma
2021-11-12 10:25 ` Vladimir Zapolskiy
2021-11-15 5:28 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 12/22] arm64/dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
2021-11-12 10:26 ` Vladimir Zapolskiy
2021-11-15 5:04 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 13/22] dma: qcom: bam_dma: Add support to initialize interconnect path Bhupesh Sharma
2021-11-12 10:32 ` Vladimir Zapolskiy
2021-11-15 5:27 ` Bhupesh Sharma
2021-11-15 17:53 ` Bjorn Andersson
2022-05-12 23:39 ` Dmitry Baryshkov [this message]
2021-11-10 10:59 ` [PATCH v5 14/22] crypto: qce: core: " Bhupesh Sharma
2021-11-12 10:40 ` Vladimir Zapolskiy
2021-11-15 18:25 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 15/22] crypto: qce: Add new compatibles for qce crypto driver Bhupesh Sharma
2021-11-12 10:36 ` Vladimir Zapolskiy
2021-11-15 5:07 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 16/22] crypto: qce: core: Make clocks optional Bhupesh Sharma
2021-11-15 18:06 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 17/22] crypto: qce: Print a failure msg in case probe() fails Bhupesh Sharma
2021-11-12 10:42 ` Vladimir Zapolskiy
2021-11-15 5:14 ` Bhupesh Sharma
2021-11-15 18:10 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 18/22] crypto: qce: Defer probing if BAM dma channel is not yet initialized Bhupesh Sharma
2021-11-15 18:29 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 19/22] crypto: qce: Add 'sm8250-qce' compatible string check Bhupesh Sharma
2021-11-15 18:32 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 20/22] crypto: qce: Add 'sm8150-qce' " Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 21/22] arm64/dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
2021-11-15 18:34 ` Bjorn Andersson
2021-11-15 20:11 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 22/22] arm64/dts: qcom: sm8150: " Bhupesh Sharma
2022-02-11 21:49 ` [PATCH v5 00/22] Enable Qualcomm Crypto Engine on sm8150 & sm8250 Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49615bc9-c7a4-09ed-c89f-39c50e1d90ba@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).