From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
agross@kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, stephan@gerhold.net,
Thara Gopinath <thara.gopinath@linaro.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 07/22] dt-bindings: qcom-qce: Convert bindings to yaml
Date: Sat, 13 Nov 2021 13:41:00 -0600 [thread overview]
Message-ID: <YZAUzEGavOyhBcVm@builder.lan> (raw)
In-Reply-To: <20211110105922.217895-8-bhupesh.sharma@linaro.org>
On Wed 10 Nov 04:59 CST 2021, Bhupesh Sharma wrote:
> Convert Qualcomm QCE crypto devicetree binding to YAML.
>
> Cc: Thara Gopinath <thara.gopinath@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> .../devicetree/bindings/crypto/qcom-qce.txt | 25 -------
> .../devicetree/bindings/crypto/qcom-qce.yaml | 67 +++++++++++++++++++
> 2 files changed, 67 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt
> create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> deleted file mode 100644
> index fdd53b184ba8..000000000000
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Qualcomm crypto engine driver
> -
> -Required properties:
> -
> -- compatible : should be "qcom,crypto-v5.1"
> -- reg : specifies base physical address and size of the registers map
> -- clocks : phandle to clock-controller plus clock-specifier pair
> -- clock-names : "iface" clocks register interface
> - "bus" clocks data transfer interface
> - "core" clocks rest of the crypto block
> -- dmas : DMA specifiers for tx and rx dma channels. For more see
> - Documentation/devicetree/bindings/dma/dma.txt
> -- dma-names : DMA request names should be "rx" and "tx"
> -
> -Example:
> - crypto@fd45a000 {
> - compatible = "qcom,crypto-v5.1";
> - reg = <0xfd45a000 0x6000>;
> - clocks = <&gcc GCC_CE2_AHB_CLK>,
> - <&gcc GCC_CE2_AXI_CLK>,
> - <&gcc GCC_CE2_CLK>;
> - clock-names = "iface", "bus", "core";
> - dmas = <&cryptobam 2>, <&cryptobam 3>;
> - dma-names = "rx", "tx";
> - };
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> new file mode 100644
> index 000000000000..3a839c159d92
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/qcom-qce.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm crypto engine driver
> +
> +maintainers:
> + - Bhupesh Sharma <bhupesh.sharma@linaro.org>
> +
> +description: |
Nit. The '|' retains the formatting of the description, there's no need
for that.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> + This document defines the binding for the QCE crypto
> + controller found on Qualcomm parts.
> +
> +properties:
> + compatible:
> + const: qcom,crypto-v5.1
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: iface clocks register interface.
> + - description: bus clocks data transfer interface.
> + - description: core clocks rest of the crypto block.
> +
> + clock-names:
> + items:
> + - const: iface
> + - const: bus
> + - const: core
> +
> + dmas:
> + items:
> + - description: DMA specifiers for rx dma channel.
> + - description: DMA specifiers for tx dma channel.
> +
> + dma-names:
> + items:
> + - const: rx
> + - const: tx
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-apq8084.h>
> + crypto-engine@fd45a000 {
> + compatible = "qcom,crypto-v5.1";
> + reg = <0xfd45a000 0x6000>;
> + clocks = <&gcc GCC_CE2_AHB_CLK>,
> + <&gcc GCC_CE2_AXI_CLK>,
> + <&gcc GCC_CE2_CLK>;
> + clock-names = "iface", "bus", "core";
> + dmas = <&cryptobam 2>, <&cryptobam 3>;
> + dma-names = "rx", "tx";
> + };
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-11-13 19:41 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 10:59 [PATCH v5 00/22] Enable Qualcomm Crypto Engine on sm8150 & sm8250 Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 01/22] arm64: dts: qcom: msm8996: Fix qcom,controlled-remotely property Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 02/22] arm64: dts: qcom: msm8996: Fix 'dma' nodes in dts Bhupesh Sharma
2021-11-17 5:53 ` Vinod Koul
2021-11-10 10:59 ` [PATCH v5 03/22] dt-bindings: qcom-bam: Convert binding to YAML Bhupesh Sharma
2021-11-10 19:44 ` Rob Herring
2021-11-15 6:04 ` Bhupesh Sharma
2021-11-12 8:41 ` Vladimir Zapolskiy
2021-11-15 6:00 ` Bhupesh Sharma
2021-11-13 19:13 ` Bjorn Andersson
2021-11-15 8:05 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 04/22] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties Bhupesh Sharma
2021-11-18 23:52 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 05/22] dt-bindings: qcom-bam: Add 'iommus' " Bhupesh Sharma
2021-11-18 23:52 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 06/22] dt-bindings: qcom-bam: Add "powered remotely" mode Bhupesh Sharma
2021-11-12 10:20 ` Vladimir Zapolskiy
2021-11-10 10:59 ` [PATCH v5 07/22] dt-bindings: qcom-qce: Convert bindings to yaml Bhupesh Sharma
2021-11-13 19:41 ` Bjorn Andersson [this message]
2021-11-10 10:59 ` [PATCH v5 08/22] dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' Bhupesh Sharma
2021-11-18 23:53 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 09/22] dt-bindings: qcom-qce: Move 'clocks' to optional properties Bhupesh Sharma
2021-11-13 20:02 ` Bjorn Andersson
2021-11-15 5:34 ` Bhupesh Sharma
2021-11-18 23:57 ` Rob Herring
2021-11-10 10:59 ` [PATCH v5 10/22] dt-bindings: qcom-qce: Add 'iommus' " Bhupesh Sharma
2021-11-13 21:23 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 11/22] dt-bindings: crypto : Add new compatible strings for qcom-qce Bhupesh Sharma
2021-11-12 10:25 ` Vladimir Zapolskiy
2021-11-15 5:28 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 12/22] arm64/dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
2021-11-12 10:26 ` Vladimir Zapolskiy
2021-11-15 5:04 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 13/22] dma: qcom: bam_dma: Add support to initialize interconnect path Bhupesh Sharma
2021-11-12 10:32 ` Vladimir Zapolskiy
2021-11-15 5:27 ` Bhupesh Sharma
2021-11-15 17:53 ` Bjorn Andersson
2022-05-12 23:39 ` Dmitry Baryshkov
2021-11-10 10:59 ` [PATCH v5 14/22] crypto: qce: core: " Bhupesh Sharma
2021-11-12 10:40 ` Vladimir Zapolskiy
2021-11-15 18:25 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 15/22] crypto: qce: Add new compatibles for qce crypto driver Bhupesh Sharma
2021-11-12 10:36 ` Vladimir Zapolskiy
2021-11-15 5:07 ` Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 16/22] crypto: qce: core: Make clocks optional Bhupesh Sharma
2021-11-15 18:06 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 17/22] crypto: qce: Print a failure msg in case probe() fails Bhupesh Sharma
2021-11-12 10:42 ` Vladimir Zapolskiy
2021-11-15 5:14 ` Bhupesh Sharma
2021-11-15 18:10 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 18/22] crypto: qce: Defer probing if BAM dma channel is not yet initialized Bhupesh Sharma
2021-11-15 18:29 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 19/22] crypto: qce: Add 'sm8250-qce' compatible string check Bhupesh Sharma
2021-11-15 18:32 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 20/22] crypto: qce: Add 'sm8150-qce' " Bhupesh Sharma
2021-11-10 10:59 ` [PATCH v5 21/22] arm64/dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
2021-11-15 18:34 ` Bjorn Andersson
2021-11-15 20:11 ` Bjorn Andersson
2021-11-10 10:59 ` [PATCH v5 22/22] arm64/dts: qcom: sm8150: " Bhupesh Sharma
2022-02-11 21:49 ` [PATCH v5 00/22] Enable Qualcomm Crypto Engine on sm8150 & sm8250 Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZAUzEGavOyhBcVm@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=stephan@gerhold.net \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).