From: Stephen Boyd <swboyd@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Brian Masney <masneyb@onstation.org>,
Lina Iyer <ilina@codeaurora.org>,
Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake()
Date: Tue, 21 Jan 2020 10:38:46 -0800 [thread overview]
Message-ID: <5e274537.1c69fb81.a77e7.08fd@mx.google.com> (raw)
In-Reply-To: <20200121183519.GP1511@yoga>
Quoting Bjorn Andersson (2020-01-21 10:35:19)
> On Tue 21 Jan 10:09 PST 2020, Stephen Boyd wrote:
>
> > __vfs_write+0x54/0x18c
> > vfs_write+0xe4/0x1a4
> > ksys_write+0x7c/0xe4
> > __arm64_sys_write+0x20/0x2c
> > el0_svc_common+0xa8/0x160
> > el0_svc_handler+0x7c/0x98
> > el0_svc+0x8/0xc
> >
> > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver")
>
> This lock used to protect the wake_irqs bitmap, and although your change
> indicates that the locking was wrong before this point I think the fixes
> should be:
>
> Fixes: 6aced33f4974 ("pinctrl: msm: drop wake_irqs bitmap")
>
>
> Either way, the patch looks good.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
Ok. Thanks for fixing the Fixes tag.
next prev parent reply other threads:[~2020-01-21 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 18:09 [PATCH] pinctrl: qcom: Don't lock around irq_set_irq_wake() Stephen Boyd
2020-01-21 18:35 ` Bjorn Andersson
2020-01-21 18:38 ` Stephen Boyd [this message]
2020-01-23 15:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e274537.1c69fb81.a77e7.08fd@mx.google.com \
--to=swboyd@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=mkshah@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).