From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Amit Kucheria <amit.kucheria@verdurent.com>,
Lukasz Luba <lukasz.luba@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Zhang Rui <rui.zhang@intel.com>,
Linux PM list <linux-pm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones
Date: Mon, 30 Mar 2020 15:07:53 +0200 [thread overview]
Message-ID: <693bda26-1eed-a886-2ce0-7b3a2ca410d2@linaro.org> (raw)
In-Reply-To: <CAHLCerMRcPmE70kN1Cyxio4_Dd1OoWT3iZ4vpzYKQVfORS336Q@mail.gmail.com>
Hi Amit,
On 30/03/2020 12:34, Amit Kucheria wrote:
[ ... ]
>>> I don't know why it's not consistent with the actual code in
>>> of-thermal.c, where there is even a comment stated: /* For now,
>>> thermal framework supports only 1 sensor per zone */
>>>
>>> I think this is the place where developers should be informed
>>> about the limitation and not even try to put more sensors into
>>> the list.
>>
>> That is a good point. I'm currently "porting" the existing
>> binding as described in thermal.txt to yaml. If you look at some
>> of the example (c) in there, the bindings allow many sensors to a
>> zone mapping but the thermal core doesn't implement that
>> functionality.
>>
>> So should we fix the core code or change the bindings? Thoughts -
>> Rob, Daniel, Rui?
>
> Rob, Daniel: Any comments? We don't have any concerns for Linux
> backward compatibility since multiple sensors per zone isn't used
> anywhere. But asking since bindings are supposed to be
> OS-agnostic.
IMO, we should remove it as it is not used anywhere.
We still have to decide how we aggregate multiple sensors.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-03-30 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 6:34 [PATCH v3 0/3] Convert thermal bindings to yaml Amit Kucheria
2020-03-25 6:34 ` [PATCH v3 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors Amit Kucheria
2020-03-31 21:14 ` Rob Herring
2020-03-25 6:34 ` [PATCH v3 2/3] dt-bindings: thermal: Add yaml bindings for thermal cooling-devices Amit Kucheria
2020-03-25 10:21 ` Lukasz Luba
2020-03-25 15:28 ` Amit Kucheria
2020-03-31 21:16 ` Rob Herring
2020-03-25 6:34 ` [PATCH v3 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones Amit Kucheria
2020-03-25 11:06 ` Lukasz Luba
2020-03-25 15:42 ` Amit Kucheria
2020-03-30 10:34 ` Amit Kucheria
2020-03-30 13:07 ` Daniel Lezcano [this message]
2020-03-31 21:13 ` Rob Herring
2020-03-31 21:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693bda26-1eed-a886-2ce0-7b3a2ca410d2@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mka@chromium.org \
--cc=rui.zhang@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).