From: Lukasz Luba <lukasz.luba@arm.com>
To: Amit Kucheria <amit.kucheria@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, mka@chromium.org, daniel.lezcano@linaro.org,
Amit Kucheria <amit.kucheria@verdurent.com>,
Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: thermal: Add yaml bindings for thermal cooling-devices
Date: Wed, 25 Mar 2020 10:21:14 +0000 [thread overview]
Message-ID: <a89df770-eeb9-e4f2-2a46-ee4389720597@arm.com> (raw)
In-Reply-To: <1ee4240e29edefc36b5d410d4792971c2bb4c5d5.1585117436.git.amit.kucheria@linaro.org>
Hi Amit,
On 3/25/20 6:34 AM, Amit Kucheria wrote:
> As part of moving the thermal bindings to YAML, split it up into 3
> bindings: thermal sensors, cooling devices and thermal zones.
>
> The property #cooling-cells is required in each device that acts as a
> cooling device - whether active or passive. So any device that can
> throttle its performance to passively reduce heat dissipation (e.g.
> cpus, gpus) and any device that can actively dissipate heat at different
> levels (e.g. fans) will contain this property.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> .../thermal/thermal-cooling-devices.yaml | 116 ++++++++++++++++++
> 1 file changed, 116 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> new file mode 100644
> index 000000000000..b5599f7859f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> @@ -0,0 +1,116 @@
> +# SPDX-License-Identifier: (GPL-2.0)
> +# Copyright 2020 Linaro Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/thermal-cooling-devices.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thermal cooling device binding
> +
> +maintainers:
> + - Amit Kucheria <amitk@kernel.org>
> +
> +description: |
> + Thermal management is achieved in devicetree by describing the sensor hardware
> + and the software abstraction of cooling devices and thermal zones required to
> + take appropriate action to mitigate thermal overload.
> +
> + The following node types are used to completely describe a thermal management
> + system in devicetree:
> + - thermal-sensor: device that measures temperature, has SoC-specific bindings
> + - cooling-device: device used to dissipate heat either passively or artively
> + - thermal-zones: a container of the following node types used to describe all
> + thermal data for the platform
> +
> + This binding describes the cooling devices.
> +
> + There are essentially two ways to provide control on power dissipation:
> + - Passive cooling: by means of regulating device performance. A typical
> + passive cooling mechanism is a CPU that has dynamic voltage and frequency
> + scaling (DVFS), and uses lower frequencies as cooling states.
> + - Active cooling: by means of activating devices in order to remove the
> + dissipated heat, e.g. regulating fan speeds.
> +
> + Any cooling device has a range of cooling states (i.e. different levels of
> + heat dissipation). They also have a way to determine the state of cooling in
> + which the device is. For example, a fan's cooling states correspond to the
> + different fan speeds possible. Cooling states are referred to by single
> + unsigned integers, where larger numbers mean greater heat dissipation. The
> + precise set of cooling states associated with a device should be defined in
> + a particular device's binding.
[snip]
> +
> + thermal-zones {
> + cpu0-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = <&tsens0 1>;
> +
> + trips {
> + cpu0_alert0: trip-point0 {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&cpu0_alert0>;
> + cooling-device = <&CPU0 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>;
Maybe add something like this, to better reflect the description:
trip = <&cpu0_alert0>;
/* Corresponds to 1000MHz in OPP table */
cooling-device = <&CPU0 5 5>;
This is less confusing than THERMAL_NO_LIMIT.
Regards,
Lukasz
next prev parent reply other threads:[~2020-03-25 10:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 6:34 [PATCH v3 0/3] Convert thermal bindings to yaml Amit Kucheria
2020-03-25 6:34 ` [PATCH v3 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors Amit Kucheria
2020-03-31 21:14 ` Rob Herring
2020-03-25 6:34 ` [PATCH v3 2/3] dt-bindings: thermal: Add yaml bindings for thermal cooling-devices Amit Kucheria
2020-03-25 10:21 ` Lukasz Luba [this message]
2020-03-25 15:28 ` Amit Kucheria
2020-03-31 21:16 ` Rob Herring
2020-03-25 6:34 ` [PATCH v3 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones Amit Kucheria
2020-03-25 11:06 ` Lukasz Luba
2020-03-25 15:42 ` Amit Kucheria
2020-03-30 10:34 ` Amit Kucheria
2020-03-30 13:07 ` Daniel Lezcano
2020-03-31 21:13 ` Rob Herring
2020-03-31 21:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89df770-eeb9-e4f2-2a46-ee4389720597@arm.com \
--to=lukasz.luba@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rui.zhang@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).