From: Stephen Boyd <sboyd@kernel.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: linux-kernel@vger.kernel.org, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, richardcochran@gmail.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, netdev@vger.kernel.org,
bmasney@redhat.com, echanude@redhat.com, ncai@quicinc.com,
jsuraj@qti.qualcomm.com, hisunil@quicinc.com
Subject: Re: [PATCH v5 3/3] arm64: dts: qcom: sa8540p-ride: Add ethernet nodes
Date: Thu, 13 Apr 2023 15:05:26 -0700 [thread overview]
Message-ID: <7b2b2eefb4b7b6ef8ac2a3176286a97b.sboyd@kernel.org> (raw)
In-Reply-To: <20230413210127.s5dkek6adp5ndern@halaney-x13s>
Quoting Andrew Halaney (2023-04-13 14:01:27)
> On Thu, Apr 13, 2023 at 01:47:19PM -0700, Stephen Boyd wrote:
> > Quoting Andrew Halaney (2023-04-13 12:15:41)
> > > arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 179 ++++++++++++++++++++++
> > > 1 file changed, 179 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> > > index 40db5aa0803c..650cd54f418e 100644
> > > --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> > > +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> > > @@ -28,6 +28,65 @@ aliases {
> > > chosen {
> > > stdout-path = "serial0:115200n8";
> > > };
> > > +
> > > + mtl_rx_setup: rx-queues-config {
> >
> > Is there a reason why this isn't a child of an ethernet node?
> >
> >
>
> I debated if it was more appropriate to:
>
> 1. make a duplicate in each ethernet node (ethernet0/1)
> 2. Put it in one and reference from both
> 3. have it floating around independent like this, similar to what is
> done in sa8155p-adp.dts[0]
>
> I chose 3 as it seemed cleanest, but if there's a good argument for a
> different approach I'm all ears!
I wonder if it allows the binding checker to catch bad properties by
having it under the ethernet node? That's the only thing I can think of
that may be improved, but I'll let binding reviewers comment here.
next prev parent reply other threads:[~2023-04-13 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 19:15 [PATCH v5 0/3] Add EMAC3 support for sa8540p-ride (devicetree/clk bits) Andrew Halaney
2023-04-13 19:15 ` [PATCH v5 1/3] clk: qcom: gcc-sc8280xp: Add EMAC GDSCs Andrew Halaney
2023-04-13 19:15 ` [PATCH v5 2/3] arm64: dts: qcom: sc8280xp: Add ethernet nodes Andrew Halaney
2023-04-13 19:15 ` [PATCH v5 3/3] arm64: dts: qcom: sa8540p-ride: " Andrew Halaney
2023-04-13 20:47 ` Stephen Boyd
2023-04-13 21:01 ` Andrew Halaney
2023-04-13 22:05 ` Stephen Boyd [this message]
2023-04-14 14:58 ` Andrew Halaney
2023-04-24 14:42 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b2b2eefb4b7b6ef8ac2a3176286a97b.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=hisunil@quicinc.com \
--cc=jsuraj@qti.qualcomm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ncai@quicinc.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).