* [PATCH v3 0/3] Cleanup dtbs_check warnings for tsens
@ 2020-02-26 9:31 Amit Kucheria
2020-02-26 9:31 ` [PATCH v3 1/3] dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding Amit Kucheria
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Amit Kucheria @ 2020-02-26 9:31 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, vkoul, daniel.lezcano,
bjorn.andersson, sivaa, Andy Gross, Zhang Rui
Cc: Amit Kucheria, devicetree, linux-pm
Make dtbs_check pass for tsens bits. I'm working on another series to
cleanup other DT warnings for QC platforms.
Amit Kucheria (3):
dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding
dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi
compatible
dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi
compatible
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++--
3 files changed, 4 insertions(+), 3 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/3] dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding 2020-02-26 9:31 [PATCH v3 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria @ 2020-02-26 9:31 ` Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Amit Kucheria 2 siblings, 0 replies; 9+ messages in thread From: Amit Kucheria @ 2020-02-26 9:31 UTC (permalink / raw) To: linux-kernel, linux-arm-msm, vkoul, daniel.lezcano, bjorn.andersson, sivaa, Andy Gross, Zhang Rui Cc: Amit Kucheria, linux-pm, devicetree The qcom-tsens binding requires a SoC-specific and a TSENS family-specific binding to be specified in the compatible string. Since qcom,sc7180-tsens is not listed in the YAML binding, we see the following warnings in 'make dtbs_check'. Fix them. builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens', 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible causes of the failure): builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible: ['qcom,sc7180-tsens', 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible causes of the failure): builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:1: 'qcom,tsens-v0_1' was expected builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:1: 'qcom,tsens-v1' was expected Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> Reviewed-by: Vinod Koul <vkoul@kernel.org> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index eef13b9446a8..13e294328932 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -39,6 +39,7 @@ properties: - qcom,msm8996-tsens - qcom,msm8998-tsens - qcom,sdm845-tsens + - qcom,sc7180-tsens - const: qcom,tsens-v2 reg: -- 2.20.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible 2020-02-26 9:31 [PATCH v3 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 1/3] dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding Amit Kucheria @ 2020-02-26 9:31 ` Amit Kucheria 2020-02-26 16:00 ` Vinod Koul 2020-02-28 3:21 ` Bjorn Andersson 2020-02-26 9:31 ` [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Amit Kucheria 2 siblings, 2 replies; 9+ messages in thread From: Amit Kucheria @ 2020-02-26 9:31 UTC (permalink / raw) To: linux-kernel, linux-arm-msm, vkoul, daniel.lezcano, bjorn.andersson, sivaa, Andy Gross, Zhang Rui Cc: devicetree The qcom-tsens binding requires a SoC-specific and a TSENS family-specific binding to be specified in the compatible string. Since them family-specific binding is not listed in the .dtsi file, we see the following warnings in 'make dtbs_check'. Fix them. /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is not valid under any of the given schemas (Possible causes of the failure): /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is too short /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 9f31064f2374..1748ea3f4b4f 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -860,7 +860,7 @@ }; tsens: thermal-sensor@4a9000 { - compatible = "qcom,msm8916-tsens"; + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1"; reg = <0x4a9000 0x1000>, /* TM */ <0x4a8000 0x1000>; /* SROT */ nvmem-cells = <&tsens_caldata>, <&tsens_calsel>; -- 2.20.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible 2020-02-26 9:31 ` [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible Amit Kucheria @ 2020-02-26 16:00 ` Vinod Koul 2020-02-28 3:21 ` Bjorn Andersson 1 sibling, 0 replies; 9+ messages in thread From: Vinod Koul @ 2020-02-26 16:00 UTC (permalink / raw) To: Amit Kucheria Cc: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson, sivaa, Andy Gross, Zhang Rui, devicetree On 26-02-20, 15:01, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 9f31064f2374..1748ea3f4b4f 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -860,7 +860,7 @@ > }; > > tsens: thermal-sensor@4a9000 { > - compatible = "qcom,msm8916-tsens"; > + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1"; > reg = <0x4a9000 0x1000>, /* TM */ > <0x4a8000 0x1000>; /* SROT */ > nvmem-cells = <&tsens_caldata>, <&tsens_calsel>; > -- > 2.20.1 -- ~Vinod ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible 2020-02-26 9:31 ` [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible Amit Kucheria 2020-02-26 16:00 ` Vinod Koul @ 2020-02-28 3:21 ` Bjorn Andersson 1 sibling, 0 replies; 9+ messages in thread From: Bjorn Andersson @ 2020-02-28 3:21 UTC (permalink / raw) To: Amit Kucheria Cc: linux-kernel, linux-arm-msm, vkoul, daniel.lezcano, sivaa, Andy Gross, Zhang Rui, devicetree On Wed 26 Feb 01:31 PST 2020, Amit Kucheria wrote: $subject should be "arm64: dts: qcom: msm8916: ..." Apart from that this looks good. Regards, Bjorn > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8916-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8916-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 9f31064f2374..1748ea3f4b4f 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -860,7 +860,7 @@ > }; > > tsens: thermal-sensor@4a9000 { > - compatible = "qcom,msm8916-tsens"; > + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1"; > reg = <0x4a9000 0x1000>, /* TM */ > <0x4a8000 0x1000>; /* SROT */ > nvmem-cells = <&tsens_caldata>, <&tsens_calsel>; > -- > 2.20.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible 2020-02-26 9:31 [PATCH v3 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 1/3] dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible Amit Kucheria @ 2020-02-26 9:31 ` Amit Kucheria 2020-02-26 15:58 ` Vinod Koul ` (2 more replies) 2 siblings, 3 replies; 9+ messages in thread From: Amit Kucheria @ 2020-02-26 9:31 UTC (permalink / raw) To: linux-kernel, linux-arm-msm, vkoul, daniel.lezcano, bjorn.andersson, sivaa, Andy Gross, Zhang Rui Cc: devicetree The qcom-tsens binding requires a SoC-specific and a TSENS family-specific binding to be specified in the compatible string. Since them family-specific binding is not listed in the .dtsi file, we see the following warnings in 'make dtbs_check'. Fix them. /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid under any of the given schemas (Possible causes of the failure): /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid under any of the given schemas (Possible causes of the failure): /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 7ae082ea14ea..f157cd4f53b4 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -446,7 +446,7 @@ }; tsens0: thermal-sensor@4a9000 { - compatible = "qcom,msm8996-tsens"; + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; reg = <0x004a9000 0x1000>, /* TM */ <0x004a8000 0x1000>; /* SROT */ #qcom,sensors = <13>; @@ -457,7 +457,7 @@ }; tsens1: thermal-sensor@4ad000 { - compatible = "qcom,msm8996-tsens"; + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; reg = <0x004ad000 0x1000>, /* TM */ <0x004ac000 0x1000>; /* SROT */ #qcom,sensors = <8>; -- 2.20.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible 2020-02-26 9:31 ` [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Amit Kucheria @ 2020-02-26 15:58 ` Vinod Koul 2020-02-26 15:58 ` Vinod Koul 2020-02-28 3:24 ` Bjorn Andersson 2 siblings, 0 replies; 9+ messages in thread From: Vinod Koul @ 2020-02-26 15:58 UTC (permalink / raw) To: Amit Kucheria Cc: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson, sivaa, Andy Gross, Zhang Rui, devicetree On 26-02-20, 15:01, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 7ae082ea14ea..f157cd4f53b4 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -446,7 +446,7 @@ > }; > > tsens0: thermal-sensor@4a9000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004a9000 0x1000>, /* TM */ > <0x004a8000 0x1000>; /* SROT */ > #qcom,sensors = <13>; > @@ -457,7 +457,7 @@ > }; > > tsens1: thermal-sensor@4ad000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004ad000 0x1000>, /* TM */ > <0x004ac000 0x1000>; /* SROT */ > #qcom,sensors = <8>; > -- > 2.20.1 -- ~Vinod ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible 2020-02-26 9:31 ` [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Amit Kucheria 2020-02-26 15:58 ` Vinod Koul @ 2020-02-26 15:58 ` Vinod Koul 2020-02-28 3:24 ` Bjorn Andersson 2 siblings, 0 replies; 9+ messages in thread From: Vinod Koul @ 2020-02-26 15:58 UTC (permalink / raw) To: Amit Kucheria Cc: linux-kernel, linux-arm-msm, daniel.lezcano, bjorn.andersson, sivaa, Andy Gross, Zhang Rui, devicetree On 26-02-20, 15:01, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 7ae082ea14ea..f157cd4f53b4 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -446,7 +446,7 @@ > }; > > tsens0: thermal-sensor@4a9000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004a9000 0x1000>, /* TM */ > <0x004a8000 0x1000>; /* SROT */ > #qcom,sensors = <13>; > @@ -457,7 +457,7 @@ > }; > > tsens1: thermal-sensor@4ad000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004ad000 0x1000>, /* TM */ > <0x004ac000 0x1000>; /* SROT */ > #qcom,sensors = <8>; > -- > 2.20.1 -- ~Vinod ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible 2020-02-26 9:31 ` [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Amit Kucheria 2020-02-26 15:58 ` Vinod Koul 2020-02-26 15:58 ` Vinod Koul @ 2020-02-28 3:24 ` Bjorn Andersson 2 siblings, 0 replies; 9+ messages in thread From: Bjorn Andersson @ 2020-02-28 3:24 UTC (permalink / raw) To: Amit Kucheria Cc: linux-kernel, linux-arm-msm, vkoul, daniel.lezcano, sivaa, Andy Gross, Zhang Rui, devicetree On Wed 26 Feb 01:31 PST 2020, Amit Kucheria wrote: As with patch 2, $subject should have an appropriate prefix. Please update this. Regards, Bjorn > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since them family-specific binding is not listed in the .dtsi file, we > see the following warnings in 'make dtbs_check'. Fix them. > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4a9000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is not valid > under any of the given schemas (Possible causes of the failure): > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible: ['qcom,msm8996-tsens'] is too short > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > /home/amit/work/builds/build-aarch64/arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml: > thermal-sensor@4ad000: compatible:0: 'qcom,msm8996-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 7ae082ea14ea..f157cd4f53b4 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -446,7 +446,7 @@ > }; > > tsens0: thermal-sensor@4a9000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004a9000 0x1000>, /* TM */ > <0x004a8000 0x1000>; /* SROT */ > #qcom,sensors = <13>; > @@ -457,7 +457,7 @@ > }; > > tsens1: thermal-sensor@4ad000 { > - compatible = "qcom,msm8996-tsens"; > + compatible = "qcom,msm8996-tsens", "qcom,tsens-v2"; > reg = <0x004ad000 0x1000>, /* TM */ > <0x004ac000 0x1000>; /* SROT */ > #qcom,sensors = <8>; > -- > 2.20.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-28 3:24 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-26 9:31 [PATCH v3 0/3] Cleanup dtbs_check warnings for tsens Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 1/3] dt-bindings: thermal: tsens: Add entry for sc7180 tsens to binding Amit Kucheria 2020-02-26 9:31 ` [PATCH v3 2/3] dt-bindings: thermal: tsens: Add qcom,tsens-v0_1 to msm8916.dtsi compatible Amit Kucheria 2020-02-26 16:00 ` Vinod Koul 2020-02-28 3:21 ` Bjorn Andersson 2020-02-26 9:31 ` [PATCH v3 3/3] dt-bindings: thermal: tsens: Add qcom,tsens-v2 to msm8996.dtsi compatible Amit Kucheria 2020-02-26 15:58 ` Vinod Koul 2020-02-26 15:58 ` Vinod Koul 2020-02-28 3:24 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).