* [PATCH 0/9] drm/print: add and use drm_debug_enabled()
@ 2019-09-13 11:51 Jani Nikula
2019-09-13 11:51 ` [PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2019-09-13 11:51 UTC (permalink / raw)
To: dri-devel
Cc: jani.nikula, intel-gfx, Alex Deucher, Christian König,
David Zhou, amd-gfx, Ben Skeggs, nouveau, Rob Clark, Sean Paul,
linux-arm-msm, freedreno, Francisco Jerez, Lucas Stach,
Russell King, Christian Gmeiner, etnaviv
Hi all, just a little refactoring around drm_debug access to abstract it
better. There shouldn't be any functional changes.
I'd appreciate acks for merging the lot via drm-misc. If there are any
objections to that, we'll need to postpone the last patch until
everything has been merged and converted in drm-next.
BR,
Jani.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: David (ChunMing) Zhou <David1.Zhou@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: nouveau@lists.freedesktop.org
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Cc: Francisco Jerez <currojerez@riseup.net>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Russell King <linux+etnaviv@armlinux.org.uk>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: etnaviv@lists.freedesktop.org
Jani Nikula (9):
drm/print: move drm_debug variable to drm_print.[ch]
drm/print: add drm_debug_enabled()
drm/etnaviv: use drm_debug_enabled() to check for debug categories
drm/i2c/sil164: use drm_debug_enabled() to check for debug categories
drm/i915: use drm_debug_enabled() to check for debug categories
drm/msm: use drm_debug_enabled() to check for debug categories
drm/nouveau: use drm_debug_enabled() to check for debug categories
drm/amdgpu: use drm_debug_enabled() to check for debug categories
drm/print: rename drm_debug to __drm_debug to discourage use
drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++--
drivers/gpu/drm/drm_atomic_uapi.c | 2 +-
drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++---
drivers/gpu/drm/drm_drv.c | 17 ---------------
drivers/gpu/drm/drm_edid.c | 2 +-
drivers/gpu/drm/drm_edid_load.c | 2 +-
drivers/gpu/drm/drm_mipi_dbi.c | 4 ++--
drivers/gpu/drm/drm_print.c | 23 ++++++++++++++++++--
drivers/gpu/drm/drm_vblank.c | 6 ++---
drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 8 +++----
drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_gem.h | 2 +-
drivers/gpu/drm/i915/i915_utils.c | 2 +-
drivers/gpu/drm/i915/intel_pm.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++--
drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++--
drivers/gpu/drm/nouveau/nouveau_drv.h | 4 ++--
include/drm/drm_drv.h | 2 --
include/drm/drm_print.h | 8 +++++++
22 files changed, 60 insertions(+), 52 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories
2019-09-13 11:51 [PATCH 0/9] drm/print: add and use drm_debug_enabled() Jani Nikula
@ 2019-09-13 11:51 ` Jani Nikula
2019-09-14 15:46 ` Rob Clark
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2019-09-13 11:51 UTC (permalink / raw)
To: dri-devel
Cc: jani.nikula, intel-gfx, Rob Clark, Sean Paul, linux-arm-msm, freedreno
Allow better abstraction of the drm_debug global variable in the
future. No functional changes.
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
index 9e40f559c51f..00e3353f9aad 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
@@ -29,7 +29,7 @@
*/
#define DPU_DEBUG(fmt, ...) \
do { \
- if (unlikely(drm_debug & DRM_UT_KMS)) \
+ if (unlikely(drm_debug_enabled(DRM_UT_KMS))) \
DRM_DEBUG(fmt, ##__VA_ARGS__); \
else \
pr_debug(fmt, ##__VA_ARGS__); \
@@ -41,7 +41,7 @@
*/
#define DPU_DEBUG_DRIVER(fmt, ...) \
do { \
- if (unlikely(drm_debug & DRM_UT_DRIVER)) \
+ if (unlikely(drm_debug_enabled(DRM_UT_DRIVER))) \
DRM_ERROR(fmt, ##__VA_ARGS__); \
else \
pr_debug(fmt, ##__VA_ARGS__); \
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories
2019-09-13 11:51 ` [PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories Jani Nikula
@ 2019-09-14 15:46 ` Rob Clark
0 siblings, 0 replies; 3+ messages in thread
From: Rob Clark @ 2019-09-14 15:46 UTC (permalink / raw)
To: Jani Nikula
Cc: dri-devel, Intel Graphics Development, Sean Paul, linux-arm-msm,
freedreno
On Fri, Sep 13, 2019 at 4:52 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> Allow better abstraction of the drm_debug global variable in the
> future. No functional changes.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
I don't think this should conflict w/ anything, so land via drm-misc?
BR,
-R
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> index 9e40f559c51f..00e3353f9aad 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
> @@ -29,7 +29,7 @@
> */
> #define DPU_DEBUG(fmt, ...) \
> do { \
> - if (unlikely(drm_debug & DRM_UT_KMS)) \
> + if (unlikely(drm_debug_enabled(DRM_UT_KMS))) \
> DRM_DEBUG(fmt, ##__VA_ARGS__); \
> else \
> pr_debug(fmt, ##__VA_ARGS__); \
> @@ -41,7 +41,7 @@
> */
> #define DPU_DEBUG_DRIVER(fmt, ...) \
> do { \
> - if (unlikely(drm_debug & DRM_UT_DRIVER)) \
> + if (unlikely(drm_debug_enabled(DRM_UT_DRIVER))) \
> DRM_ERROR(fmt, ##__VA_ARGS__); \
> else \
> pr_debug(fmt, ##__VA_ARGS__); \
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-14 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-13 11:51 [PATCH 0/9] drm/print: add and use drm_debug_enabled() Jani Nikula
2019-09-13 11:51 ` [PATCH 6/9] drm/msm: use drm_debug_enabled() to check for debug categories Jani Nikula
2019-09-14 15:46 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).