From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Amit Pundir <amit.pundir@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dt <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits
Date: Thu, 4 Feb 2021 15:16:24 +0100 [thread overview]
Message-ID: <889e6ed8-133a-9416-be3b-5b2a97ea7fbb@somainline.org> (raw)
In-Reply-To: <1612426177-6611-1-git-send-email-amit.pundir@linaro.org>
Hi!
>vreg_l14a_1p88: ldo14 {
>+ regulator-min-microvolt = <1800000>;
>+ regulator-max-microvolt = <1800000>;
Should probably be renamed to vreg_l14a_1p8 then.
>+ ports {
>+ port@1 {
>+ endpoint {
>+ remote-endpoint = <&tianma_nt36672a_in_0>;
>+ data-lanes = <0 1 2 3>;
>+ };
>+ };
>+ };
The endpoint has a label, you can simply use &dsi0_out {};.
>+ vddpos-supply = <&lab>;
>+ vddneg-supply = <&ibb>;
With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]),
as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage.
Konrad
[1] https://lore.kernel.org/linux-arm-msm/20210119174421.226541-1-angelogioacchino.delregno@somainline.org/
[2] https://github.com/SoMainline/linux/commit/4f4853b2e252b5f9d03e90119110aac80258fc53
next prev parent reply other threads:[~2021-02-04 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:09 [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits Amit Pundir
2021-02-04 14:16 ` Konrad Dybcio [this message]
2021-02-05 13:15 ` Amit Pundir
2021-02-08 14:41 ` Konrad Dybcio
2021-02-10 8:21 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=889e6ed8-133a-9416-be3b-5b2a97ea7fbb@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).