From: Zijun Hu <zijuhu@codeaurora.org>
To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-arm-msm@vger.kernel.org, c-hbandi@codeaurora.org,
hemantg@codeaurora.org, rjliao@codeaurora.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH v1] Bluetooth: hci_h4: Fix padding calculation error within h4_recv_buf()
Date: Sun, 14 Nov 2021 20:46:25 +0800 [thread overview]
Message-ID: <97e8c186-3c4f-a3ff-8389-e15ea476280e@codeaurora.org> (raw)
In-Reply-To: <1636546159-8339-1-git-send-email-zijuhu@codeaurora.org>
could you please code review for this patch?
On 11/10/2021 8:09 PM, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> it is erroneous to calculate padding by subtracting length of type
> indication from skb->len, it will cause data analysis error for
> alignment which is greater than 1, so fixed by adding length of type
> indication with skb->len.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
> drivers/bluetooth/hci_h4.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c
> index 4b3b14a34794..1d0cdf023243 100644
> --- a/drivers/bluetooth/hci_h4.c
> +++ b/drivers/bluetooth/hci_h4.c
> @@ -252,7 +252,7 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
> }
>
> if (!dlen) {
> - hu->padding = (skb->len - 1) % alignment;
> + hu->padding = (skb->len + 1) % alignment;
> hu->padding = (alignment - hu->padding) % alignment;
>
> /* No more data, complete frame */
> @@ -260,7 +260,7 @@ struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
> skb = NULL;
> }
> } else {
> - hu->padding = (skb->len - 1) % alignment;
> + hu->padding = (skb->len + 1) % alignment;
> hu->padding = (alignment - hu->padding) % alignment;
>
> /* Complete frame */
>
prev parent reply other threads:[~2021-11-14 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:09 [PATCH v1] Bluetooth: hci_h4: Fix padding calculation error within h4_recv_buf() Zijun Hu
2021-11-14 12:46 ` Zijun Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e8c186-3c4f-a3ff-8389-e15ea476280e@codeaurora.org \
--to=zijuhu@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_zijuhu@quicinc.com \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).