[PATCH v5 0/3] SDM670 GPI DMA support

[PATCH v5 0/3] SDM670 GPI DMA support

[Richard Acayan]

Changes since v4:
 - drop dts patch (to be sent separately)
 - accumulate review tags

Changes since v3:
 - keep other compatible strings in driver and add comment
 - accumulate review tags

Changes since v2:
 - change fallback to sdm845 compat string (and keep compat string in
   driver)
 - fallback now only affects two SoCs + SDM670

Changes since v1:
 - add fallback compatible

This patch series adds the compatible string for GPI DMA, needed for the
GENI interface, on Snapdragon 670.

Richard Acayan (3):
  dt-bindings: dma: qcom: gpi: add fallback compatible
  dt-bindings: dma: qcom: gpi: add compatible for sdm670
  dmaengine: qcom: deprecate redundant of_device_id entries

 .../devicetree/bindings/dma/qcom,gpi.yaml     | 22 ++++++++++++-------
 drivers/dma/qcom/gpi.c                        |  4 ++++
 2 files changed, 18 insertions(+), 8 deletions(-)

-- 
2.38.0

[PATCH v5 1/3] dt-bindings: dma: qcom: gpi: add fallback compatible

[Richard Acayan]

The drivers are transitioning from matching against lists of specific
compatible strings to matching against smaller lists of more generic
compatible strings. Use the SDM845 compatible string as a fallback in
the schema to support this change.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/dma/qcom,gpi.yaml     | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index eabf8a76d3a0..081b8a2d393d 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -18,14 +18,19 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - qcom,sc7280-gpi-dma
-      - qcom,sdm845-gpi-dma
-      - qcom,sm6350-gpi-dma
-      - qcom,sm8150-gpi-dma
-      - qcom,sm8250-gpi-dma
-      - qcom,sm8350-gpi-dma
-      - qcom,sm8450-gpi-dma
+    oneOf:
+      - enum:
+          - qcom,sc7280-gpi-dma
+          - qcom,sdm845-gpi-dma
+          - qcom,sm6350-gpi-dma
+          - qcom,sm8350-gpi-dma
+          - qcom,sm8450-gpi-dma
+
+      - items:
+          - enum:
+              - qcom,sm8150-gpi-dma
+              - qcom,sm8250-gpi-dma
+          - const: qcom,sdm845-gpi-dma
 
   reg:
     maxItems: 1
-- 
2.38.0

[PATCH v5 2/3] dt-bindings: dma: qcom: gpi: add compatible for sdm670

[Richard Acayan]

The Snapdragon 670 uses GPI DMA for its GENI interface. Add a compatible
string for it in the documentation.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index 081b8a2d393d..750b40c32213 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -28,6 +28,7 @@ properties:
 
       - items:
           - enum:
+              - qcom,sdm670-gpi-dma
               - qcom,sm8150-gpi-dma
               - qcom,sm8250-gpi-dma
           - const: qcom,sdm845-gpi-dma
-- 
2.38.0

[PATCH v5 3/3] dmaengine: qcom: deprecate redundant of_device_id entries

[Richard Acayan]

The drivers are transitioning from matching against lists of specific
compatible strings to matching against smaller lists of more generic
compatible strings. Add a message that the compatible strings with an
ee_offset of 0 are deprecated except for the SDM845 compatible string.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/dma/qcom/gpi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 89839864b4ec..ff22f5725ded 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2289,6 +2289,10 @@ static const struct of_device_id gpi_of_match[] = {
 	{ .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
 	{ .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
+	/*
+	 * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as
+	 * fallback and not need their own entries here.
+	 */
 	{ .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
-- 
2.38.0

Re: [PATCH v5 0/3] SDM670 GPI DMA support

[Richard Acayan]

> Changes since v4:
>  - drop dts patch (to be sent separately)

Hmm, [1] still includes it. Maybe it doesn't make sense to do this, and maybe
I should split the dts patch.

[1] https://lore.kernel.org/linux-arm-msm/20221015140447.55221-1-krzysztof.kozlowski@linaro.org/T/

>  - accumulate review tags
> 
> Changes since v3:
>  - keep other compatible strings in driver and add comment
>  - accumulate review tags
> 
> Changes since v2:
>  - change fallback to sdm845 compat string (and keep compat string in
>    driver)
>  - fallback now only affects two SoCs + SDM670
> 
> Changes since v1:
>  - add fallback compatible
> 
> This patch series adds the compatible string for GPI DMA, needed for the
> GENI interface, on Snapdragon 670.
> 
> Richard Acayan (3):
>   dt-bindings: dma: qcom: gpi: add fallback compatible
>   dt-bindings: dma: qcom: gpi: add compatible for sdm670
>   dmaengine: qcom: deprecate redundant of_device_id entries
> 
>  .../devicetree/bindings/dma/qcom,gpi.yaml     | 22 ++++++++++++-------
>  drivers/dma/qcom/gpi.c                        |  4 ++++
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 
> -- 
> 2.38.0
> 

Re: [PATCH v5 1/3] dt-bindings: dma: qcom: gpi: add fallback compatible

[Krzysztof Kozlowski]

On 07/10/2022 17:36, Richard Acayan wrote:
> The drivers are transitioning from matching against lists of specific
> compatible strings to matching against smaller lists of more generic
> compatible strings. Use the SDM845 compatible string as a fallback in
> the schema to support this change.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/dma/qcom,gpi.yaml     | 21 ++++++++++++-------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index eabf8a76d3a0..081b8a2d393d 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -18,14 +18,19 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,sc7280-gpi-dma
> -      - qcom,sdm845-gpi-dma
> -      - qcom,sm6350-gpi-dma
> -      - qcom,sm8150-gpi-dma
> -      - qcom,sm8250-gpi-dma
> -      - qcom,sm8350-gpi-dma
> -      - qcom,sm8450-gpi-dma
> +    oneOf:
> +      - enum:
> +          - qcom,sc7280-gpi-dma
> +          - qcom,sdm845-gpi-dma
> +          - qcom,sm6350-gpi-dma
> +          - qcom,sm8350-gpi-dma
> +          - qcom,sm8450-gpi-dma
> +

Drop the empty line, please.

Best regards,
Krzysztof