* [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get()
@ 2020-09-23 23:24 Abhinav Kumar
2020-09-24 6:32 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Abhinav Kumar @ 2020-09-23 23:24 UTC (permalink / raw)
To: dri-devel
Cc: Abhinav Kumar, freedreno, linux-arm-msm, robdclark, seanpaul,
swboyd, nganji, aravindh, tanmay, khsieh, kernel test robot
Fix the incorrect function prototype for dp_debug_get()
in the dp_debug module to address compilation warning.
Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
---
drivers/gpu/drm/msm/dp/dp_debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_debug.h b/drivers/gpu/drm/msm/dp/dp_debug.h
index 377e166fd0ea..7eaedfbb149c 100644
--- a/drivers/gpu/drm/msm/dp/dp_debug.h
+++ b/drivers/gpu/drm/msm/dp/dp_debug.h
@@ -60,7 +60,7 @@ void dp_debug_put(struct dp_debug *dp_debug);
static inline
struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
struct dp_usbpd *usbpd, struct dp_link *link,
- struct drm_connector **connector)
+ struct drm_connector **connector, struct drm_minor *minor)
{
return ERR_PTR(-EINVAL);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get()
2020-09-23 23:24 [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get() Abhinav Kumar
@ 2020-09-24 6:32 ` Stephen Boyd
2020-09-24 18:06 ` abhinavk
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-09-24 6:32 UTC (permalink / raw)
To: Abhinav Kumar, dri-devel
Cc: Abhinav Kumar, freedreno, linux-arm-msm, robdclark, seanpaul,
nganji, aravindh, tanmay, khsieh, kernel test robot
Quoting Abhinav Kumar (2020-09-23 16:24:48)
> Fix the incorrect function prototype for dp_debug_get()
> in the dp_debug module to address compilation warning.
>
> Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Will the compliance testing parts be moved out of debugfs at some point?
Just curious what the plan is there.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get()
2020-09-24 6:32 ` Stephen Boyd
@ 2020-09-24 18:06 ` abhinavk
0 siblings, 0 replies; 3+ messages in thread
From: abhinavk @ 2020-09-24 18:06 UTC (permalink / raw)
To: Stephen Boyd
Cc: dri-devel, kernel test robot, linux-arm-msm, khsieh, seanpaul,
tanmay, aravindh, freedreno
Hi Stephen
Thanks for the review.
On 2020-09-23 23:32, Stephen Boyd wrote:
> Quoting Abhinav Kumar (2020-09-23 16:24:48)
>> Fix the incorrect function prototype for dp_debug_get()
>> in the dp_debug module to address compilation warning.
>>
>> Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to
>> /sys/kernel/debug/dri/*/")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
>> ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> Will the compliance testing parts be moved out of debugfs at some
> point?
> Just curious what the plan is there.
No, the video pattern compliance testing parts will remain in debugfs as
they use
IGT as the userspace entity which is debugfs based for DP compliance
tests.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-24 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 23:24 [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get() Abhinav Kumar
2020-09-24 6:32 ` Stephen Boyd
2020-09-24 18:06 ` abhinavk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).