Re: Sierra Wireless EM9191 integration issues in mhi+wwan

[Aleksander Morgado <aleksander@aleksander.es>]

> > > > [    7.189547] mhi mhi0: Transitioning from PM state: Linkdown or
> > > > Error Fatal Detect to: SYS ERROR Process
> > >
> > > Hmm, I think the use of sync_power_up might be causing the issue here as it
> > > forces the MHI state to fatal error.
> > >
> > > Ignore the previous diff and try the below one:
> > >
> > > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> > > index 59a4896a8030..b1e8c7de4e54 100644
> > > --- a/drivers/bus/mhi/pci_generic.c
> > > +++ b/drivers/bus/mhi/pci_generic.c
> > > @@ -637,7 +637,7 @@ static void mhi_pci_recovery_work(struct work_struct *work)
> > >         if (err)
> > >                 goto err_try_reset;
> > >
> > > -       err = mhi_sync_power_up(mhi_cntrl);
> > > +       err = mhi_async_power_up(mhi_cntrl);
>
> Doh! Sorry, I modified the wrong function. Here is the correct one:
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 59a4896a8030..1e3c74bfbe34 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -743,7 +743,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>                 goto err_unregister;
>         }
>
> -       err = mhi_sync_power_up(mhi_cntrl);
> +       err = mhi_async_power_up(mhi_cntrl);
>         if (err) {
>                 dev_err(&pdev->dev, "failed to power up MHI controller\n");
>                 goto err_unprepare;
>
> Let's see how it goes :)
>

Oh, wow, what a difference a single extra byte in the correct place makes! :D

This looks waaaaay better; I've rebooted the board at least 10 times
now and all of them worked nicely, at least just the process to probe
the device and get the control and net ports exposed looks very
reliable now. I'll test the setup with ModemManager in the next days
and see how everything goes. Thank you very much!

[    0.099778] brcm-pcie fd500000.pcie: host bridge /scb/pcie@7d500000 ranges:
[    0.099801] brcm-pcie fd500000.pcie:   No bus range found for
/scb/pcie@7d500000, using [bus 00-ff]
[    0.099839] brcm-pcie fd500000.pcie:      MEM
0x0600000000..0x0603ffffff -> 0x00f8000000
[    0.099891] brcm-pcie fd500000.pcie:   IB MEM
0x0000000000..0x00bfffffff -> 0x0000000000
[    0.149936] brcm-pcie fd500000.pcie: link up, 5 GT/s x1 (SSC)
[    0.150094] brcm-pcie fd500000.pcie: PCI host bridge to bus 0000:00
[    0.150113] pci_bus 0000:00: root bus resource [bus 00-ff]
[    0.150131] pci_bus 0000:00: root bus resource [mem
0x600000000-0x603ffffff] (bus address [0xf8000000-0xfbffffff])
[    0.150172] pci 0000:00:00.0: [14e4:2711] type 01 class 0x060400
[    0.150263] pci 0000:00:00.0: PME# supported from D0 D3hot
[    0.153442] pci 0000:00:00.0: bridge configuration invalid ([bus
ff-ff]), reconfiguring
[    0.153565] pci 0000:01:00.0: [17cb:0306] type 00 class 0xff0000
[    0.153627] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x00000fff 64bit]
[    0.153657] pci 0000:01:00.0: reg 0x18: [mem 0x00000000-0x00000fff 64bit]
[    0.153815] pci 0000:01:00.0: PME# supported from D0 D3hot D3cold
[    0.153867] pci 0000:01:00.0: 4.000 Gb/s available PCIe bandwidth,
limited by 5 GT/s x1 link at 0000:00:00.0 (capable of 31.506 Gb/s with
16 GT/s x2 link)
[    0.156925] pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01
[    0.156963] pci 0000:00:00.0: BAR 8: assigned [mem 0x600000000-0x6000fffff]
[    0.156985] pci 0000:01:00.0: BAR 0: assigned [mem
0x600000000-0x600000fff 64bit]
[    0.157016] pci 0000:01:00.0: BAR 2: assigned [mem
0x600001000-0x600001fff 64bit]
[    0.157045] pci 0000:00:00.0: PCI bridge to [bus 01]
[    0.157060] pci 0000:00:00.0:   bridge window [mem 0x600000000-0x6000fffff]
[    0.157204] pcieport 0000:00:00.0: enabling device (0000 -> 0002)
[    0.157322] pcieport 0000:00:00.0: PME: Signaling with IRQ 38
[    0.157550] pcieport 0000:00:00.0: AER: enabled with IRQ 38
[    7.054135] mhi-pci-generic 0000:01:00.0: MHI PCI device found: sierra-em919x
[    7.061303] mhi-pci-generic 0000:01:00.0: BAR 0: assigned [mem
0x600000000-0x600000fff 64bit]
[    7.069852] mhi-pci-generic 0000:01:00.0: enabling device (0000 -> 0002)
[    7.076642] mhi-pci-generic 0000:01:00.0: using shared MSI
[    7.082916] mhi mhi0: Requested to power ON
[    7.087228] mhi mhi0: Attempting power on with EE: PASS THROUGH,
state: SYS ERROR
[    7.094732] mhi mhi0: local ee: INVALID_EE state: RESET device ee:
PASS THROUGH state: SYS ERROR
[    7.103513] mhi mhi0: System error detected
[    7.107695] mhi-pci-generic 0000:01:00.0: firmware crashed (7)
[    7.113584] mhi mhi0: Handling state transition: SYS ERROR
[    7.119072] mhi mhi0: Transitioning from PM state: SYS ERROR Detect
to: SYS ERROR Process
[    7.127249] mhi-pci-generic 0000:01:00.0: firmware crashed (6)
[   14.646025] mhi mhi0: local ee: PASS THROUGH state: RESET device
ee: MISSION MODE state: READY
[   14.654700] mhi mhi0: Power on setup success
[   14.654712] mhi mhi0: Triggering MHI Reset in device
[   39.907896] mhi mhi0: Waiting for all pending event ring processing
to complete
[   39.915245] mhi mhi0: Waiting for all pending threads to complete
[   39.921363] mhi mhi0: Reset all active channels and remove MHI devices
[   39.927909] mhi mhi0: Resetting EV CTXT and CMD CTXT
[   39.932898] mhi mhi0: Exiting with PM state: SYS ERROR Process, MHI
state: RESET
[   39.940493] mhi mhi0: Handling state transition: PBL
[   39.945480] mhi mhi0: Device MHI is not in valid state
[   39.950633] mhi mhi0: Handling state transition: READY
[   39.955789] mhi mhi0: Device in READY State
[   39.959985] mhi mhi0: Initializing MHI registers
[   40.072692] mhi mhi0: State change event to state: M0
[   40.072714] mhi mhi0: local ee: MISSION MODE state: READY device
ee: MISSION MODE state: M0
[   40.086132] mhi mhi0: Received EE event: MISSION MODE
[   40.086135] mhi mhi0: local ee: MISSION MODE state: M0 device ee:
MISSION MODE state: M0
[   40.099321] mhi mhi0: Handling state transition: MISSION MODE
[   40.105093] mhi mhi0: Processing Mission Mode transition
[   40.111360] mhi-pci-generic 0000:01:00.0: failed to suspend device: -16
[   40.118190] mhi_net mhi0_IP_HW0: 100: Updating channel state to: START
[   40.142376] mhi_net mhi0_IP_HW0: 100: Channel state change to START
successful
[   40.142379] mhi mhi0: local ee: MISSION MODE state: M0 device ee:
MISSION MODE state: M0
[   40.157833] mhi_net mhi0_IP_HW0: 101: Updating channel state to: START
[   40.176197] mhi_net mhi0_IP_HW0: 101: Channel state change to START
successful
[   40.176200] mhi mhi0: local ee: MISSION MODE state: M0 device ee:
MISSION MODE state: M0
[   42.595902] mhi mhi0: Allowing M3 transition
[   42.600217] mhi mhi0: Waiting for M3 completion
[   42.615163] mhi mhi0: State change event to state: M3
[   42.615184] mhi mhi0: local ee: MISSION MODE state: M0 device ee:
MISSION MODE state: M3


-- 
Aleksander
https://aleksander.es