linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aleksander Morgado <aleksander@aleksander.es>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Loic Poulain <loic.poulain@linaro.org>,
	Thomas Perrot <thomas.perrot@bootlin.com>,
	Hemant Kumar <hemantk@codeaurora.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: Re: Sierra Wireless EM9191 integration issues in mhi+wwan
Date: Tue, 2 Nov 2021 17:13:58 +0100	[thread overview]
Message-ID: <CAAP7ucLVtOR7+NJiWK_is0yv+zWKB9vmxpy4PyO5FQdVUE6uzA@mail.gmail.com> (raw)
In-Reply-To: <20211102105035.GB5646@thinkpad>

Hey Mani,

> > [    7.189547] mhi mhi0: Transitioning from PM state: Linkdown or
> > Error Fatal Detect to: SYS ERROR Process
>
> Hmm, I think the use of sync_power_up might be causing the issue here as it
> forces the MHI state to fatal error.
>
> Ignore the previous diff and try the below one:
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 59a4896a8030..b1e8c7de4e54 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -637,7 +637,7 @@ static void mhi_pci_recovery_work(struct work_struct *work)
>         if (err)
>                 goto err_try_reset;
>
> -       err = mhi_sync_power_up(mhi_cntrl);
> +       err = mhi_async_power_up(mhi_cntrl);
>         if (err)
>                 goto err_unprepare;
>

Same thing I think, see the logs below:

root@OpenWrt:~# dmesg | grep -E "mhi|pci"
[    0.099139] brcm-pcie fd500000.pcie: host bridge /scb/pcie@7d500000 ranges:
[    0.099163] brcm-pcie fd500000.pcie:   No bus range found for
/scb/pcie@7d500000, using [bus 00-ff]
[    0.099200] brcm-pcie fd500000.pcie:      MEM
0x0600000000..0x0603ffffff -> 0x00f8000000
[    0.099234] brcm-pcie fd500000.pcie:   IB MEM
0x0000000000..0x00bfffffff -> 0x0000000000
[    0.145977] brcm-pcie fd500000.pcie: link up, 5 GT/s x1 (SSC)
[    0.146136] brcm-pcie fd500000.pcie: PCI host bridge to bus 0000:00
[    0.146155] pci_bus 0000:00: root bus resource [bus 00-ff]
[    0.146173] pci_bus 0000:00: root bus resource [mem
0x600000000-0x603ffffff] (bus address [0xf8000000-0xfbffffff])
[    0.146214] pci 0000:00:00.0: [14e4:2711] type 01 class 0x060400
[    0.146305] pci 0000:00:00.0: PME# supported from D0 D3hot
[    0.149482] pci 0000:00:00.0: bridge configuration invalid ([bus
ff-ff]), reconfiguring
[    0.149605] pci 0000:01:00.0: [17cb:0306] type 00 class 0xff0000
[    0.149667] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x00000fff 64bit]
[    0.149698] pci 0000:01:00.0: reg 0x18: [mem 0x00000000-0x00000fff 64bit]
[    0.149856] pci 0000:01:00.0: PME# supported from D0 D3hot D3cold
[    0.149906] pci 0000:01:00.0: 4.000 Gb/s available PCIe bandwidth,
limited by 5 GT/s x1 link at 0000:00:00.0 (capable of 31.506 Gb/s with
16 GT/s x2 link)
[    0.152957] pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01
[    0.152995] pci 0000:00:00.0: BAR 8: assigned [mem 0x600000000-0x6000fffff]
[    0.153017] pci 0000:01:00.0: BAR 0: assigned [mem
0x600000000-0x600000fff 64bit]
[    0.153047] pci 0000:01:00.0: BAR 2: assigned [mem
0x600001000-0x600001fff 64bit]
[    0.153077] pci 0000:00:00.0: PCI bridge to [bus 01]
[    0.153092] pci 0000:00:00.0:   bridge window [mem 0x600000000-0x6000fffff]
[    0.153237] pcieport 0000:00:00.0: enabling device (0000 -> 0002)
[    0.153354] pcieport 0000:00:00.0: PME: Signaling with IRQ 38
[    0.153579] pcieport 0000:00:00.0: AER: enabled with IRQ 38
[    7.068355] mhi-pci-generic 0000:01:00.0: MHI PCI device found: sierra-em919x
[    7.075535] mhi-pci-generic 0000:01:00.0: BAR 0: assigned [mem
0x600000000-0x600000fff 64bit]
[    7.084077] mhi-pci-generic 0000:01:00.0: enabling device (0000 -> 0002)
[    7.090865] mhi-pci-generic 0000:01:00.0: using shared MSI
[    7.096975] mhi mhi0: Requested to power ON
[    7.101275] mhi mhi0: Attempting power on with EE: PASS THROUGH,
state: SYS ERROR
[    7.143799] mhi mhi0: local ee: INVALID_EE state: RESET device ee:
PASS THROUGH state: SYS ERROR
[    7.152590] mhi mhi0: System error detected
[    7.156796] mhi-pci-generic 0000:01:00.0: firmware crashed (7)
[    7.162671] mhi mhi0: Power on setup success
[    7.166957] mhi mhi0: Handling state transition: SYS ERROR
[    7.172442] mhi mhi0: Transitioning from PM state: Linkdown or
Error Fatal Detect to: SYS ERROR Process
[    7.181832] mhi-pci-generic 0000:01:00.0: firmware crashed (6)
[    7.187661] mhi mhi0: Failed to transition from PM state: Linkdown
or Error Fatal Detect to: SYS ERROR Process
[    7.197659] mhi mhi0: Exiting with PM state: Linkdown or Error
Fatal Detect, MHI state: RESET
[    7.206180] mhi mhi0: Handling state transition: PBL
[    7.211140] mhi mhi0: Device MHI is not in valid state
[    7.216273] mhi mhi0: Handling state transition: DISABLE
[    7.221580] mhi mhi0: Processing disable transition with PM state:
Linkdown or Error Fatal Detect
[    7.230449] mhi mhi0: Waiting for all pending event ring processing
to complete
[    7.237762] mhi mhi0: Waiting for all pending threads to complete
[    7.243851] mhi mhi0: Reset all active channels and remove MHI devices
[    7.250374] mhi mhi0: Resetting EV CTXT and CMD CTXT
[    7.255335] mhi mhi0: Exiting with PM state: DISABLE, MHI state: RESET
[    7.261895] mhi-pci-generic 0000:01:00.0: failed to power up MHI controller
[    7.269057] mhi-pci-generic: probe of 0000:01:00.0 failed with error -110


-- 
Aleksander
https://aleksander.es

  reply	other threads:[~2021-11-02 16:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 13:04 Sierra Wireless EM9191 integration issues in mhi+wwan Aleksander Morgado
2021-10-09 10:51 ` Manivannan Sadhasivam
2021-10-12 19:38   ` Aleksander Morgado
2021-10-22  4:42     ` Manivannan Sadhasivam
2021-10-22  9:20       ` Aleksander Morgado
2021-10-22 14:40         ` Manivannan Sadhasivam
2021-10-25  8:10           ` Aleksander Morgado
2021-11-02 10:50             ` Manivannan Sadhasivam
2021-11-02 16:13               ` Aleksander Morgado [this message]
2021-11-02 16:22                 ` Manivannan Sadhasivam
2021-11-02 16:55                   ` Aleksander Morgado
2021-11-02 18:09                     ` Manivannan Sadhasivam
     [not found]                       ` <CAMZdPi9+zrsDy9WTipamRWBXMOxUX1tfsk2W52b9wG-4q21fWA@mail.gmail.com>
2021-11-04 22:50                         ` Bhaumik Bhatt
2021-11-08  7:40                       ` Manivannan Sadhasivam
2021-11-08 13:38                         ` Aleksander Morgado
2021-10-11 14:44 ` Thomas Perrot
2021-10-12 19:44   ` Aleksander Morgado
2021-10-14  9:51     ` Thomas Perrot
2021-10-14 10:04       ` Aleksander Morgado
2021-10-14 17:28         ` Loic Poulain
2021-10-14 20:25           ` Aleksander Morgado
2021-10-18  9:14             ` Aleksander Morgado
2021-10-18  9:59               ` Loic Poulain
2021-10-18 11:26                 ` Thomas Perrot
2021-10-18 12:46                   ` Loic Poulain
2021-10-18 14:07                     ` Thomas Perrot
2021-10-18 14:16                       ` Thomas Perrot
2021-10-19  8:38                       ` Aleksander Morgado
2021-10-20  8:43                         ` Aleksander Morgado
2021-10-22 14:33                     ` Aleksander Morgado
2021-11-08 15:11   ` Aleksander Morgado
2021-11-08 16:31     ` Thomas Perrot
2021-11-08 20:16       ` Aleksander Morgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAP7ucLVtOR7+NJiWK_is0yv+zWKB9vmxpy4PyO5FQdVUE6uzA@mail.gmail.com \
    --to=aleksander@aleksander.es \
    --cc=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=thomas.perrot@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).