* [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets
@ 2021-11-04 17:08 Bjorn Andersson
2021-11-06 17:08 ` Vladimir Zapolskiy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-11-04 17:08 UTC (permalink / raw)
To: Linus Walleij, Vinod Koul
Cc: vladimir.zapolskiy, linux-arm-msm, linux-gpio, linux-kernel
The downstream TLMM binding covers a group of TLMM-related hardware
blocks, but the upstream binding only captures the particular block
related to controlling the TLMM pins from an OS. In the translation of
the driver from downstream, the offset of 0x100000 was lost for the UFS
and SDC pingroups.
Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
index 4d8f8636c2b3..1c042d39380c 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
@@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
- [203] = UFS_RESET(ufs_reset, 0x1d8000),
- [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
- [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
- [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
+ [203] = UFS_RESET(ufs_reset, 0xd8000),
+ [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
+ [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
+ [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
};
static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
--
2.33.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets
2021-11-04 17:08 [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets Bjorn Andersson
@ 2021-11-06 17:08 ` Vladimir Zapolskiy
2021-11-09 7:12 ` Vinod Koul
2021-11-09 20:21 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2021-11-06 17:08 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Vinod Koul
Cc: linux-arm-msm, linux-gpio, linux-kernel
On 11/4/21 7:08 PM, Bjorn Andersson wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> index 4d8f8636c2b3..1c042d39380c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
> [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
> [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
> [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
> - [203] = UFS_RESET(ufs_reset, 0x1d8000),
> - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
> - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
> - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
> + [203] = UFS_RESET(ufs_reset, 0xd8000),
> + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
> + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
> + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
> };
>
> static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets
2021-11-04 17:08 [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets Bjorn Andersson
2021-11-06 17:08 ` Vladimir Zapolskiy
@ 2021-11-09 7:12 ` Vinod Koul
2021-11-09 20:21 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-11-09 7:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Linus Walleij, vladimir.zapolskiy, linux-arm-msm, linux-gpio,
linux-kernel
On 04-11-21, 10:08, Bjorn Andersson wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> index 4d8f8636c2b3..1c042d39380c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
> [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
> [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
> [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
> - [203] = UFS_RESET(ufs_reset, 0x1d8000),
> - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
> - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
> - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
> + [203] = UFS_RESET(ufs_reset, 0xd8000),
> + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
> + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
> + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
Right, these are the offsets defined in the the documentation, sorry to
have missed updating here
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets
2021-11-04 17:08 [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets Bjorn Andersson
2021-11-06 17:08 ` Vladimir Zapolskiy
2021-11-09 7:12 ` Vinod Koul
@ 2021-11-09 20:21 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-11-09 20:21 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Vinod Koul, vladimir.zapolskiy, linux-arm-msm, linux-gpio, linux-kernel
On Thu, Nov 4, 2021 at 6:06 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-09 20:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 17:08 [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets Bjorn Andersson
2021-11-06 17:08 ` Vladimir Zapolskiy
2021-11-09 7:12 ` Vinod Koul
2021-11-09 20:21 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).