* [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string
@ 2020-01-27 16:23 Douglas Anderson
2020-01-27 17:04 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Douglas Anderson @ 2020-01-27 16:23 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross
Cc: mka, vbadigan, Douglas Anderson, devicetree, Vinod Koul,
linux-arm-msm, linux-kernel, Rob Herring, Mark Rutland
As per the bindings, the SDHCI controller should have a SoC-specific
compatible string in addition to the generic version-based one. Add
it.
Fixes: 7241ab944da3 ("arm64: dts: qcom: qcs404: Add sdcc1 node")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 4ee1e3d5f123..1eea06435779 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -685,7 +685,7 @@ pcie_phy: phy@7786000 {
};
sdcc1: sdcc@7804000 {
- compatible = "qcom,sdhci-msm-v5";
+ compatible = "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5";
reg = <0x07804000 0x1000>, <0x7805000 0x1000>;
reg-names = "hc_mem", "cmdq_mem";
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string
2020-01-27 16:23 [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string Douglas Anderson
@ 2020-01-27 17:04 ` Vinod Koul
2020-01-27 17:07 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2020-01-27 17:04 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Andy Gross, mka, vbadigan, devicetree,
linux-arm-msm, linux-kernel, Rob Herring, Mark Rutland
On 27-01-20, 08:23, Douglas Anderson wrote:
> As per the bindings, the SDHCI controller should have a SoC-specific
> compatible string in addition to the generic version-based one. Add
> it.
Thanks for spotting it Doug, Btw did some script catch it or manual
inspection?
Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Fixes: 7241ab944da3 ("arm64: dts: qcom: qcs404: Add sdcc1 node")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 4ee1e3d5f123..1eea06435779 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -685,7 +685,7 @@ pcie_phy: phy@7786000 {
> };
>
> sdcc1: sdcc@7804000 {
> - compatible = "qcom,sdhci-msm-v5";
> + compatible = "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5";
> reg = <0x07804000 0x1000>, <0x7805000 0x1000>;
> reg-names = "hc_mem", "cmdq_mem";
>
> --
> 2.25.0.341.g760bfbb309-goog
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string
2020-01-27 17:04 ` Vinod Koul
@ 2020-01-27 17:07 ` Doug Anderson
0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-01-27 17:07 UTC (permalink / raw)
To: Vinod Koul
Cc: Bjorn Andersson, Matthias Kaehlcke, Veerabhadrarao Badiganti,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML, Rob Herring, Mark Rutland, Andy Gross
Hi,
On Mon, Jan 27, 2020 at 9:05 AM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 27-01-20, 08:23, Douglas Anderson wrote:
> > As per the bindings, the SDHCI controller should have a SoC-specific
> > compatible string in addition to the generic version-based one. Add
> > it.
>
> Thanks for spotting it Doug, Btw did some script catch it or manual
> inspection?
>
>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
It probably would have been spotted by "make dtbs_check", but I wasn't
running that in this case. I just happened to notice it while
chatting with someone at Qualcomm about whether
<https://crrev.com/c/2022985> was correct (still waiting for a
response on that).
-Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-27 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 16:23 [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string Douglas Anderson
2020-01-27 17:04 ` Vinod Koul
2020-01-27 17:07 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).