[PATCH 0/3] Skip phy initialization for DWC3 USB Controllers

[PATCH 0/3] Skip phy initialization for DWC3 USB Controllers

[Sandeep Maheswaram]

DWC3 manages PHY by own driver, so skip the management by HCD core.

Sandeep Maheswaram (3):
  dt-bindings: usb: usb-xhci: Add bindings for usb-skip-phy-init
    property
  usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT
    quirk
  usb: dwc: host: Set the property usb-skip-phy-init

 Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++
 drivers/usb/dwc3/host.c                             | 2 ++
 drivers/usb/host/xhci-plat.c                        | 3 +++
 3 files changed, 9 insertions(+)

-- 
2.7.4

[PATCH 1/3] dt-bindings: usb: usb-xhci: Add bindings for usb-skip-phy-init property

[Sandeep Maheswaram]

Adding bindings for usb-skip-phy-init property.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
 Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
index 965f87f..69a757b 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
@@ -25,6 +25,10 @@ properties:
     description: Set if the controller has broken port disable mechanism
     type: boolean
 
+  usb-skip-phy-init:
+    description: Set if the phy initiazation is managed by controller
+    type: boolean
+
   imod-interval-ns:
     description: Interrupt moderation interval
     default: 5000
-- 
2.7.4

[PATCH 2/3] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk

[Sandeep Maheswaram]

Add device property usb-skip-phy-init to check and set XHCI_SKIP_PHY_INIT
quirk.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index c1edcc9..2a45f89 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -323,6 +323,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
 		if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
 			xhci->quirks |= XHCI_BROKEN_PORT_PED;
 
+		if (device_property_read_bool(tmpdev, "usb-skip-phy-init"))
+			xhci->quirks |= XHCI_SKIP_PHY_INIT;
+
 		device_property_read_u32(tmpdev, "imod-interval-ns",
 					 &xhci->imod_interval);
 	}
-- 
2.7.4

[PATCH 3/3] usb: dwc: host: Set the property usb-skip-phy-init

[Sandeep Maheswaram]

dwc3 manages PHY by own DRD driver, so skip the management by
HCD core.
During runtime suspend phy was not getting suspend because
runtime_usage value is 2.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
 drivers/usb/dwc3/host.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f29a264..5144513 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -107,6 +107,8 @@ int dwc3_host_init(struct dwc3 *dwc)
 	if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
 		props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
 
+	props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");
+
 	if (prop_idx) {
 		ret = device_create_managed_software_node(&xhci->dev, props, NULL);
 		if (ret) {
-- 
2.7.4

Re: [PATCH 3/3] usb: dwc: host: Set the property usb-skip-phy-init

[Thinh Nguyen]

Sandeep Maheswaram wrote:
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core.
> During runtime suspend phy was not getting suspend because
> runtime_usage value is 2.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  drivers/usb/dwc3/host.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f29a264..5144513 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -107,6 +107,8 @@ int dwc3_host_init(struct dwc3 *dwc)
>  	if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
>  		props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
>  
> +	props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");

Increase props[] array size with this new change.

> +
>  	if (prop_idx) {
>  		ret = device_create_managed_software_node(&xhci->dev, props, NULL);
>  		if (ret) {
> 

Can we update the $subject prefix from "dwc" to "dwc3"?

Thanks,
Thinh

Re: [PATCH 1/3] dt-bindings: usb: usb-xhci: Add bindings for usb-skip-phy-init property

[Stephen Boyd]

Quoting Sandeep Maheswaram (2021-10-26 11:19:30)
> Adding bindings for usb-skip-phy-init property.

Yes, but why?

>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> index 965f87f..69a757b 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> @@ -25,6 +25,10 @@ properties:
>      description: Set if the controller has broken port disable mechanism
>      type: boolean
>
> +  usb-skip-phy-init:
> +    description: Set if the phy initiazation is managed by controller

s/initiazation/initialization/

> +    type: boolean
> +
>    imod-interval-ns:
>      description: Interrupt moderation interval
>      default: 5000

Re: [PATCH 3/3] usb: dwc: host: Set the property usb-skip-phy-init

[Greg Kroah-Hartman]

On Tue, Oct 26, 2021 at 11:49:32PM +0530, Sandeep Maheswaram wrote:
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core.
> During runtime suspend phy was not getting suspend because
> runtime_usage value is 2.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  drivers/usb/dwc3/host.c | 2 ++
>  1 file changed, 2 insertions(+)

Subject line should have "dwc3" not "dwc", right?

thanks,

greg k-h

Re: [PATCH 2/3] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk

[Greg Kroah-Hartman]

On Tue, Oct 26, 2021 at 11:49:31PM +0530, Sandeep Maheswaram wrote:
> Add device property usb-skip-phy-init to check and set XHCI_SKIP_PHY_INIT
> quirk.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  drivers/usb/host/xhci-plat.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index c1edcc9..2a45f89 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -323,6 +323,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  		if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
>  			xhci->quirks |= XHCI_BROKEN_PORT_PED;
>  
> +		if (device_property_read_bool(tmpdev, "usb-skip-phy-init"))
> +			xhci->quirks |= XHCI_SKIP_PHY_INIT;
> +

Why is this needed?  What will it fix?

You need more information.

thanks,
greg k-h