Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc
@ 2019-11-29  7:05 Harigovindan P
  2019-12-02 19:55 ` Rob Clark
  2019-12-03 22:22 ` Matthias Kaehlcke
  0 siblings, 2 replies; 4+ messages in thread
From: Harigovindan P @ 2019-11-29  7:05 UTC (permalink / raw)
  To: dri-devel, linux-arm-msm, freedreno, devicetree
  Cc: Harigovindan P, linux-kernel, robdclark, seanpaul, hoegsberg,
	abhinavk, jsanka, chandanu, nganji

Changes in v1:
	-Modify commit text to indicate DSI version and SOC detail(Jeffrey Hugo).
	-Splitting visionox panel driver code out into a
	 different patch(set), since panel drivers are merged into
	 drm-next via a different tree(Rob Clark).

Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
---
 drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++
 drivers/gpu/drm/msm/dsi/dsi_cfg.h |  1 +
 2 files changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
index b7b7c1a..7b967dd 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
@@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = {
 	"iface", "bus",
 };
 
+static const char * const dsi_sc7180_bus_clk_names[] = {
+	"iface", "bus",
+};
+
 static const struct msm_dsi_config sdm845_dsi_cfg = {
 	.io_offset = DSI_6G_REG_SHIFT,
 	.reg_cfg = {
@@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = {
 	.num_dsi = 2,
 };
 
+static const struct msm_dsi_config sc7180_dsi_cfg = {
+	.io_offset = DSI_6G_REG_SHIFT,
+	.reg_cfg = {
+		.num = 1,
+		.regs = {
+			{"vdda", 21800, 4 },	/* 1.2 V */
+		},
+	},
+	.bus_clk_names = dsi_sc7180_bus_clk_names,
+	.num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names),
+	.io_start = { 0xae94000 },
+	.num_dsi = 1,
+};
+
 const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
 	.link_clk_enable = dsi_link_clk_enable_v2,
 	.link_clk_disable = dsi_link_clk_disable_v2,
@@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = {
 		&msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops},
 	{MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1,
 		&sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops},
+	{MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1,
+		&sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops},
+
 };
 
 const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
index e2b7a7d..9919536 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h
+++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
@@ -19,6 +19,7 @@
 #define MSM_DSI_6G_VER_MINOR_V1_4_1	0x10040001
 #define MSM_DSI_6G_VER_MINOR_V2_2_0	0x20000000
 #define MSM_DSI_6G_VER_MINOR_V2_2_1	0x20020001
+#define MSM_DSI_6G_VER_MINOR_V2_4_1	0x20040001
 
 #define MSM_DSI_V2_VER_MINOR_8064	0x0
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc
  2019-11-29  7:05 [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc Harigovindan P
@ 2019-12-02 19:55 ` Rob Clark
  2019-12-03 22:22 ` Matthias Kaehlcke
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Clark @ 2019-12-02 19:55 UTC (permalink / raw)
  To: Harigovindan P
  Cc: dri-devel, linux-arm-msm, freedreno,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Sean Paul, Kristian H. Kristensen,
	Abhinav Kumar, Jeykumar Sankaran, Chandan Uddaraju, nganji

On Thu, Nov 28, 2019 at 11:05 PM Harigovindan P <harigovi@codeaurora.org> wrote:
>
> Changes in v1:
>         -Modify commit text to indicate DSI version and SOC detail(Jeffrey Hugo).
>         -Splitting visionox panel driver code out into a
>          different patch(set), since panel drivers are merged into
>          drm-next via a different tree(Rob Clark).
>
> Signed-off-by: Harigovindan P <harigovi@codeaurora.org>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++
>  drivers/gpu/drm/msm/dsi/dsi_cfg.h |  1 +
>  2 files changed, 22 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index b7b7c1a..7b967dd 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = {
>         "iface", "bus",
>  };
>
> +static const char * const dsi_sc7180_bus_clk_names[] = {
> +       "iface", "bus",
> +};
> +
>  static const struct msm_dsi_config sdm845_dsi_cfg = {
>         .io_offset = DSI_6G_REG_SHIFT,
>         .reg_cfg = {
> @@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = {
>         .num_dsi = 2,
>  };
>
> +static const struct msm_dsi_config sc7180_dsi_cfg = {
> +       .io_offset = DSI_6G_REG_SHIFT,
> +       .reg_cfg = {
> +               .num = 1,
> +               .regs = {
> +                       {"vdda", 21800, 4 },    /* 1.2 V */
> +               },
> +       },
> +       .bus_clk_names = dsi_sc7180_bus_clk_names,
> +       .num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names),
> +       .io_start = { 0xae94000 },
> +       .num_dsi = 1,
> +};
> +
>  const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
>         .link_clk_enable = dsi_link_clk_enable_v2,
>         .link_clk_disable = dsi_link_clk_disable_v2,
> @@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = {
>                 &msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops},
>         {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1,
>                 &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> +       {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1,
> +               &sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> +
>  };
>
>  const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor)
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> index e2b7a7d..9919536 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> @@ -19,6 +19,7 @@
>  #define MSM_DSI_6G_VER_MINOR_V1_4_1    0x10040001
>  #define MSM_DSI_6G_VER_MINOR_V2_2_0    0x20000000
>  #define MSM_DSI_6G_VER_MINOR_V2_2_1    0x20020001
> +#define MSM_DSI_6G_VER_MINOR_V2_4_1    0x20040001
>
>  #define MSM_DSI_V2_VER_MINOR_8064      0x0
>
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc
  2019-11-29  7:05 [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc Harigovindan P
  2019-12-02 19:55 ` Rob Clark
@ 2019-12-03 22:22 ` Matthias Kaehlcke
  2019-12-03 22:34   ` Rob Clark
  1 sibling, 1 reply; 4+ messages in thread
From: Matthias Kaehlcke @ 2019-12-03 22:22 UTC (permalink / raw)
  To: Harigovindan P
  Cc: dri-devel, linux-arm-msm, freedreno, devicetree, linux-kernel,
	robdclark, seanpaul, hoegsberg, abhinavk, jsanka, chandanu,
	nganji

Hi,

On Fri, Nov 29, 2019 at 12:35:05PM +0530, Harigovindan P wrote:
> Changes in v1:
> 	-Modify commit text to indicate DSI version and SOC detail(Jeffrey Hugo).
> 	-Splitting visionox panel driver code out into a
> 	 different patch(set), since panel drivers are merged into
> 	 drm-next via a different tree(Rob Clark).

The change log shouldn't be part of the commit message, please place it
after the '---' separator.

I think at least a one line commit message besides the subject is
mandatory, so if you move the change log down you'll have to add
some short summary.

> Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++
>  drivers/gpu/drm/msm/dsi/dsi_cfg.h |  1 +
>  2 files changed, 22 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index b7b7c1a..7b967dd 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = {
>  	"iface", "bus",
>  };
>  
> +static const char * const dsi_sc7180_bus_clk_names[] = {
> +	"iface", "bus",
> +};
> +
>  static const struct msm_dsi_config sdm845_dsi_cfg = {
>  	.io_offset = DSI_6G_REG_SHIFT,
>  	.reg_cfg = {
> @@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = {
>  	.num_dsi = 2,
>  };
>  
> +static const struct msm_dsi_config sc7180_dsi_cfg = {
> +	.io_offset = DSI_6G_REG_SHIFT,
> +	.reg_cfg = {
> +		.num = 1,
> +		.regs = {
> +			{"vdda", 21800, 4 },	/* 1.2 V */
> +		},
> +	},
> +	.bus_clk_names = dsi_sc7180_bus_clk_names,
> +	.num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names),
> +	.io_start = { 0xae94000 },
> +	.num_dsi = 1,
> +};
> +
>  const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
>  	.link_clk_enable = dsi_link_clk_enable_v2,
>  	.link_clk_disable = dsi_link_clk_disable_v2,
> @@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = {
>  		&msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops},
>  	{MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1,
>  		&sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> +	{MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1,
> +		&sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> +
>  };
>  
>  const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor)
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> index e2b7a7d..9919536 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> @@ -19,6 +19,7 @@
>  #define MSM_DSI_6G_VER_MINOR_V1_4_1	0x10040001
>  #define MSM_DSI_6G_VER_MINOR_V2_2_0	0x20000000
>  #define MSM_DSI_6G_VER_MINOR_V2_2_1	0x20020001
> +#define MSM_DSI_6G_VER_MINOR_V2_4_1	0x20040001
>  
>  #define MSM_DSI_V2_VER_MINOR_8064	0x0
>  
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc
  2019-12-03 22:22 ` Matthias Kaehlcke
@ 2019-12-03 22:34   ` Rob Clark
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Clark @ 2019-12-03 22:34 UTC (permalink / raw)
  To: Matthias Kaehlcke
  Cc: Harigovindan P, dri-devel, linux-arm-msm, freedreno,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Sean Paul, Kristian H. Kristensen,
	Abhinav Kumar, Jeykumar Sankaran, Chandan Uddaraju, nganji

On Tue, Dec 3, 2019 at 2:22 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Hi,
>
> On Fri, Nov 29, 2019 at 12:35:05PM +0530, Harigovindan P wrote:
> > Changes in v1:
> >       -Modify commit text to indicate DSI version and SOC detail(Jeffrey Hugo).
> >       -Splitting visionox panel driver code out into a
> >        different patch(set), since panel drivers are merged into
> >        drm-next via a different tree(Rob Clark).
>
> The change log shouldn't be part of the commit message, please place it
> after the '---' separator.

jfyi, the changelog and version #'s showing up in final commit msg is
one thing that drm does differently from other parts of the kernel.
So it is ok to keep the changelog before "---".

But agreed about the need for a commit message (in addition to just
the changelog)

BR,
-R

> I think at least a one line commit message besides the subject is
> mandatory, so if you move the change log down you'll have to add
> some short summary.
>
> > Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
> > ---
> >  drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++
> >  drivers/gpu/drm/msm/dsi/dsi_cfg.h |  1 +
> >  2 files changed, 22 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> > index b7b7c1a..7b967dd 100644
> > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> > @@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = {
> >       "iface", "bus",
> >  };
> >
> > +static const char * const dsi_sc7180_bus_clk_names[] = {
> > +     "iface", "bus",
> > +};
> > +
> >  static const struct msm_dsi_config sdm845_dsi_cfg = {
> >       .io_offset = DSI_6G_REG_SHIFT,
> >       .reg_cfg = {
> > @@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = {
> >       .num_dsi = 2,
> >  };
> >
> > +static const struct msm_dsi_config sc7180_dsi_cfg = {
> > +     .io_offset = DSI_6G_REG_SHIFT,
> > +     .reg_cfg = {
> > +             .num = 1,
> > +             .regs = {
> > +                     {"vdda", 21800, 4 },    /* 1.2 V */
> > +             },
> > +     },
> > +     .bus_clk_names = dsi_sc7180_bus_clk_names,
> > +     .num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names),
> > +     .io_start = { 0xae94000 },
> > +     .num_dsi = 1,
> > +};
> > +
> >  const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
> >       .link_clk_enable = dsi_link_clk_enable_v2,
> >       .link_clk_disable = dsi_link_clk_disable_v2,
> > @@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = {
> >               &msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> >       {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1,
> >               &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> > +     {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1,
> > +             &sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> > +
> >  };
> >
> >  const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor)
> > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> > index e2b7a7d..9919536 100644
> > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> > @@ -19,6 +19,7 @@
> >  #define MSM_DSI_6G_VER_MINOR_V1_4_1  0x10040001
> >  #define MSM_DSI_6G_VER_MINOR_V2_2_0  0x20000000
> >  #define MSM_DSI_6G_VER_MINOR_V2_2_1  0x20020001
> > +#define MSM_DSI_6G_VER_MINOR_V2_4_1  0x20040001
> >
> >  #define MSM_DSI_V2_VER_MINOR_8064    0x0
> >
> > --
> > 2.7.4
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29  7:05 [PATCH v1] drm/msm: add support for 2.4.1 DSI version for sc7180 soc Harigovindan P
2019-12-02 19:55 ` Rob Clark
2019-12-03 22:22 ` Matthias Kaehlcke
2019-12-03 22:34   ` Rob Clark

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git