Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] drm/msm: always parse interconnects
@ 2021-04-17 16:21 Caleb Connolly
  2021-04-17 17:52 ` Rob Clark
  0 siblings, 1 reply; 2+ messages in thread
From: Caleb Connolly @ 2021-04-17 16:21 UTC (permalink / raw)
  To: caleb, Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kalyan Thota
  Cc: ~postmarketos/upstreaming, linux-arm-msm, Rob Clark, dri-devel,
	freedreno, linux-kernel

The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
platforms. As SDM845 now has interconnects hooked up we should always
try and parse them.

Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 85f2c3564c96..fb061e666faa 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -933,8 +933,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
 		DPU_DEBUG("REG_DMA is not defined");
 	}
 
-	if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
-		dpu_kms_parse_data_bus_icc_path(dpu_kms);
+	dpu_kms_parse_data_bus_icc_path(dpu_kms);
 
 	pm_runtime_get_sync(&dpu_kms->pdev->dev);
 
-- 
2.30.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/msm: always parse interconnects
  2021-04-17 16:21 [PATCH] drm/msm: always parse interconnects Caleb Connolly
@ 2021-04-17 17:52 ` Rob Clark
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Clark @ 2021-04-17 17:52 UTC (permalink / raw)
  To: Caleb Connolly
  Cc: Sean Paul, David Airlie, Daniel Vetter, Kalyan Thota,
	~postmarketos/upstreaming, linux-arm-msm, Rob Clark, dri-devel,
	freedreno, Linux Kernel Mailing List

On Sat, Apr 17, 2021 at 9:21 AM Caleb Connolly <caleb@connolly.tech> wrote:
>
> The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
> platforms. As SDM845 now has interconnects hooked up we should always
> try and parse them.
>
> Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>

I believe this series in msm-next already solves this

https://patchwork.freedesktop.org/series/88644/

BR,
-R

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 85f2c3564c96..fb061e666faa 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -933,8 +933,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
>                 DPU_DEBUG("REG_DMA is not defined");
>         }
>
> -       if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
> -               dpu_kms_parse_data_bus_icc_path(dpu_kms);
> +       dpu_kms_parse_data_bus_icc_path(dpu_kms);
>
>         pm_runtime_get_sync(&dpu_kms->pdev->dev);
>
> --
> 2.30.2
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 16:21 [PATCH] drm/msm: always parse interconnects Caleb Connolly
2021-04-17 17:52 ` Rob Clark

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git