* [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node
@ 2020-03-17 7:40 Rajeshwari
2020-03-17 10:52 ` Amit Kucheria
2020-03-17 16:50 ` Doug Anderson
0 siblings, 2 replies; 5+ messages in thread
From: Rajeshwari @ 2020-03-17 7:40 UTC (permalink / raw)
To: Andy Gross, Rob Herring, Mark Rutland, Bjorn Andersson, Amit Kucheria
Cc: linux-arm-msm, devicetree, linux-kernel, sivaa, sanm,
Doug Anderson, Rajeshwari
Changed polling-delay and polling-delay-passive to zero as per
the requirement.
Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index ca876ed..d81c4f1 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1907,8 +1907,8 @@
thermal-zones {
cpu0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 1>;
@@ -1955,8 +1955,8 @@
};
cpu1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 2>;
@@ -2003,8 +2003,8 @@
};
cpu2-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 3>;
@@ -2051,8 +2051,8 @@
};
cpu3-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 4>;
@@ -2099,8 +2099,8 @@
};
cpu4-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 5>;
@@ -2147,8 +2147,8 @@
};
cpu5-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 6>;
@@ -2195,8 +2195,8 @@
};
cpu6-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 9>;
@@ -2235,8 +2235,8 @@
};
cpu7-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 10>;
@@ -2275,8 +2275,8 @@
};
cpu8-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 11>;
@@ -2315,8 +2315,8 @@
};
cpu9-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 12>;
@@ -2355,8 +2355,8 @@
};
aoss0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 0>;
@@ -2376,8 +2376,8 @@
};
cpuss0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 7>;
@@ -2396,8 +2396,8 @@
};
cpuss1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 8>;
@@ -2416,8 +2416,8 @@
};
gpuss0-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 13>;
@@ -2437,8 +2437,8 @@
};
gpuss1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens0 14>;
@@ -2458,8 +2458,8 @@
};
aoss1-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 0>;
@@ -2479,8 +2479,8 @@
};
cwlan-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 1>;
@@ -2500,8 +2500,8 @@
};
audio-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 2>;
@@ -2521,8 +2521,8 @@
};
ddr-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 3>;
@@ -2542,8 +2542,8 @@
};
q6-hvx-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 4>;
@@ -2563,8 +2563,8 @@
};
camera-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 5>;
@@ -2584,8 +2584,8 @@
};
mdm-core-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 6>;
@@ -2605,8 +2605,8 @@
};
mdm-dsp-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 7>;
@@ -2626,8 +2626,8 @@
};
npu-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 8>;
@@ -2647,8 +2647,8 @@
};
video-thermal {
- polling-delay-passive = <250>;
- polling-delay = <1000>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
thermal-sensors = <&tsens1 9>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node
2020-03-17 7:40 [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node Rajeshwari
@ 2020-03-17 10:52 ` Amit Kucheria
2020-03-17 16:50 ` Doug Anderson
1 sibling, 0 replies; 5+ messages in thread
From: Amit Kucheria @ 2020-03-17 10:52 UTC (permalink / raw)
To: Rajeshwari
Cc: Andy Gross, Rob Herring, Mark Rutland, Bjorn Andersson,
linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
sivaa, sanm, Doug Anderson
On Tue, Mar 17, 2020 at 1:11 PM Rajeshwari <rkambl@codeaurora.org> wrote:
>
> Changed polling-delay and polling-delay-passive to zero as per
> the requirement.
>
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
> 1 file changed, 50 insertions(+), 50 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index ca876ed..d81c4f1 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1907,8 +1907,8 @@
>
> thermal-zones {
> cpu0-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 1>;
>
> @@ -1955,8 +1955,8 @@
> };
>
> cpu1-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 2>;
>
> @@ -2003,8 +2003,8 @@
> };
>
> cpu2-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 3>;
>
> @@ -2051,8 +2051,8 @@
> };
>
> cpu3-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 4>;
>
> @@ -2099,8 +2099,8 @@
> };
>
> cpu4-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 5>;
>
> @@ -2147,8 +2147,8 @@
> };
>
> cpu5-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 6>;
>
> @@ -2195,8 +2195,8 @@
> };
>
> cpu6-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 9>;
>
> @@ -2235,8 +2235,8 @@
> };
>
> cpu7-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 10>;
>
> @@ -2275,8 +2275,8 @@
> };
>
> cpu8-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 11>;
>
> @@ -2315,8 +2315,8 @@
> };
>
> cpu9-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 12>;
>
> @@ -2355,8 +2355,8 @@
> };
>
> aoss0-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 0>;
>
> @@ -2376,8 +2376,8 @@
> };
>
> cpuss0-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 7>;
>
> @@ -2396,8 +2396,8 @@
> };
>
> cpuss1-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 8>;
>
> @@ -2416,8 +2416,8 @@
> };
>
> gpuss0-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 13>;
>
> @@ -2437,8 +2437,8 @@
> };
>
> gpuss1-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens0 14>;
>
> @@ -2458,8 +2458,8 @@
> };
>
> aoss1-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 0>;
>
> @@ -2479,8 +2479,8 @@
> };
>
> cwlan-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 1>;
>
> @@ -2500,8 +2500,8 @@
> };
>
> audio-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 2>;
>
> @@ -2521,8 +2521,8 @@
> };
>
> ddr-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 3>;
>
> @@ -2542,8 +2542,8 @@
> };
>
> q6-hvx-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 4>;
>
> @@ -2563,8 +2563,8 @@
> };
>
> camera-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 5>;
>
> @@ -2584,8 +2584,8 @@
> };
>
> mdm-core-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 6>;
>
> @@ -2605,8 +2605,8 @@
> };
>
> mdm-dsp-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 7>;
>
> @@ -2626,8 +2626,8 @@
> };
>
> npu-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 8>;
>
> @@ -2647,8 +2647,8 @@
> };
>
> video-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <1000>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> thermal-sensors = <&tsens1 9>;
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node
2020-03-17 7:40 [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node Rajeshwari
2020-03-17 10:52 ` Amit Kucheria
@ 2020-03-17 16:50 ` Doug Anderson
[not found] ` <fc7f250e-aa85-0835-8bc4-8274235c74d0@codeaurora.org>
1 sibling, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2020-03-17 16:50 UTC (permalink / raw)
To: Rajeshwari
Cc: Andy Gross, Rob Herring, Mark Rutland, Bjorn Andersson,
Amit Kucheria, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
sivaa, Sandeep Maheswaram
Hi,
On Tue, Mar 17, 2020 at 12:42 AM Rajeshwari <rkambl@codeaurora.org> wrote:
>
> Changed polling-delay and polling-delay-passive to zero as per
> the requirement.
>
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
> 1 file changed, 50 insertions(+), 50 deletions(-)
It probably wouldn't hurt to mention in the commit message that this
is because the thermal sensor interrupts are all hooked up and thus
the polling is not a useful thing to do. ...but other than that:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node
[not found] ` <fc7f250e-aa85-0835-8bc4-8274235c74d0@codeaurora.org>
@ 2020-03-18 9:10 ` Amit Kucheria
2020-04-03 18:16 ` Matthias Kaehlcke
0 siblings, 1 reply; 5+ messages in thread
From: Amit Kucheria @ 2020-03-18 9:10 UTC (permalink / raw)
To: Rajeshwari Ravindra Kamble (Temp)
Cc: Doug Anderson, Andy Gross, Rob Herring, Mark Rutland,
Bjorn Andersson, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
sivaa, Sandeep Maheswaram
On Wed, Mar 18, 2020 at 11:49 AM Rajeshwari Ravindra Kamble (Temp)
<rkambl@codeaurora.org> wrote:
>
>
> On 3/17/2020 10:20 PM, Doug Anderson wrote:
>
> Hi,
>
> On Tue, Mar 17, 2020 at 12:42 AM Rajeshwari <rkambl@codeaurora.org> wrote:
>
> Changed polling-delay and polling-delay-passive to zero as per
> the requirement.
>
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
> 1 file changed, 50 insertions(+), 50 deletions(-)
>
> It probably wouldn't hurt to mention in the commit message that this
> is because the thermal sensor interrupts are all hooked up and thus
> the polling is not a useful thing to do. ...but other than that:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
>
> Hi Douglas
>
> I didn't get your comment.
>
> Thanks,
> Rajeshwari
I think he means that you haven't mentioned WHY this patch is needed
in the message. The reason you should mention is "to disable polling
mode of the framework since interrupts for tsens are already
configured."
Regards,
Amit
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node
2020-03-18 9:10 ` Amit Kucheria
@ 2020-04-03 18:16 ` Matthias Kaehlcke
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Kaehlcke @ 2020-04-03 18:16 UTC (permalink / raw)
To: Rajeshwari Ravindra Kamble (Temp)
Cc: Amit Kucheria, Doug Anderson, Andy Gross, Rob Herring,
Mark Rutland, Bjorn Andersson, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
sivaa, Sandeep Maheswaram
Hi Rajeshwari,
do you plan to send v2 with an updated commit message?
Thanks
Matthias
On Wed, Mar 18, 2020 at 02:40:47PM +0530, Amit Kucheria wrote:
> On Wed, Mar 18, 2020 at 11:49 AM Rajeshwari Ravindra Kamble (Temp)
> <rkambl@codeaurora.org> wrote:
> >
> >
> > On 3/17/2020 10:20 PM, Doug Anderson wrote:
> >
> > Hi,
> >
> > On Tue, Mar 17, 2020 at 12:42 AM Rajeshwari <rkambl@codeaurora.org> wrote:
> >
> > Changed polling-delay and polling-delay-passive to zero as per
> > the requirement.
> >
> > Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
> > 1 file changed, 50 insertions(+), 50 deletions(-)
> >
> > It probably wouldn't hurt to mention in the commit message that this
> > is because the thermal sensor interrupts are all hooked up and thus
> > the polling is not a useful thing to do. ...but other than that:
> >
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >
> >
> > Hi Douglas
> >
> > I didn't get your comment.
> >
> > Thanks,
> > Rajeshwari
>
> I think he means that you haven't mentioned WHY this patch is needed
> in the message. The reason you should mention is "to disable polling
> mode of the framework since interrupts for tsens are already
> configured."
>
> Regards,
> Amit
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-03 18:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 7:40 [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node Rajeshwari
2020-03-17 10:52 ` Amit Kucheria
2020-03-17 16:50 ` Doug Anderson
[not found] ` <fc7f250e-aa85-0835-8bc4-8274235c74d0@codeaurora.org>
2020-03-18 9:10 ` Amit Kucheria
2020-04-03 18:16 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).